From a17d512e456b39fdd044bc58a84bbe0eee4d9822 Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Fri, 29 Sep 2023 10:05:08 +0530
Subject: [PATCH] fix: i18n for Barcode

---
 .../smartsheet/column/BarcodeOptions.vue          | 15 ++++++++-------
 .../components/smartsheet/column/DefaultValue.vue |  2 +-
 packages/nc-gui/lang/en.json                      |  4 ++++
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/column/BarcodeOptions.vue b/packages/nc-gui/components/smartsheet/column/BarcodeOptions.vue
index 743de8b473..6eff937686 100644
--- a/packages/nc-gui/components/smartsheet/column/BarcodeOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/BarcodeOptions.vue
@@ -22,6 +22,8 @@ const vModel = useVModel(props, 'modelValue', emit)
 
 const { setAdditionalValidations, validateInfos, column } = useColumnCreateStoreOrThrow()
 
+const { t } = useI18n()
+
 const columnsAllowedAsBarcodeValue = computed<SelectProps['options']>(() => {
   return fields.value
     ?.filter(
@@ -67,8 +69,8 @@ watch(columnsAllowedAsBarcodeValue, (newColumnsAllowedAsBarcodeValue) => {
 })
 
 setAdditionalValidations({
-  fk_barcode_value_column_id: [{ required: true, message: 'Required' }],
-  barcode_format: [{ required: true, message: 'Required' }],
+  fk_barcode_value_column_id: [{ required: true, message: t('general.required') }],
+  barcode_format: [{ required: true, message: t('general.required') }],
 })
 
 const showBarcodeValueColumnInfoIcon = computed(() => !columnsAllowedAsBarcodeValue.value?.length)
@@ -86,16 +88,15 @@ const showBarcodeValueColumnInfoIcon = computed(() => !columnsAllowedAsBarcodeVa
           <a-select
             v-model:value="vModel.fk_barcode_value_column_id"
             :options="columnsAllowedAsBarcodeValue"
-            placeholder="Select a column for the Barcode value"
-            not-found-content="No valid Column Type can be found."
+            :placeholder="$t('placeholder.barcodeColumn')"
+            :not-found-content="$t('placeholder.notFoundContent')"
             @click.stop
           />
           <div v-if="showBarcodeValueColumnInfoIcon" class="pl-2">
             <a-tooltip placement="bottom">
               <template #title>
                 <span>
-                  The valid Column Types for a Barcode Column are: Number, Single Line Text, Long Text, Phone Number, URL, Email,
-                  Decimal. Please create one first.
+                  {{ $t('msg.validColumnsForBarCode') }}
                 </span>
               </template>
               <component :is="iconMap.info" class="cursor-pointer" />
@@ -111,7 +112,7 @@ const showBarcodeValueColumnInfoIcon = computed(() => !columnsAllowedAsBarcodeVa
         <a-select
           v-model:value="vModel.meta.barcodeFormat"
           :options="supportedBarcodeFormats"
-          placeholder="Select a Barcode format"
+          :placeholder="$t('placeholder.selectBarcodeFormat')"
           @click.stop
         />
       </a-form-item>
diff --git a/packages/nc-gui/components/smartsheet/column/DefaultValue.vue b/packages/nc-gui/components/smartsheet/column/DefaultValue.vue
index 6c205f86f1..cc266a4063 100644
--- a/packages/nc-gui/components/smartsheet/column/DefaultValue.vue
+++ b/packages/nc-gui/components/smartsheet/column/DefaultValue.vue
@@ -46,7 +46,7 @@ useProvideSmartsheetRowStore(vModel, rowRef)
 </script>
 
 <template>
-  <div class="!my-3 text-xs">Default Value</div>
+  <div class="!my-3 text-xs">{{ $t('placeholder.defaultValue') }}</div>
   <div class="flex flex-row gap-2">
     <div class="border-1 flex items-center w-full px-3 my-[-4px] border-gray-300 rounded-md">
       <LazySmartsheetCell :column="vModel" :model-value="cdfValue" :edit-enabled="true" />
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 0455eebeff..3a1b6d6ca1 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -737,6 +737,9 @@
     "clientCA": "Select CA file"
   },
   "placeholder": {
+    "barcodeColumn": "Select a column for the Barcode value",
+    "notFoundContent": "No valid Column Type can be found.",
+    "selectBarcodeFormat": "Select a Barcode format",
     "projName": "Enter Project Name",
     "selectGroupField": "Select a Grouping Field",
     "selectGroupFieldNotFound" : "No Single Select Field can be found. Please create one first.",
@@ -761,6 +764,7 @@
     "selectField": "Select field"
   },
   "msg": {
+    "validColumnsForBarCode": "The valid Column Types for a Barcode Column are: Number, Single Line Text, Long Text, Phone Number, URL, Email, Decimal. Please create one first.",
     "hm": {
       "title": "Has Many Relation",
       "icon": "HasManyIcon",