From 9f43500d4fa2cbdd7df8304472347e90fd4e1293 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Sat, 21 Jan 2023 12:58:56 +0800
Subject: [PATCH] chore(nc-gui): revise comments

---
 .../components/cell/attachment/index.vue      |  3 +-
 .../components/cell/attachment/utils.ts       | 34 ++++++++++++-------
 2 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/packages/nc-gui/components/cell/attachment/index.vue b/packages/nc-gui/components/cell/attachment/index.vue
index 7a22e43120..7cf0364f86 100644
--- a/packages/nc-gui/components/cell/attachment/index.vue
+++ b/packages/nc-gui/components/cell/attachment/index.vue
@@ -103,7 +103,8 @@ watch(
       try {
         let nextAttachments = ((typeof nextModel === 'string' ? JSON.parse(nextModel) : nextModel) || []).filter(Boolean)
 
-        // update the url
+        // reconstruct the url
+        // See /packages/nocodb/src/lib/version-upgrader/ncAttachmentUpgrader.ts for the details
         nextAttachments = await Promise.all(
           nextAttachments.map(async (attachment: any) => ({
             ...attachment,
diff --git a/packages/nc-gui/components/cell/attachment/utils.ts b/packages/nc-gui/components/cell/attachment/utils.ts
index 892eb8497b..5812e94100 100644
--- a/packages/nc-gui/components/cell/attachment/utils.ts
+++ b/packages/nc-gui/components/cell/attachment/utils.ts
@@ -99,7 +99,12 @@ export const [useProvideAttachmentCell, useAttachmentCell] = useInjectionState(
           Array.from(selectedFiles).map(
             (file) =>
               new Promise<AttachmentType>((resolve) => {
-                const res: AttachmentType & { file: File } = { ...file, file, title: file.name, mimetype: file.type }
+                const res: { file: File; title: string; mimetype: string; data?: any } = {
+                  ...file,
+                  file,
+                  title: file.name,
+                  mimetype: file.type,
+                }
 
                 if (isImage(file.name, (<any>file).mimetype ?? file.type)) {
                   const reader = new FileReader()
@@ -221,20 +226,25 @@ export const [useProvideAttachmentCell, useAttachmentCell] = useInjectionState(
       ;(await import('file-saver')).saveAs(item.url || item.data, item.title)
     }
 
-    /** construct the attachment url */
+    /** construct the attachment url
+     * See /packages/nocodb/src/lib/version-upgrader/ncAttachmentUpgrader.ts for the details
+     * */
     async function getAttachmentUrl(item: AttachmentType) {
       const path = item?.path
-      // if path doesn't exist, use `url`
-      if (!path) return Promise.resolve(item.url)
-      // try ${appInfo.value.ncSiteUrl}/${item.path} first
-      const url = `${appInfo.value.ncSiteUrl}/${item.path}`
-      try {
-        const res = await fetch(url)
-        if (res.ok) {
-          return Promise.resolve(url)
+      // if path doesn't exist, use `item.url`
+      if (path) {
+        // try ${appInfo.value.ncSiteUrl}/${item.path} first
+        const url = `${appInfo.value.ncSiteUrl}/${item.path}`
+        try {
+          const res = await fetch(url)
+          if (res.ok) {
+            // use `url` if it is accessible
+            return Promise.resolve(url)
+          }
+        } catch {
+          // for some cases, `url` is not accessible as expected
+          // do nothing here
         }
-      } catch {
-        // do nothing
       }
       // if it fails, use the original url
       return Promise.resolve(item.url)