From 9da06772801d84b83226a98031c009e96e5612c9 Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Fri, 29 Sep 2023 10:45:38 +0530
Subject: [PATCH] fix: i18n for DateTime

---
 packages/nc-gui/components/cell/DateTimePicker.vue        | 8 +++++---
 .../components/smartsheet/column/DateTimeOptions.vue      | 4 ++--
 packages/nc-gui/lang/en.json                              | 1 +
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/packages/nc-gui/components/cell/DateTimePicker.vue b/packages/nc-gui/components/cell/DateTimePicker.vue
index c0a3960d23..2b371829dd 100644
--- a/packages/nc-gui/components/cell/DateTimePicker.vue
+++ b/packages/nc-gui/components/cell/DateTimePicker.vue
@@ -40,6 +40,8 @@ const editable = inject(EditModeInj, ref(false))
 
 const isLockedMode = inject(IsLockedInj, ref(false))
 
+const { t } = useI18n()
+
 const isEditColumn = inject(EditColumnInj, ref(false))
 
 const column = inject(ColumnInj)!
@@ -137,11 +139,11 @@ watch(
 
 const placeholder = computed(() => {
   if (isEditColumn.value && (modelValue === '' || modelValue === null)) {
-    return '(Optional)'
+    return t('labels.optional')
   } else if (modelValue === null && showNull.value) {
-    return 'NULL'
+    return t('general.null')
   } else if (isDateInvalid.value) {
-    return 'Invalid date'
+    return t('msg.invalidDate')
   } else {
     return ''
   }
diff --git a/packages/nc-gui/components/smartsheet/column/DateTimeOptions.vue b/packages/nc-gui/components/smartsheet/column/DateTimeOptions.vue
index 152b504fd4..90386141d3 100644
--- a/packages/nc-gui/components/smartsheet/column/DateTimeOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/DateTimeOptions.vue
@@ -21,14 +21,14 @@ if (!vModel.value.meta?.time_format) {
 </script>
 
 <template>
-  <a-form-item label="Date Format">
+  <a-form-item :label="$t('labels.dateFormat')">
     <a-select v-model:value="vModel.meta.date_format" class="nc-date-select" dropdown-class-name="nc-dropdown-date-format">
       <a-select-option v-for="(format, i) of dateFormats" :key="i" :value="format">
         {{ format }}
       </a-select-option>
     </a-select>
   </a-form-item>
-  <a-form-item label="Time Format">
+  <a-form-item :label="$t('labels.timeFormat')">
     <a-select v-model:value="vModel.meta.time_format" class="nc-time-select" dropdown-class-name="nc-dropdown-time-format">
       <a-select-option v-for="(format, i) of timeFormats" :key="i" :value="format">
         {{ format }}
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 0a52c751e2..11d0d9c6c8 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -350,6 +350,7 @@
   },
   "labels": {
     "dateFormat": "Date Format",
+    "timeFormat": "Time Format",
     "singularLabel": "Singular Label",
     "pluralLabel": "Plural Label",
     "optional": "Optional",