From 9d7c704791caf634edb61959c2da79252b5ef5c5 Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa010199@gmail.com>
Date: Thu, 15 Sep 2022 10:57:07 +0530
Subject: [PATCH] feat/Minor cleanup

---
 packages/nc-gui/components/dashboard/settings/Erd.vue         | 4 ++--
 packages/nc-gui/components/dashboard/settings/Modal.vue       | 3 +++
 packages/nc-gui/components/smartsheet-toolbar/Erd.vue         | 2 +-
 packages/nc-gui/components/smartsheet-toolbar/ViewActions.vue | 2 +-
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/settings/Erd.vue b/packages/nc-gui/components/dashboard/settings/Erd.vue
index 57a6856fa0..6e865d5e39 100644
--- a/packages/nc-gui/components/dashboard/settings/Erd.vue
+++ b/packages/nc-gui/components/dashboard/settings/Erd.vue
@@ -42,11 +42,11 @@ const localTables = computed(() =>
 
       <div class="absolute top-1 right-8 flex-col bg-white py-2 px-4 border-1 border-gray-100 rounded-md z-50 space-y-1">
         <div class="flex flex-row items-center">
-          <a-checkbox v-model:checked="config.showPkAndFk" />
+          <a-checkbox v-model:checked="config.showPkAndFk" v-e="['c:erd:showPkAndFk']" />
           <span class="ml-2" style="font-size: 0.65rem">Show PK and FK</span>
         </div>
         <div class="flex flex-row items-center">
-          <a-checkbox v-model:checked="config.showViews" />
+          <a-checkbox v-model:checked="config.showViews" v-e="['c:erd:showViews']" />
           <span class="ml-2" style="font-size: 0.65rem">Show views</span>
         </div>
       </div>
diff --git a/packages/nc-gui/components/dashboard/settings/Modal.vue b/packages/nc-gui/components/dashboard/settings/Modal.vue
index 94c0478b2e..1fc4e16412 100644
--- a/packages/nc-gui/components/dashboard/settings/Modal.vue
+++ b/packages/nc-gui/components/dashboard/settings/Modal.vue
@@ -112,6 +112,9 @@ const tabsInfo: TabGroup = {
       erd: {
         title: t('title.erdView'),
         body: Erd,
+        onClick: () => {
+          $e('c:settings:erd')
+        },
       },
       misc: {
         title: t('general.misc'),
diff --git a/packages/nc-gui/components/smartsheet-toolbar/Erd.vue b/packages/nc-gui/components/smartsheet-toolbar/Erd.vue
index 02f08b1afa..8ce8ae649f 100644
--- a/packages/nc-gui/components/smartsheet-toolbar/Erd.vue
+++ b/packages/nc-gui/components/smartsheet-toolbar/Erd.vue
@@ -53,7 +53,7 @@ const localTables = computed(() => (meta ? [meta.value, ...relatedTables.value]
 
       <div class="absolute top-3 right-11 flex-col bg-white py-2 px-4 border-1 border-gray-100 rounded-md z-50 space-y-1">
         <div class="flex flex-row items-center">
-          <a-checkbox v-model:checked="config.showPkAndFk" />
+          <a-checkbox v-model:checked="config.showPkAndFk" v-e="['c:erd:open']" />
           <span class="ml-2" style="font-size: 0.65rem">Show PK and FK</span>
         </div>
       </div>
diff --git a/packages/nc-gui/components/smartsheet-toolbar/ViewActions.vue b/packages/nc-gui/components/smartsheet-toolbar/ViewActions.vue
index b97d7e0068..7ca02e4186 100644
--- a/packages/nc-gui/components/smartsheet-toolbar/ViewActions.vue
+++ b/packages/nc-gui/components/smartsheet-toolbar/ViewActions.vue
@@ -216,7 +216,7 @@ const { isSqlView } = useSmartsheetStoreOrThrow()
               </div>
             </a-menu-item>
             <a-menu-item>
-              <div v-t="['c:erd:open']" class="py-2 flex gap-2 items-center" @click="showErd = true">
+              <div v-e="['c:erd:open']" class="py-2 flex gap-2 items-center" @click="showErd = true">
                 <AcountTreeRoundedIcon class="text-gray-500" />
                 {{ $t('title.erdView') }}
               </div>