From 9c61b18f0aee3858f255efb6b5495742e035466a Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Thu, 9 Feb 2023 11:40:55 +0530
Subject: [PATCH] fix(gui): hide attachment edit option in readonly mode

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../components/cell/attachment/Modal.vue      |  5 +++-
 .../nc-gui/components/template/Editor.vue     | 16 +++++--------
 .../nc-gui/components/virtual-cell/Lookup.vue | 23 +++++++++++++------
 3 files changed, 26 insertions(+), 18 deletions(-)

diff --git a/packages/nc-gui/components/cell/attachment/Modal.vue b/packages/nc-gui/components/cell/attachment/Modal.vue
index 23576227dd..ff9bbc0cdb 100644
--- a/packages/nc-gui/components/cell/attachment/Modal.vue
+++ b/packages/nc-gui/components/cell/attachment/Modal.vue
@@ -146,7 +146,10 @@ function onRemoveFileClick(title: any, i: number) {
               </div>
             </a-tooltip>
 
-            <a-tooltip placement="bottom">
+            <a-tooltip
+              v-if="isSharedForm || (!readOnly && isUIAllowed('tableAttachment') && !isPublic && !isLocked)"
+              placement="bottom"
+            >
               <template #title> Rename File </template>
 
               <div class="nc-attachment-download group-hover:(opacity-100) mr-[35px]">
diff --git a/packages/nc-gui/components/template/Editor.vue b/packages/nc-gui/components/template/Editor.vue
index a6be949176..7a077e045e 100644
--- a/packages/nc-gui/components/template/Editor.vue
+++ b/packages/nc-gui/components/template/Editor.vue
@@ -501,16 +501,12 @@ async function importTemplate() {
             }
           }
         }
-        const createdTable = await $api.base.tableCreate(
-          project.value?.id as string,
-          (baseId || project.value?.bases?.[0].id)!,
-          {
-            table_name: table.table_name,
-            // leave title empty to get a generated one based on table_name
-            title: '',
-            columns: table.columns || [],
-          },
-        )
+        const createdTable = await $api.base.tableCreate(project.value?.id as string, (baseId || project.value?.bases?.[0].id)!, {
+          table_name: table.table_name,
+          // leave title empty to get a generated one based on table_name
+          title: '',
+          columns: table.columns || [],
+        })
         table.id = createdTable.id
         table.title = createdTable.title
 
diff --git a/packages/nc-gui/components/virtual-cell/Lookup.vue b/packages/nc-gui/components/virtual-cell/Lookup.vue
index bfd742f8a6..ac60e858b4 100644
--- a/packages/nc-gui/components/virtual-cell/Lookup.vue
+++ b/packages/nc-gui/components/virtual-cell/Lookup.vue
@@ -92,12 +92,17 @@ const { showEditNonEditableFieldWarning, showClearNonEditableFieldWarning, activ
               :edit-enabled="false"
               :model-value="v"
               :column="lookupColumn"
-              :readOnly="true"
+              :read-only="true"
             />
           </template>
 
-          <LazySmartsheetVirtualCell v-else :edit-enabled="false"
-                                     :readOnly="true" :model-value="arrValue" :column="lookupColumn" />
+          <LazySmartsheetVirtualCell
+            v-else
+            :edit-enabled="false"
+            :read-only="true"
+            :model-value="arrValue"
+            :column="lookupColumn"
+          />
         </div>
 
         <!-- Render normal cell -->
@@ -106,8 +111,7 @@ const { showEditNonEditableFieldWarning, showClearNonEditableFieldWarning, activ
             v-if="isAttachment(lookupColumn) && arrValue[0] && !Array.isArray(arrValue[0]) && typeof arrValue[0] === 'object'"
             class="min-w-max"
           >
-            <LazySmartsheetCell :model-value="arrValue" :column="lookupColumn" :edit-enabled="false"
-                                :readOnly="true" />
+            <LazySmartsheetCell :model-value="arrValue" :column="lookupColumn" :edit-enabled="false" :read-only="true" />
           </div>
           <!-- For attachment cell avoid adding chip style -->
           <template v-else>
@@ -122,8 +126,13 @@ const { showEditNonEditableFieldWarning, showClearNonEditableFieldWarning, activ
                 ),
               }"
             >
-              <LazySmartsheetCell :model-value="v" :column="lookupColumn" :edit-enabled="false" :virtual="true"
-                                  :readOnly="true" />
+              <LazySmartsheetCell
+                :model-value="v"
+                :column="lookupColumn"
+                :edit-enabled="false"
+                :virtual="true"
+                :read-only="true"
+              />
             </div>
           </template>
         </template>