From 9bf51819342c4b80c2898393c46a18a09f06fad2 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Fri, 2 Sep 2022 10:52:24 +0800 Subject: [PATCH] enhancement: add try catch for covering search mismatch type --- .../lib/meta/api/dataApis/dataAliasApis.ts | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/packages/nocodb/src/lib/meta/api/dataApis/dataAliasApis.ts b/packages/nocodb/src/lib/meta/api/dataApis/dataAliasApis.ts index b982bbc4de..3a9add1377 100644 --- a/packages/nocodb/src/lib/meta/api/dataApis/dataAliasApis.ts +++ b/packages/nocodb/src/lib/meta/api/dataApis/dataAliasApis.ts @@ -107,14 +107,20 @@ async function getDataList(model, view: View, req) { listArgs.sortArr = JSON.parse(listArgs.sortArrJson); } catch (e) {} - const data = await nocoExecute( - requestObj, - await baseModel.list(listArgs), - {}, - listArgs - ); - - const count = await baseModel.count(listArgs); + let data = []; + let count = 0; + try { + data = await nocoExecute( + requestObj, + await baseModel.list(listArgs), + {}, + listArgs + ); + count = await baseModel.count(listArgs); + } catch (_) { + // show empty result instead of throwing error here + // e.g. search some text in a numeric field + } return new PagedResponseImpl(data, { ...req.query,