Merge pull request #5721 from nocodb/fix/static-public

fix(nocodb): incorrect public path for docker

packages/nocodb/Dockerfile

@@ -31,9 +31,7 @@ COPY ./package*.json ./
 COPY ./docker/main.js ./docker/main.js
 #COPY ./docker/start.sh /usr/src/appEntry/start.sh
 COPY ./docker/start-litestream.sh /usr/src/appEntry/start.sh
-COPY ./public/css/*.css ./docker/public/css/
+COPY src/public/ ./docker/public/
-COPY ./public/js/*.js ./docker/public/js/
-COPY ./public/favicon.ico ./docker/public/
 
 # install production dependencies,
 # reduce node_module size with modclean & removing sqlite deps,

packages/nocodb/Dockerfile.local

@@ -14,9 +14,7 @@ COPY ./package*.json ./
 COPY ./docker/nc-gui/ ./docker/nc-gui/
 COPY ./docker/main.js ./docker/index.js
 COPY ./docker/start-local.sh /usr/src/appEntry/start.sh
-COPY ./public/css/*.css ./docker/public/css/
+COPY src/public/ ./docker/public/
-COPY ./public/js/*.js ./docker/public/js/
-COPY ./public/favicon.ico ./docker/public/
 
 # install production dependencies,
 # reduce node_module size with modclean & removing sqlite deps,

packages/nocodb/src/Noco.ts

@@ -1,5 +1,6 @@
 import Sentry, { Handlers } from '@sentry/node';
 import { Logger } from '@nestjs/common';
+import path from 'path';
 import { NestFactory } from '@nestjs/core';
 import clear from 'clear';
 import * as express from 'express';
@@ -122,6 +123,7 @@ export default class Noco {
 
     const dashboardPath = process.env.NC_DASHBOARD_URL || '/dashboard';
     server.use(NcToolGui.expressMiddleware(dashboardPath));
+    server.use(express.static(path.join(__dirname, 'public')));
     server.get('/', (_req, res) => res.redirect(dashboardPath));
 
     this.initSentryErrorHandler(server);

packages/nocodb/src/app.module.ts

@@ -5,7 +5,6 @@ import { EventEmitterModule as NestJsEventEmitter } from '@nestjs/event-emitter'
 import { GlobalExceptionFilter } from './filters/global-exception/global-exception.filter';
 import { GlobalMiddleware } from './middlewares/global/global.middleware';
 import { GuiMiddleware } from './middlewares/gui/gui.middleware';
-import { PublicMiddleware } from './middlewares/public/public.middleware';
 import { DatasModule } from './modules/datas/datas.module';
 import { EventEmitterModule } from './modules/event-emitter/event-emitter.module';
 import { AuthService } from './services/auth.service';
@@ -59,8 +58,6 @@ export class AppModule {
     consumer
       .apply(GuiMiddleware)
       .forRoutes({ path: '*', method: RequestMethod.GET })
-      .apply(PublicMiddleware)
-      .forRoutes({ path: '*', method: RequestMethod.GET })
       .apply(GlobalMiddleware)
       .forRoutes({ path: '*', method: RequestMethod.ALL });
   }

packages/nocodb/src/middlewares/public/public.middleware.spec.ts

@@ -1,7 +0,0 @@
-import { PublicMiddleware } from './public.middleware';
-
-describe('PublicMiddleware', () => {
-  it('should be defined', () => {
-    expect(new PublicMiddleware()).toBeDefined();
-  });
-});

packages/nocodb/src/middlewares/public/public.middleware.ts

@@ -1,23 +0,0 @@
-import path, { join } from 'path';
-import { Injectable } from '@nestjs/common';
-import express from 'express';
-import isDocker from 'is-docker';
-import type { NestMiddleware } from '@nestjs/common';
-
-@Injectable()
-export class PublicMiddleware implements NestMiddleware {
-  use(req: any, res: any, next: () => void) {
-    // redirect root to dashboard
-    if (req.path === '/') {
-      const dashboardPath = process.env.NC_DASHBOARD_URL || '/dashboard';
-      return res.redirect(dashboardPath);
-    }
-
-    // serve static files from public folder
-    if (isDocker()) {
-      express.static(join(process.cwd(), 'docker', 'public'))(req, res, next);
-    } else {
-      express.static(join(process.cwd(), 'public'))(req, res, next);
-    }
-  }
-}

packages/nocodb/webpack.config.js

@@ -44,7 +44,7 @@ module.exports = {
   plugins: [
     new webpack.EnvironmentPlugin(['EE']),
     new CopyPlugin({
-      patterns: [{ from: 'public', to: 'public' }],
+      patterns: [{ from: 'src/public', to: 'public' }],
     }),
   ],