From 1e436f6651f571367d648f8025dce95d183fd520 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 13 Sep 2022 11:57:25 +0530 Subject: [PATCH 01/16] chore(cypress): improve menu selection by filtering by unique classname Signed-off-by: Pranav C --- .../components/smartsheet-toolbar/ColumnFilter.vue | 3 +++ scripts/cypress/support/commands.js | 11 +++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue b/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue index 62283b0987..7af198935b 100644 --- a/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue +++ b/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue @@ -158,6 +158,7 @@ defineExpose({ placeholder="Group op" @click.stop @change="saveOrUpdate(filter, i)" + dropdown-class-name="nc-dropdown-filter-logical-op-group" > {{ op.text }} @@ -205,6 +206,7 @@ defineExpose({ :disabled="filter.readOnly" @click.stop @change="filterUpdateCondition(filter, i)" + dropdown-class-name="nc-dropdown-filter-logical-op" > {{ op.text }} @@ -231,6 +233,7 @@ defineExpose({ :disabled="filter.readOnly" hide-details @change="filterUpdateCondition(filter, i)" + dropdown-class-name="nc-dropdown-filter-comp-op" > {{ compOp.text }} diff --git a/scripts/cypress/support/commands.js b/scripts/cypress/support/commands.js index 84020b99a1..10a96a7eeb 100644 --- a/scripts/cypress/support/commands.js +++ b/scripts/cypress/support/commands.js @@ -286,9 +286,9 @@ Cypress.Commands.add('getActiveModal', () => { return cy.get('.ant-modal-content:visible').last(); }); -Cypress.Commands.add('getActiveMenu', (overlayClassName) => { - if (overlayClassName) { - return cy.get(`${overlayClassName} .ant-dropdown-content:visible`); +Cypress.Commands.add('getActiveMenu', (overlaySelector) => { + if (overlaySelector) { + return cy.get(`${overlaySelector} .ant-dropdown-content:visible`); } return cy.get('.ant-dropdown-content:visible').last(); }); @@ -297,7 +297,10 @@ Cypress.Commands.add('getActivePopUp', () => { return cy.get('.ant-menu-submenu-popup:visible').last(); }); -Cypress.Commands.add('getActiveSelection', () => { +Cypress.Commands.add('getActiveSelection', (selector) => { + if(selector) { + return cy.get(`${selector}.ant-select-dropdown:visible`).last(); + } return cy.get('.ant-select-dropdown:visible').last(); }); From 6c8171dd5bebdd2510e6aadccfd3618f2faf83ce Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 13 Sep 2022 12:08:59 +0530 Subject: [PATCH 02/16] chore(cypress): improve drawer selection by filtering by unique classname Signed-off-by: Pranav C --- packages/nc-gui/components/general/HelpAndSupport.vue | 3 ++- .../nc-gui/components/smartsheet/expanded-form/index.vue | 1 + scripts/cypress/integration/common/8a_webhook.js | 8 ++++---- scripts/cypress/support/commands.js | 5 ++++- 4 files changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/nc-gui/components/general/HelpAndSupport.vue b/packages/nc-gui/components/general/HelpAndSupport.vue index d7219a75a2..b01ba278c5 100644 --- a/packages/nc-gui/components/general/HelpAndSupport.vue +++ b/packages/nc-gui/components/general/HelpAndSupport.vue @@ -27,11 +27,12 @@ const openSwaggerLink = () => {
diff --git a/packages/nc-gui/components/smartsheet/expanded-form/index.vue b/packages/nc-gui/components/smartsheet/expanded-form/index.vue index 0f4e69fc0b..39890b9500 100644 --- a/packages/nc-gui/components/smartsheet/expanded-form/index.vue +++ b/packages/nc-gui/components/smartsheet/expanded-form/index.vue @@ -108,6 +108,7 @@ export default { width="min(90vw,1000px)" :body-style="{ 'padding': 0, 'display': 'flex', 'flex-direction': 'column' }" :closable="false" + class="nc-drawer-expanded-form" >
diff --git a/scripts/cypress/integration/common/8a_webhook.js b/scripts/cypress/integration/common/8a_webhook.js index 6192d8f8f5..0533cec803 100644 --- a/scripts/cypress/integration/common/8a_webhook.js +++ b/scripts/cypress/integration/common/8a_webhook.js @@ -161,12 +161,12 @@ function addNewRow(index, cellValue) { cy.get(".nc-add-new-row-btn").click(); cy.wait(1000); cy.get(".nc-expand-col-Title").find(".nc-cell > input").first().type(cellValue); - cy.getActiveDrawer() + cy.getActiveDrawer('.nc-drawer-expanded-form') .find(".ant-btn-primary") .click(); cy.toastWait("updated successfully"); - cy.getActiveDrawer() + cy.getActiveDrawer('.nc-drawer-expanded-form') .find(".ant-btn") .contains("Cancel") .click(); @@ -184,14 +184,14 @@ function updateRow(index, cellValue) { .clear() .type(cellValue); - cy.getActiveDrawer() + cy.getActiveDrawer('.nc-drawer-expanded-form') .find("button") .contains("Save row") .click({ force: true }); // partial toast message cy.toastWait("updated successfully"); - cy.getActiveDrawer() + cy.getActiveDrawer('.nc-drawer-expanded-form') .find("button") .contains("Cancel") .click({ force: true }); diff --git a/scripts/cypress/support/commands.js b/scripts/cypress/support/commands.js index 10a96a7eeb..4696d59c2f 100644 --- a/scripts/cypress/support/commands.js +++ b/scripts/cypress/support/commands.js @@ -304,7 +304,10 @@ Cypress.Commands.add('getActiveSelection', (selector) => { return cy.get('.ant-select-dropdown:visible').last(); }); -Cypress.Commands.add('getActiveDrawer', () => { +Cypress.Commands.add('getActiveDrawer', (selector) => { + if(selector) { + return cy.get(`${selector} .ant-drawer-content:visible`).last(); + } return cy.get('.ant-drawer-content:visible').last(); }); From 043e8d304024cc31517ea31161a05b704103e1c0 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 13 Sep 2022 12:22:39 +0530 Subject: [PATCH 03/16] chore(cypress): improve modal selection by filtering by unique classname Signed-off-by: Pranav C --- packages/nc-gui/components/dlg/TableCreate.vue | 2 +- scripts/cypress/support/commands.js | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/nc-gui/components/dlg/TableCreate.vue b/packages/nc-gui/components/dlg/TableCreate.vue index 5a340074a2..f2c8ebb64c 100644 --- a/packages/nc-gui/components/dlg/TableCreate.vue +++ b/packages/nc-gui/components/dlg/TableCreate.vue @@ -80,7 +80,7 @@ onMounted(() => {