diff --git a/packages/nc-gui/components/smartsheet-column/EditOrAdd.vue b/packages/nc-gui/components/smartsheet-column/EditOrAdd.vue index 7fb911f3fe..f9cd0dfa46 100644 --- a/packages/nc-gui/components/smartsheet-column/EditOrAdd.vue +++ b/packages/nc-gui/components/smartsheet-column/EditOrAdd.vue @@ -53,7 +53,9 @@ const reloadMetaAndData = async () => { } async function onSubmit() { - await addOrUpdate(reloadMetaAndData) + const saved = await addOrUpdate(reloadMetaAndData) + + if (!saved) return // add delay to complete the minimize transition setTimeout(() => { diff --git a/packages/nc-gui/components/smartsheet-column/FormulaOptions.vue b/packages/nc-gui/components/smartsheet-column/FormulaOptions.vue index 0e06220b66..f0858875bd 100644 --- a/packages/nc-gui/components/smartsheet-column/FormulaOptions.vue +++ b/packages/nc-gui/components/smartsheet-column/FormulaOptions.vue @@ -50,6 +50,7 @@ const validators = { { validator: (_: any, formula: any) => { return new Promise((resolve, reject) => { + if (!formula?.trim()) return reject(new Error('Required')) const res = parseAndValidateFormula(formula) if (res !== true) { return reject(new Error(res)) diff --git a/packages/nc-gui/components/smartsheet-column/SelectOptions.vue b/packages/nc-gui/components/smartsheet-column/SelectOptions.vue index 15e54cc04a..40a52cc1f2 100644 --- a/packages/nc-gui/components/smartsheet-column/SelectOptions.vue +++ b/packages/nc-gui/components/smartsheet-column/SelectOptions.vue @@ -15,7 +15,7 @@ const props = defineProps() const emit = defineEmits(['update:value']) const vModel = useVModel(props, 'value', emit) -const { setAdditionalValidations } = useColumnCreateStoreOrThrow() +const { setAdditionalValidations, validateInfos } = useColumnCreateStoreOrThrow() let options = $ref([]) const colorMenus = $ref({}) @@ -103,13 +103,20 @@ watch(inputs, () => { + diff --git a/packages/nc-gui/components/smartsheet-header/Menu.vue b/packages/nc-gui/components/smartsheet-header/Menu.vue index f0e3778ad7..5522edf2a0 100644 --- a/packages/nc-gui/components/smartsheet-header/Menu.vue +++ b/packages/nc-gui/components/smartsheet-header/Menu.vue @@ -1,5 +1,7 @@