From 9376fd2c5466e05f911854b5cc60091abcd77e33 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Wed, 10 Jan 2024 09:05:30 +0000
Subject: [PATCH] fix: ui warning corrections

---
 packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue  | 4 ++--
 packages/nc-gui/components/smartsheet/toolbar/FilterInput.vue | 3 ++-
 packages/nc-gui/components/workspace/CollaboratorsList.vue    | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
index 2754c988c7..0316dd1c2e 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
@@ -387,7 +387,7 @@ useMenuCloseOnEsc(open)
                       <template #default>{{ field.title }}</template>
                     </NcTooltip>
 
-                    <NcSwitch v-e="['a:fields:show-hide']" :checked="field.show" :disabled="field.isViewEssentialField" />
+                    <NcSwitch :checked="field.show" :disabled="field.isViewEssentialField" @change="$t('a:fields:show-hide')" />
                   </div>
 
                   <div class="flex-1" />
@@ -411,7 +411,7 @@ useMenuCloseOnEsc(open)
                     <template #default>{{ filteredFieldList[0].title }}</template>
                   </NcTooltip>
 
-                  <NcSwitch v-e="['a:fields:show-hide']" :checked="true" :disabled="true" />
+                  <NcSwitch :checked="true" :disabled="true" />
                 </div>
               </template>
             </Draggable>
diff --git a/packages/nc-gui/components/smartsheet/toolbar/FilterInput.vue b/packages/nc-gui/components/smartsheet/toolbar/FilterInput.vue
index e48e4aa054..10855e454d 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/FilterInput.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/FilterInput.vue
@@ -47,7 +47,8 @@ import Text from '~/components/cell/Text.vue'
 import User from '~/components/cell/User.vue'
 
 interface Props {
-  column: ColumnType
+  // column could be possibly undefined when the filter is created
+  column?: ColumnType
   filter: Filter
 }
 
diff --git a/packages/nc-gui/components/workspace/CollaboratorsList.vue b/packages/nc-gui/components/workspace/CollaboratorsList.vue
index fcc4a781fc..5492ec69b2 100644
--- a/packages/nc-gui/components/workspace/CollaboratorsList.vue
+++ b/packages/nc-gui/components/workspace/CollaboratorsList.vue
@@ -67,7 +67,7 @@ onMounted(async () => {
     </div>
     <WorkspaceInviteSection v-if="workspaceRole !== WorkspaceUserRoles.VIEWER" />
     <div v-if="!filterCollaborators?.length" class="w-full h-full flex flex-col items-center justify-center mt-36">
-      <Empty description="No members found" />
+      <a-empty description="No members found" />
     </div>
     <div v-else class="nc-collaborators-list mt-6 h-full">
       <div class="flex flex-col rounded-lg overflow-hidden border-1 max-w-350 max-h-[calc(100%-8rem)]">