From 92b8f6874305abce2a3af11d0c6fcad9429f8a8d Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Tue, 12 Nov 2024 06:06:47 +0000
Subject: [PATCH] fix: permission bugs

---
 packages/nc-gui/components/dlg/ReAssign/UserItem.vue |  2 --
 packages/nc-gui/components/dlg/ReAssign/index.vue    | 12 +-----------
 packages/nc-gui/lib/acl.ts                           |  1 -
 3 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/packages/nc-gui/components/dlg/ReAssign/UserItem.vue b/packages/nc-gui/components/dlg/ReAssign/UserItem.vue
index f65fc9680f..b2cf4838a8 100644
--- a/packages/nc-gui/components/dlg/ReAssign/UserItem.vue
+++ b/packages/nc-gui/components/dlg/ReAssign/UserItem.vue
@@ -19,8 +19,6 @@ const displayName = computed(() => {
       class="!text-[0.65rem]"
     />
     <div class="flex flex-col justify-center flex-grow">
-      <div class="flex" :style="{ fontWeight: 500 }">{{ user.display_name }}</div>
-
       <div class="flex flex-col">
         <span class="capitalize font-weight-medium">{{ displayName }}</span>
         <span class="text-xs">{{ user.email }}</span>
diff --git a/packages/nc-gui/components/dlg/ReAssign/index.vue b/packages/nc-gui/components/dlg/ReAssign/index.vue
index 2eabc3bd65..e8b162b4d9 100644
--- a/packages/nc-gui/components/dlg/ReAssign/index.vue
+++ b/packages/nc-gui/components/dlg/ReAssign/index.vue
@@ -78,7 +78,7 @@ const currentOwner = computed(() => {
   return (
     (props.view && basesUser.value.get(props.view.base_id)?.find((u) => u.id === props.view.owned_by)) || {
       id: props.view.owned_by,
-      display_name: 'Unknown',
+      display_name: 'Unknown User',
     }
   )
 })
@@ -112,16 +112,6 @@ const assignView = async () => {
 
     // if personal view then redirect to default view and reload view list
     if (props.view.lock_type === ViewLockType.Personal) {
-      // navigate to default view
-      navigateToView({
-        view: viewsStore.views.find((v) => v.is_default),
-        tableId: props.view.fk_model_id,
-        baseId: props.view.base_id!,
-        force: true,
-      }).catch(() => {
-        // ignore
-      })
-
       // then reload the view list
       viewsStore
         .loadViews({
diff --git a/packages/nc-gui/lib/acl.ts b/packages/nc-gui/lib/acl.ts
index 7884b26b9c..1350157571 100644
--- a/packages/nc-gui/lib/acl.ts
+++ b/packages/nc-gui/lib/acl.ts
@@ -88,7 +88,6 @@ const rolePermissions = {
       baseDuplicate: true,
       sourceCreate: true,
       baseAuditList: true,
-      reAssignViewOwner: true,
     },
   },
   [ProjectRoles.EDITOR]: {