Browse Source

Nc chore/slow dev (#8616)

* chore: disable devtools to avoid slow dev setup

* fix: make baseId optional since it will pick the active base if missing

* fix: wrap menuItem with a div to support using directive

* fix: bind attributes to menu-item component

* fix: avoid inheriting attributes on root elements

---------

Co-authored-by: Pranav C <pranavxc@gmail.com>
pull/8628/head
Ramesh Mane 6 months ago committed by GitHub
parent
commit
923d14aa27
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 10
      packages/nc-gui/components/nc/MenuItem.vue
  2. 2
      packages/nc-gui/components/project/View.vue
  3. 3
      packages/nc-gui/nuxt.config.ts

10
packages/nc-gui/components/nc/MenuItem.vue

@ -1,9 +1,17 @@
<script>
export default {
inheritAttrs: false,
}
</script>
<template> <template>
<a-menu-item class="nc-menu-item"> <div class="w-full">
<a-menu-item v-bind="$attrs" class="nc-menu-item">
<div class="nc-menu-item-inner"> <div class="nc-menu-item-inner">
<slot /> <slot />
</div> </div>
</a-menu-item> </a-menu-item>
</div>
</template> </template>
<style lang="scss"> <style lang="scss">

2
packages/nc-gui/components/project/View.vue

@ -3,7 +3,7 @@ import { useTitle } from '@vueuse/core'
import NcLayout from '~icons/nc-icons/layout' import NcLayout from '~icons/nc-icons/layout'
const props = defineProps<{ const props = defineProps<{
baseId: string baseId?: string
}>() }>()
const basesStore = useBases() const basesStore = useBases()

3
packages/nc-gui/nuxt.config.ts

@ -121,6 +121,9 @@ export default defineNuxtConfig({
build: {}, build: {},
// disabling devtools since causing some significant performance issues when browser console open in development mode
devtools: { enabled: false },
vite: { vite: {
worker: { worker: {
format: 'es', format: 'es',

Loading…
Cancel
Save