From 83d20e70cb343a3c191b7be8ddc610f3d98265e4 Mon Sep 17 00:00:00 2001 From: mertmit Date: Fri, 17 Feb 2023 10:09:02 +0300 Subject: [PATCH 01/25] fix: sql client type calls Signed-off-by: mertmit --- packages/nocodb/src/lib/meta/api/tableApis.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/nocodb/src/lib/meta/api/tableApis.ts b/packages/nocodb/src/lib/meta/api/tableApis.ts index 8eb3d6a10e..8e02d5aca8 100644 --- a/packages/nocodb/src/lib/meta/api/tableApis.ts +++ b/packages/nocodb/src/lib/meta/api/tableApis.ts @@ -151,7 +151,7 @@ export async function tableCreate(req: Request, res) { const sqlClient = await NcConnectionMgrv2.getSqlClient(base); let tableNameLengthLimit = 255; - const sqlClientType = sqlClient.clientType; + const sqlClientType = sqlClient.knex.clientType(); if (sqlClientType === 'mysql2' || sqlClientType === 'mysql') { tableNameLengthLimit = 64; } else if (sqlClientType === 'pg') { @@ -298,7 +298,7 @@ export async function tableUpdate(req: Request, res) { const sqlClient = await NcConnectionMgrv2.getSqlClient(base); let tableNameLengthLimit = 255; - const sqlClientType = sqlClient.clientType; + const sqlClientType = sqlClient.knex.clientType(); if (sqlClientType === 'mysql2' || sqlClientType === 'mysql') { tableNameLengthLimit = 64; } else if (sqlClientType === 'pg') { From ad0832ec15ae7f6c3c94baa06425b5b7302a99f3 Mon Sep 17 00:00:00 2001 From: mertmit Date: Fri, 17 Feb 2023 11:02:04 +0300 Subject: [PATCH 02/25] fix: ts types for sql clients Signed-off-by: mertmit --- .../src/lib/db/sql-client/lib/oracle/OracleClient.ts | 2 +- packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts | 10 +++++++++- packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2.ts | 2 +- packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2Trans.ts | 2 +- .../src/lib/db/sql-migrator/lib/KnexMigratorv2.ts | 7 ++++--- .../src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts | 9 ++++++++- packages/nocodb/src/lib/meta/NcMetaMgr.ts | 2 +- packages/nocodb/src/lib/utils/common/BaseApiBuilder.ts | 2 +- .../nocodb/src/lib/utils/common/NcConnectionMgr.ts | 2 +- .../nocodb/src/lib/utils/common/NcConnectionMgrv2.ts | 2 +- 10 files changed, 28 insertions(+), 12 deletions(-) diff --git a/packages/nocodb/src/lib/db/sql-client/lib/oracle/OracleClient.ts b/packages/nocodb/src/lib/db/sql-client/lib/oracle/OracleClient.ts index 34779ebbe8..4f01353ba0 100644 --- a/packages/nocodb/src/lib/db/sql-client/lib/oracle/OracleClient.ts +++ b/packages/nocodb/src/lib/db/sql-client/lib/oracle/OracleClient.ts @@ -1913,7 +1913,7 @@ class OracleClient extends KnexClient { * @returns {Number} code * @returns {String} message */ - async totalRecords(_args: any = {}) { + async totalRecords(_args: any = {}): Promise { // @ts-ignore const func = this.totalRecords.name; throw new Error('Function not supported for oracle yet'); diff --git a/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts b/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts index 9bbd2fa238..02b5c4e343 100644 --- a/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts +++ b/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts @@ -17,6 +17,14 @@ import NcConnectionMgr from '../../utils/common/NcConnectionMgr'; import { customAlphabet } from 'nanoid'; import Debug from '../util/Debug'; import Result from '../util/Result'; + +import type MssqlClient from '../sql-client/lib/mssql/MssqlClient'; +import type MysqlClient from '../sql-client/lib/mysql/MysqlClient'; +import type OracleClient from '../sql-client/lib/oracle/OracleClient'; +import type PGClient from '../sql-client/lib/pg/PgClient'; +import type SnowflakeClient from '../sql-client/lib/snowflake/SnowflakeClient'; +import type SqliteClient from '../sql-client/lib/sqlite/SqliteClient'; + const randomID = customAlphabet('1234567890abcdefghijklmnopqrstuvwxyz_', 20); const log = new Debug('SqlMgr'); @@ -337,7 +345,7 @@ export default class SqlMgr { * @returns * @memberof SqlMgr */ - public async projectGetSqlClient(args) { + public async projectGetSqlClient(args): Promise { const func = this.projectGetSqlClient.name; log.api(`${func}:args:`, args); diff --git a/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2.ts b/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2.ts index 89ee530036..8c7d189461 100644 --- a/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2.ts +++ b/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2.ts @@ -118,7 +118,7 @@ export default class SqlMgrv2 { return sqlMigrationStatements; } - protected async getSqlClient(base: Base): Promise { + protected async getSqlClient(base: Base) { return NcConnectionMgrv2.getSqlClient(base); } } diff --git a/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2Trans.ts b/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2Trans.ts index a5def5c184..82852fed52 100644 --- a/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2Trans.ts +++ b/packages/nocodb/src/lib/db/sql-mgr/v2/SqlMgrv2Trans.ts @@ -52,7 +52,7 @@ export default class SqlMgrv2Trans extends SqlMgrv2 { } } - protected async getSqlClient(base: Base): Promise { + protected async getSqlClient(base: Base) { return NcConnectionMgrv2.getSqlClient(base, this.trx); } diff --git a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts index cc1ad02a34..cdf4d8f1f1 100644 --- a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts +++ b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts @@ -1,6 +1,7 @@ import fs from 'fs'; import path from 'path'; import { promisify } from 'util'; +import { Knex } from 'knex'; import glob from 'glob'; import SqlClientFactory from '../../sql-client/lib/SqlClientFactory'; @@ -428,7 +429,7 @@ export default class KnexMigratorv2 { // } } - protected async getSqlClient(base: Base): Promise { + protected async getSqlClient(base: Base) { return NcConnectionMgrv2.getSqlClient(base); } @@ -753,7 +754,7 @@ export default class KnexMigratorv2 { const vm = this; const trx = sqlClient.knex.isTransaction - ? sqlClient.knex + ? sqlClient.knex as Knex.Transaction : await sqlClient.knex.transaction(); try { for (const query of upStatements) { @@ -920,7 +921,7 @@ export default class KnexMigratorv2 { const vm = this; const trx = sqlClient.knex.isTransaction - ? sqlClient.knex + ? sqlClient.knex as Knex.Transaction : await sqlClient.knex.transaction(); try { for (const query of downStatements) { diff --git a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts index 7bfe6a2bdc..037cf6d559 100644 --- a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts +++ b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts @@ -11,6 +11,13 @@ import Noco from '../../../Noco'; import { XKnex } from '../../sql-data-mapper'; import NcMetaIO from '../../../meta/NcMetaIO'; +import type MssqlClient from '../../sql-client/lib/mssql/MssqlClient'; +import type MysqlClient from '../../sql-client/lib/mysql/MysqlClient'; +import type OracleClient from '../../sql-client/lib/oracle/OracleClient'; +import type PGClient from '../../sql-client/lib/pg/PgClient'; +import type SnowflakeClient from '../../sql-client/lib/snowflake/SnowflakeClient'; +import type SqliteClient from '../../sql-client/lib/sqlite/SqliteClient'; + export default class KnexMigratorv2Tans extends KnexMigratorv2 { protected sqlClient: any; protected ncMeta: NcMetaIO; @@ -24,7 +31,7 @@ export default class KnexMigratorv2Tans extends KnexMigratorv2 { protected get metaDb(): XKnex { return this.ncMeta.knex || Noco.ncMeta.knex; } - protected async getSqlClient(base: Base): Promise { + protected async getSqlClient(base: Base): Promise { return this.sqlClient || NcConnectionMgrv2.getSqlClient(base); } } diff --git a/packages/nocodb/src/lib/meta/NcMetaMgr.ts b/packages/nocodb/src/lib/meta/NcMetaMgr.ts index 02b2d7b607..aecaff7189 100644 --- a/packages/nocodb/src/lib/meta/NcMetaMgr.ts +++ b/packages/nocodb/src/lib/meta/NcMetaMgr.ts @@ -2909,7 +2909,7 @@ export default class NcMetaMgr { } } - protected async projectGetSqlClient(args): Promise { + protected async projectGetSqlClient(args) { const builder = this.getBuilder(args); return builder?.getSqlClient(); } diff --git a/packages/nocodb/src/lib/utils/common/BaseApiBuilder.ts b/packages/nocodb/src/lib/utils/common/BaseApiBuilder.ts index 210eb61a32..69294bdfc3 100644 --- a/packages/nocodb/src/lib/utils/common/BaseApiBuilder.ts +++ b/packages/nocodb/src/lib/utils/common/BaseApiBuilder.ts @@ -187,7 +187,7 @@ export default abstract class BaseApiBuilder return this.connectionConfig?.meta?.dbAlias; } - public async getSqlClient(): Promise { + public async getSqlClient() { return NcConnectionMgr.getSqlClient({ dbAlias: this.dbAlias, env: this.config.env, diff --git a/packages/nocodb/src/lib/utils/common/NcConnectionMgr.ts b/packages/nocodb/src/lib/utils/common/NcConnectionMgr.ts index 9c9c4c55a0..ca7f4fe53d 100644 --- a/packages/nocodb/src/lib/utils/common/NcConnectionMgr.ts +++ b/packages/nocodb/src/lib/utils/common/NcConnectionMgr.ts @@ -149,7 +149,7 @@ export default class NcConnectionMgr { env: string; config: NcConfig; projectId: string; - }): Promise { + }) { const knex = this.get({ dbAlias, env, diff --git a/packages/nocodb/src/lib/utils/common/NcConnectionMgrv2.ts b/packages/nocodb/src/lib/utils/common/NcConnectionMgrv2.ts index 06386e3391..bb55673cf6 100644 --- a/packages/nocodb/src/lib/utils/common/NcConnectionMgrv2.ts +++ b/packages/nocodb/src/lib/utils/common/NcConnectionMgrv2.ts @@ -149,7 +149,7 @@ export default class NcConnectionMgrv2 { // return config?.envs?.[env]?.db?.find(db => db?.meta?.dbAlias === dbAlias); // } - public static async getSqlClient(base: Base, _knex = null): Promise { + public static async getSqlClient(base: Base, _knex = null) { const knex = _knex || this.get(base); return SqlClientFactory.create({ knex, From cf974fd6c82e39df68e5b7b244d08b9fdd2a9ade Mon Sep 17 00:00:00 2001 From: Pranav C Date: Sat, 18 Feb 2023 15:22:54 +0530 Subject: [PATCH 03/25] feat(gui): Avoid closing the LTAR model if the element is added by holding ALT/OPT key Signed-off-by: Pranav C --- .../virtual-cell/components/ListItems.vue | 31 +++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/packages/nc-gui/components/virtual-cell/components/ListItems.vue b/packages/nc-gui/components/virtual-cell/components/ListItems.vue index 711030c443..b779171289 100644 --- a/packages/nc-gui/components/virtual-cell/components/ListItems.vue +++ b/packages/nc-gui/components/virtual-cell/components/ListItems.vue @@ -48,14 +48,20 @@ const saveRow = inject(SaveRowInj, () => {}) const selectedRowIndex = ref(0) +const isAltKeyDown = ref(false) + const linkRow = async (row: Record) => { if (isNew.value) { addLTARRef(row, column?.value as ColumnType) - saveRow() + saveRow!() } else { await link(row) } - vModel.value = false + if (isAltKeyDown.value) { + loadChildrenExcludedList() + } else { + vModel.value = false + } } /** reload list on modal open */ @@ -159,6 +165,27 @@ useSelectedCellKeyupListener(vModel, (e: KeyboardEvent) => { const activeRow = (vNode?: InstanceType) => { vNode?.$el?.scrollIntoView({ block: 'nearest', inline: 'nearest' }) } + +// set variable to true when alt key is pressed +const keyDownHandler = (e: KeyboardEvent) => { + isAltKeyDown.value = e.altKey +} + +// set variable to false when key is released +const keyUpHandler = (e: KeyboardEvent) => { + isAltKeyDown.value = e.altKey +} + +// add event listeners when vModel is true and remove when false +watch(vModel, (nextVal) => { + if (nextVal) { + document.addEventListener('keydown', keyDownHandler) + document.addEventListener('keyup', keyUpHandler) + } else { + document.removeEventListener('keydown', keyDownHandler) + document.removeEventListener('keyup', keyUpHandler) + } +}) + From 746398bb7e2dffdd97b2f2cebf11b2356b0a57e8 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Mon, 20 Feb 2023 21:13:04 +0800 Subject: [PATCH 18/25] fix(nocodb): add missing id --- packages/nocodb/src/lib/models/SelectOption.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/nocodb/src/lib/models/SelectOption.ts b/packages/nocodb/src/lib/models/SelectOption.ts index baf25e2672..fa24d06e50 100644 --- a/packages/nocodb/src/lib/models/SelectOption.ts +++ b/packages/nocodb/src/lib/models/SelectOption.ts @@ -17,12 +17,8 @@ export default class SelectOption { data: Partial, ncMeta = Noco.ncMeta ) { - // title: string; - // fk_column_id: string; - // color: string; - // order: number; - const insertObj = extractProps(data, [ + 'id', 'title', 'fk_column_id', 'color', From 2bee197f29c1396ec56c965541839575fbe3cd1c Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Mon, 20 Feb 2023 22:13:26 +0800 Subject: [PATCH 19/25] fix(nocodb): apply !!insertObj.mm even undefined --- packages/nocodb/src/lib/models/Model.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/nocodb/src/lib/models/Model.ts b/packages/nocodb/src/lib/models/Model.ts index 4e937d14b6..2412d6259d 100644 --- a/packages/nocodb/src/lib/models/Model.ts +++ b/packages/nocodb/src/lib/models/Model.ts @@ -114,9 +114,7 @@ export default class Model implements TableType { 'id', ]); - if (insertObj.mm) { - insertObj.mm = !!insertObj.mm; - } + insertObj.mm = !!insertObj.mm; if (!insertObj.order) { insertObj.order = await ncMeta.metaGetNextOrder( From 0141c5024ed632929692d6187cfa4114031a66c4 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Mon, 20 Feb 2023 23:42:20 +0800 Subject: [PATCH 20/25] fix(nocodb): add missing meta in extractProps --- packages/nocodb/src/lib/models/FormView.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/nocodb/src/lib/models/FormView.ts b/packages/nocodb/src/lib/models/FormView.ts index 5f10ce1803..ad155f4434 100644 --- a/packages/nocodb/src/lib/models/FormView.ts +++ b/packages/nocodb/src/lib/models/FormView.ts @@ -68,6 +68,7 @@ export default class FormView implements FormType { 'logo_url', 'submit_another_form', 'show_blank_form', + 'meta', ]); if (insertObj.meta) { insertObj.meta = serializeJSON(insertObj.meta); @@ -103,6 +104,7 @@ export default class FormView implements FormType { 'show_blank_form', 'meta', ]); + if (o) { o = { ...o, ...updateObj }; // set cache From 360631e2aab2064b94c33b6e0f2bbb1e4ddd1f9f Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Mon, 20 Feb 2023 23:45:28 +0800 Subject: [PATCH 21/25] refactor(nocodb): stringify if input is object --- packages/nocodb/src/lib/models/KanbanView.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/nocodb/src/lib/models/KanbanView.ts b/packages/nocodb/src/lib/models/KanbanView.ts index d72a1b46f8..6ac1b65d09 100644 --- a/packages/nocodb/src/lib/models/KanbanView.ts +++ b/packages/nocodb/src/lib/models/KanbanView.ts @@ -108,11 +108,8 @@ export default class KanbanView implements KanbanType { 'meta', ]); - if (updateObj.meta) { - updateObj.meta = - typeof updateObj.meta === 'string' - ? updateObj.meta - : JSON.stringify(updateObj.meta ?? {}); + if (updateObj.meta && typeof updateObj.meta === 'object') { + updateObj.meta = JSON.stringify(updateObj.meta ?? {}); } if (o) { From fc4ac7a157b02ed526c7776e216dc6bbdf524bf5 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Mon, 20 Feb 2023 23:46:53 +0800 Subject: [PATCH 22/25] fix(nocodb): add missing type props --- packages/nocodb/src/lib/models/Model.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/nocodb/src/lib/models/Model.ts b/packages/nocodb/src/lib/models/Model.ts index 2412d6259d..43b5c7a77f 100644 --- a/packages/nocodb/src/lib/models/Model.ts +++ b/packages/nocodb/src/lib/models/Model.ts @@ -109,6 +109,7 @@ export default class Model implements TableType { 'title', 'mm', 'order', + 'type', 'created_at', 'updated_at', 'id', From 9c6d2af45a71d43f142386607bfa12d66b3a6a24 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Tue, 21 Feb 2023 11:31:27 +0530 Subject: [PATCH 23/25] chore: lint Signed-off-by: Pranav C --- .../components/virtual-cell/components/ListItems.vue | 1 - packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts | 11 ++++++++++- .../src/lib/db/sql-migrator/lib/KnexMigratorv2.ts | 6 +++--- .../src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts | 11 ++++++++++- .../nocodb/src/lib/meta/api/helpers/populateMeta.ts | 2 +- .../src/lib/meta/helpers/mapDefaultDisplayValue.ts | 8 ++++---- .../lib/version-upgrader/ncStickyColumnUpgrader.ts | 10 +++++----- 7 files changed, 33 insertions(+), 16 deletions(-) diff --git a/packages/nc-gui/components/virtual-cell/components/ListItems.vue b/packages/nc-gui/components/virtual-cell/components/ListItems.vue index 6122bf9357..2df6f5702d 100644 --- a/packages/nc-gui/components/virtual-cell/components/ListItems.vue +++ b/packages/nc-gui/components/virtual-cell/components/ListItems.vue @@ -252,7 +252,6 @@ watch(vModel, (nextVal) => { - diff --git a/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts b/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts index 02b5c4e343..3f6a85b9c2 100644 --- a/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts +++ b/packages/nocodb/src/lib/db/sql-mgr/SqlMgr.ts @@ -345,7 +345,16 @@ export default class SqlMgr { * @returns * @memberof SqlMgr */ - public async projectGetSqlClient(args): Promise { + public async projectGetSqlClient( + args + ): Promise< + | SnowflakeClient + | MysqlClient + | SqliteClient + | MssqlClient + | OracleClient + | PGClient + > { const func = this.projectGetSqlClient.name; log.api(`${func}:args:`, args); diff --git a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts index cdf4d8f1f1..d32a40d1d0 100644 --- a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts +++ b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2.ts @@ -1,7 +1,7 @@ import fs from 'fs'; import path from 'path'; import { promisify } from 'util'; -import { Knex } from 'knex'; +import { Knex } from 'knex'; import glob from 'glob'; import SqlClientFactory from '../../sql-client/lib/SqlClientFactory'; @@ -754,7 +754,7 @@ export default class KnexMigratorv2 { const vm = this; const trx = sqlClient.knex.isTransaction - ? sqlClient.knex as Knex.Transaction + ? (sqlClient.knex as Knex.Transaction) : await sqlClient.knex.transaction(); try { for (const query of upStatements) { @@ -921,7 +921,7 @@ export default class KnexMigratorv2 { const vm = this; const trx = sqlClient.knex.isTransaction - ? sqlClient.knex as Knex.Transaction + ? (sqlClient.knex as Knex.Transaction) : await sqlClient.knex.transaction(); try { for (const query of downStatements) { diff --git a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts index 037cf6d559..87204964a0 100644 --- a/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts +++ b/packages/nocodb/src/lib/db/sql-migrator/lib/KnexMigratorv2Tans.ts @@ -31,7 +31,16 @@ export default class KnexMigratorv2Tans extends KnexMigratorv2 { protected get metaDb(): XKnex { return this.ncMeta.knex || Noco.ncMeta.knex; } - protected async getSqlClient(base: Base): Promise { + protected async getSqlClient( + base: Base + ): Promise< + | SnowflakeClient + | MysqlClient + | SqliteClient + | MssqlClient + | OracleClient + | PGClient + > { return this.sqlClient || NcConnectionMgrv2.getSqlClient(base); } } diff --git a/packages/nocodb/src/lib/meta/api/helpers/populateMeta.ts b/packages/nocodb/src/lib/meta/api/helpers/populateMeta.ts index 4fe72f70ac..ffe246a131 100644 --- a/packages/nocodb/src/lib/meta/api/helpers/populateMeta.ts +++ b/packages/nocodb/src/lib/meta/api/helpers/populateMeta.ts @@ -228,7 +228,7 @@ export async function populateMeta(base: Base, project: Project): Promise { return async () => { const columns = (await sqlClient.columnList({ tn: table.table_name })) ?.data?.list; - + mapDefaultDisplayValue(columns); /* create nc_models and its rows if it doesn't exists */ diff --git a/packages/nocodb/src/lib/meta/helpers/mapDefaultDisplayValue.ts b/packages/nocodb/src/lib/meta/helpers/mapDefaultDisplayValue.ts index 3fe911f447..a661f21818 100644 --- a/packages/nocodb/src/lib/meta/helpers/mapDefaultDisplayValue.ts +++ b/packages/nocodb/src/lib/meta/helpers/mapDefaultDisplayValue.ts @@ -4,7 +4,7 @@ export default function mapDefaultDisplayValue( columnsArr: Array ): void | T { if (!columnsArr.some((column) => column.pv)) { - const pkIndex = columnsArr.findIndex((column) => column.pk) + const pkIndex = columnsArr.findIndex((column) => column.pk); // if PK is at the end of table if (pkIndex === columnsArr.length - 1) { @@ -15,11 +15,11 @@ export default function mapDefaultDisplayValue( columnsArr[0].pv = true; return columnsArr[0]; } - // pk is not at the end of table - } else if (pkIndex > -1) { + // pk is not at the end of table + } else if (pkIndex > -1) { columnsArr[pkIndex + 1].pv = true; return columnsArr[pkIndex + 1]; - // no pk at all + // no pk at all } else { if (columnsArr.length > 0) { columnsArr[0].pv = true; diff --git a/packages/nocodb/src/lib/version-upgrader/ncStickyColumnUpgrader.ts b/packages/nocodb/src/lib/version-upgrader/ncStickyColumnUpgrader.ts index 0a6e16c21e..1fa222cd17 100644 --- a/packages/nocodb/src/lib/version-upgrader/ncStickyColumnUpgrader.ts +++ b/packages/nocodb/src/lib/version-upgrader/ncStickyColumnUpgrader.ts @@ -40,8 +40,8 @@ export default async function ({ ncMeta }: NcUpgraderCtx) { // if no display value column is set if (!view_columns_meta.some((column) => column.pv)) { - const pkIndex = view_columns_meta.findIndex((column) => column.pk) - + const pkIndex = view_columns_meta.findIndex((column) => column.pk); + // if PK is at the end of table if (pkIndex === view_columns_meta.length - 1) { if (pkIndex > 0) { @@ -61,8 +61,8 @@ export default async function ({ ncMeta }: NcUpgraderCtx) { view_columns_meta[0].id ); } - // pk is not at the end of table - } else if (pkIndex > -1) { + // pk is not at the end of table + } else if (pkIndex > -1) { await ncMeta.metaUpdate( null, null, @@ -70,7 +70,7 @@ export default async function ({ ncMeta }: NcUpgraderCtx) { { pv: true }, view_columns_meta[pkIndex + 1].id ); - // no pk at all + // no pk at all } else if (view_columns_meta.length > 0) { await ncMeta.metaUpdate( null, From ffcb5841664b464a80dcd81dc52d9e2173b374f3 Mon Sep 17 00:00:00 2001 From: pranavxc Date: Tue, 21 Feb 2023 06:48:35 +0000 Subject: [PATCH 24/25] [create-pull-request] automated change Signed-off-by: GitHub --- packages/nc-gui/package-lock.json | 54 +++++++++++++++++++------------ packages/nc-gui/package.json | 2 +- packages/nc-lib-gui/package.json | 2 +- packages/nocodb-sdk/package.json | 2 +- packages/nocodb/package-lock.json | 50 +++++++++++++--------------- packages/nocodb/package.json | 8 ++--- 6 files changed, 63 insertions(+), 55 deletions(-) diff --git a/packages/nc-gui/package-lock.json b/packages/nc-gui/package-lock.json index 760ec39993..e52054f981 100644 --- a/packages/nc-gui/package-lock.json +++ b/packages/nc-gui/package-lock.json @@ -29,7 +29,7 @@ "jwt-decode": "^3.1.2", "locale-codes": "^1.3.1", "monaco-editor": "^0.33.0", - "nocodb-sdk": "file:../nocodb-sdk", + "nocodb-sdk": "0.105.3", "papaparse": "^5.3.2", "qrcode": "^1.5.1", "socket.io-client": "^4.5.1", @@ -97,7 +97,8 @@ } }, "../nocodb-sdk": { - "version": "0.105.2", + "version": "0.105.3", + "extraneous": true, "license": "AGPL-3.0-or-later", "dependencies": { "axios": "^0.21.1", @@ -8554,7 +8555,6 @@ "version": "1.15.1", "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.1.tgz", "integrity": "sha512-yLAMQs+k0b2m7cVxpS1VKJVvoz7SS9Td1zss3XRwXj+ZDH00RJgnuLx7E44wx02kQLrdM3aOOy+FpzS7+8OizA==", - "devOptional": true, "funding": [ { "type": "individual", @@ -11970,8 +11970,21 @@ } }, "node_modules/nocodb-sdk": { - "resolved": "../nocodb-sdk", - "link": true + "version": "0.105.3", + "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", + "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", + "dependencies": { + "axios": "^0.21.1", + "jsep": "^1.3.6" + } + }, + "node_modules/nocodb-sdk/node_modules/axios": { + "version": "0.21.4", + "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz", + "integrity": "sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==", + "dependencies": { + "follow-redirects": "^1.14.0" + } }, "node_modules/node-abi": { "version": "3.23.0", @@ -23962,8 +23975,7 @@ "follow-redirects": { "version": "1.15.1", "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.1.tgz", - "integrity": "sha512-yLAMQs+k0b2m7cVxpS1VKJVvoz7SS9Td1zss3XRwXj+ZDH00RJgnuLx7E44wx02kQLrdM3aOOy+FpzS7+8OizA==", - "devOptional": true + "integrity": "sha512-yLAMQs+k0b2m7cVxpS1VKJVvoz7SS9Td1zss3XRwXj+ZDH00RJgnuLx7E44wx02kQLrdM3aOOy+FpzS7+8OizA==" }, "form-data": { "version": "4.0.0", @@ -26436,22 +26448,22 @@ } }, "nocodb-sdk": { - "version": "file:../nocodb-sdk", + "version": "0.105.3", + "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", + "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", "requires": { - "@typescript-eslint/eslint-plugin": "^4.0.1", - "@typescript-eslint/parser": "^4.0.1", "axios": "^0.21.1", - "cspell": "^4.1.0", - "eslint": "^7.8.0", - "eslint-config-prettier": "^6.11.0", - "eslint-plugin-eslint-comments": "^3.2.0", - "eslint-plugin-functional": "^3.0.2", - "eslint-plugin-import": "^2.22.0", - "eslint-plugin-prettier": "^4.0.0", - "jsep": "^1.3.6", - "npm-run-all": "^4.1.5", - "prettier": "^2.1.1", - "typescript": "^4.0.2" + "jsep": "^1.3.6" + }, + "dependencies": { + "axios": { + "version": "0.21.4", + "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz", + "integrity": "sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==", + "requires": { + "follow-redirects": "^1.14.0" + } + } } }, "node-abi": { diff --git a/packages/nc-gui/package.json b/packages/nc-gui/package.json index b37773df3f..eab13cc396 100644 --- a/packages/nc-gui/package.json +++ b/packages/nc-gui/package.json @@ -52,7 +52,7 @@ "jwt-decode": "^3.1.2", "locale-codes": "^1.3.1", "monaco-editor": "^0.33.0", - "nocodb-sdk": "file:../nocodb-sdk", + "nocodb-sdk": "0.105.3", "papaparse": "^5.3.2", "qrcode": "^1.5.1", "socket.io-client": "^4.5.1", diff --git a/packages/nc-lib-gui/package.json b/packages/nc-lib-gui/package.json index 4b69138b3d..c8291f6ecc 100644 --- a/packages/nc-lib-gui/package.json +++ b/packages/nc-lib-gui/package.json @@ -1,6 +1,6 @@ { "name": "nc-lib-gui", - "version": "0.105.2", + "version": "0.105.3", "description": "NocoDB GUI", "author": { "name": "NocoDB", diff --git a/packages/nocodb-sdk/package.json b/packages/nocodb-sdk/package.json index 86e88d8bc1..ec22d9e676 100644 --- a/packages/nocodb-sdk/package.json +++ b/packages/nocodb-sdk/package.json @@ -1,6 +1,6 @@ { "name": "nocodb-sdk", - "version": "0.105.2", + "version": "0.105.3", "description": "NocoDB SDK", "main": "build/main/index.js", "typings": "build/main/index.d.ts", diff --git a/packages/nocodb/package-lock.json b/packages/nocodb/package-lock.json index fd244d0f9b..0bbe63aa54 100644 --- a/packages/nocodb/package-lock.json +++ b/packages/nocodb/package-lock.json @@ -1,12 +1,12 @@ { "name": "nocodb", - "version": "0.105.2", + "version": "0.105.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "nocodb", - "version": "0.105.2", + "version": "0.105.3", "license": "AGPL-3.0-or-later", "dependencies": { "@google-cloud/storage": "^5.7.2", @@ -65,10 +65,10 @@ "mysql2": "^2.2.5", "nanoid": "^3.1.20", "nc-help": "0.2.85", - "nc-lib-gui": "0.105.2", + "nc-lib-gui": "0.105.3", "nc-plugin": "0.1.2", "ncp": "^2.0.0", - "nocodb-sdk": "file:../nocodb-sdk", + "nocodb-sdk": "0.105.3", "nodemailer": "^6.4.10", "object-hash": "^3.0.0", "os-locale": "^5.0.0", @@ -154,7 +154,8 @@ } }, "../nocodb-sdk": { - "version": "0.105.2", + "version": "0.105.3", + "extraneous": true, "license": "AGPL-3.0-or-later", "dependencies": { "axios": "^0.21.1", @@ -11257,9 +11258,9 @@ } }, "node_modules/nc-lib-gui": { - "version": "0.105.2", - "resolved": "https://registry.npmjs.org/nc-lib-gui/-/nc-lib-gui-0.105.2.tgz", - "integrity": "sha512-uycep2vme3XP6PwvFjJ6wE2fpCNiaJ/ptWR7ZHwRCu500eJGdtonWc00BQf01FitQ1vKq9Cpqqi2b0hoFBLFvQ==", + "version": "0.105.3", + "resolved": "https://registry.npmjs.org/nc-lib-gui/-/nc-lib-gui-0.105.3.tgz", + "integrity": "sha512-w07Y2+nBiUQYiUyURwH9nqvzzxXsz8MALU/MhmWyNe3Z0YhBvPPLLUxtG1WR3USLI925YT0BsAZTn+iSP3ooPw==", "dependencies": { "express": "^4.17.1" } @@ -11318,8 +11319,13 @@ "dev": true }, "node_modules/nocodb-sdk": { - "resolved": "../nocodb-sdk", - "link": true + "version": "0.105.3", + "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", + "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", + "dependencies": { + "axios": "^0.21.1", + "jsep": "^1.3.6" + } }, "node_modules/node-abort-controller": { "version": "3.0.1", @@ -27875,9 +27881,9 @@ } }, "nc-lib-gui": { - "version": "0.105.2", - "resolved": "https://registry.npmjs.org/nc-lib-gui/-/nc-lib-gui-0.105.2.tgz", - "integrity": "sha512-uycep2vme3XP6PwvFjJ6wE2fpCNiaJ/ptWR7ZHwRCu500eJGdtonWc00BQf01FitQ1vKq9Cpqqi2b0hoFBLFvQ==", + "version": "0.105.3", + "resolved": "https://registry.npmjs.org/nc-lib-gui/-/nc-lib-gui-0.105.3.tgz", + "integrity": "sha512-w07Y2+nBiUQYiUyURwH9nqvzzxXsz8MALU/MhmWyNe3Z0YhBvPPLLUxtG1WR3USLI925YT0BsAZTn+iSP3ooPw==", "requires": { "express": "^4.17.1" } @@ -27924,22 +27930,12 @@ "dev": true }, "nocodb-sdk": { - "version": "file:../nocodb-sdk", + "version": "0.105.3", + "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", + "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", "requires": { - "@typescript-eslint/eslint-plugin": "^4.0.1", - "@typescript-eslint/parser": "^4.0.1", "axios": "^0.21.1", - "cspell": "^4.1.0", - "eslint": "^7.8.0", - "eslint-config-prettier": "^6.11.0", - "eslint-plugin-eslint-comments": "^3.2.0", - "eslint-plugin-functional": "^3.0.2", - "eslint-plugin-import": "^2.22.0", - "eslint-plugin-prettier": "^4.0.0", - "jsep": "^1.3.6", - "npm-run-all": "^4.1.5", - "prettier": "^2.1.1", - "typescript": "^4.0.2" + "jsep": "^1.3.6" } }, "node-abort-controller": { diff --git a/packages/nocodb/package.json b/packages/nocodb/package.json index ebb9842020..3045d52b5a 100644 --- a/packages/nocodb/package.json +++ b/packages/nocodb/package.json @@ -1,6 +1,6 @@ { "name": "nocodb", - "version": "0.105.2", + "version": "0.105.3", "description": "NocoDB Backend", "main": "dist/bundle.js", "author": { @@ -105,10 +105,10 @@ "mysql2": "^2.2.5", "nanoid": "^3.1.20", "nc-help": "0.2.85", - "nc-lib-gui": "0.105.2", + "nc-lib-gui": "0.105.3", "nc-plugin": "0.1.2", "ncp": "^2.0.0", - "nocodb-sdk": "file:../nocodb-sdk", + "nocodb-sdk": "0.105.3", "nodemailer": "^6.4.10", "object-hash": "^3.0.0", "os-locale": "^5.0.0", @@ -184,4 +184,4 @@ "prettier": { "singleQuote": true } -} +} \ No newline at end of file From 259c7ee529de2c18f9d61d940ba035bf08fa42aa Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Tue, 21 Feb 2023 16:01:13 +0800 Subject: [PATCH 25/25] chore: update sdk paths --- packages/nc-gui/package-lock.json | 52 +++++++++++---------------- packages/nc-gui/package.json | 2 +- packages/nocodb-sdk/package-lock.json | 4 +-- packages/nocodb/package-lock.json | 30 +++++++++------- packages/nocodb/package.json | 4 +-- 5 files changed, 42 insertions(+), 50 deletions(-) diff --git a/packages/nc-gui/package-lock.json b/packages/nc-gui/package-lock.json index e52054f981..f7ab5bfabf 100644 --- a/packages/nc-gui/package-lock.json +++ b/packages/nc-gui/package-lock.json @@ -29,7 +29,7 @@ "jwt-decode": "^3.1.2", "locale-codes": "^1.3.1", "monaco-editor": "^0.33.0", - "nocodb-sdk": "0.105.3", + "nocodb-sdk": "file:../nocodb-sdk", "papaparse": "^5.3.2", "qrcode": "^1.5.1", "socket.io-client": "^4.5.1", @@ -98,7 +98,6 @@ }, "../nocodb-sdk": { "version": "0.105.3", - "extraneous": true, "license": "AGPL-3.0-or-later", "dependencies": { "axios": "^0.21.1", @@ -8555,6 +8554,7 @@ "version": "1.15.1", "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.1.tgz", "integrity": "sha512-yLAMQs+k0b2m7cVxpS1VKJVvoz7SS9Td1zss3XRwXj+ZDH00RJgnuLx7E44wx02kQLrdM3aOOy+FpzS7+8OizA==", + "devOptional": true, "funding": [ { "type": "individual", @@ -11970,21 +11970,8 @@ } }, "node_modules/nocodb-sdk": { - "version": "0.105.3", - "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", - "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", - "dependencies": { - "axios": "^0.21.1", - "jsep": "^1.3.6" - } - }, - "node_modules/nocodb-sdk/node_modules/axios": { - "version": "0.21.4", - "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz", - "integrity": "sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==", - "dependencies": { - "follow-redirects": "^1.14.0" - } + "resolved": "../nocodb-sdk", + "link": true }, "node_modules/node-abi": { "version": "3.23.0", @@ -23975,7 +23962,8 @@ "follow-redirects": { "version": "1.15.1", "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.1.tgz", - "integrity": "sha512-yLAMQs+k0b2m7cVxpS1VKJVvoz7SS9Td1zss3XRwXj+ZDH00RJgnuLx7E44wx02kQLrdM3aOOy+FpzS7+8OizA==" + "integrity": "sha512-yLAMQs+k0b2m7cVxpS1VKJVvoz7SS9Td1zss3XRwXj+ZDH00RJgnuLx7E44wx02kQLrdM3aOOy+FpzS7+8OizA==", + "devOptional": true }, "form-data": { "version": "4.0.0", @@ -26448,22 +26436,22 @@ } }, "nocodb-sdk": { - "version": "0.105.3", - "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", - "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", + "version": "file:../nocodb-sdk", "requires": { + "@typescript-eslint/eslint-plugin": "^4.0.1", + "@typescript-eslint/parser": "^4.0.1", "axios": "^0.21.1", - "jsep": "^1.3.6" - }, - "dependencies": { - "axios": { - "version": "0.21.4", - "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz", - "integrity": "sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==", - "requires": { - "follow-redirects": "^1.14.0" - } - } + "cspell": "^4.1.0", + "eslint": "^7.8.0", + "eslint-config-prettier": "^6.11.0", + "eslint-plugin-eslint-comments": "^3.2.0", + "eslint-plugin-functional": "^3.0.2", + "eslint-plugin-import": "^2.22.0", + "eslint-plugin-prettier": "^4.0.0", + "jsep": "^1.3.6", + "npm-run-all": "^4.1.5", + "prettier": "^2.1.1", + "typescript": "^4.0.2" } }, "node-abi": { diff --git a/packages/nc-gui/package.json b/packages/nc-gui/package.json index eab13cc396..b37773df3f 100644 --- a/packages/nc-gui/package.json +++ b/packages/nc-gui/package.json @@ -52,7 +52,7 @@ "jwt-decode": "^3.1.2", "locale-codes": "^1.3.1", "monaco-editor": "^0.33.0", - "nocodb-sdk": "0.105.3", + "nocodb-sdk": "file:../nocodb-sdk", "papaparse": "^5.3.2", "qrcode": "^1.5.1", "socket.io-client": "^4.5.1", diff --git a/packages/nocodb-sdk/package-lock.json b/packages/nocodb-sdk/package-lock.json index e9169032f3..8c1bda86b4 100644 --- a/packages/nocodb-sdk/package-lock.json +++ b/packages/nocodb-sdk/package-lock.json @@ -1,12 +1,12 @@ { "name": "nocodb-sdk", - "version": "0.105.2", + "version": "0.105.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "nocodb-sdk", - "version": "0.105.2", + "version": "0.105.3", "license": "AGPL-3.0-or-later", "dependencies": { "axios": "^0.21.1", diff --git a/packages/nocodb/package-lock.json b/packages/nocodb/package-lock.json index 0bbe63aa54..c63e48dd18 100644 --- a/packages/nocodb/package-lock.json +++ b/packages/nocodb/package-lock.json @@ -68,7 +68,7 @@ "nc-lib-gui": "0.105.3", "nc-plugin": "0.1.2", "ncp": "^2.0.0", - "nocodb-sdk": "0.105.3", + "nocodb-sdk": "file:../nocodb-sdk", "nodemailer": "^6.4.10", "object-hash": "^3.0.0", "os-locale": "^5.0.0", @@ -155,7 +155,6 @@ }, "../nocodb-sdk": { "version": "0.105.3", - "extraneous": true, "license": "AGPL-3.0-or-later", "dependencies": { "axios": "^0.21.1", @@ -11319,13 +11318,8 @@ "dev": true }, "node_modules/nocodb-sdk": { - "version": "0.105.3", - "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", - "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", - "dependencies": { - "axios": "^0.21.1", - "jsep": "^1.3.6" - } + "resolved": "../nocodb-sdk", + "link": true }, "node_modules/node-abort-controller": { "version": "3.0.1", @@ -27930,12 +27924,22 @@ "dev": true }, "nocodb-sdk": { - "version": "0.105.3", - "resolved": "https://registry.npmjs.org/nocodb-sdk/-/nocodb-sdk-0.105.3.tgz", - "integrity": "sha512-WLPIVlDIqLtRzhehAJE6t/51kk0tGU7EDOLJ64+/jvlh7gdjizWMyA1lvmKHl7extzn2ISLVxO6YtPJ/ufoY2A==", + "version": "file:../nocodb-sdk", "requires": { + "@typescript-eslint/eslint-plugin": "^4.0.1", + "@typescript-eslint/parser": "^4.0.1", "axios": "^0.21.1", - "jsep": "^1.3.6" + "cspell": "^4.1.0", + "eslint": "^7.8.0", + "eslint-config-prettier": "^6.11.0", + "eslint-plugin-eslint-comments": "^3.2.0", + "eslint-plugin-functional": "^3.0.2", + "eslint-plugin-import": "^2.22.0", + "eslint-plugin-prettier": "^4.0.0", + "jsep": "^1.3.6", + "npm-run-all": "^4.1.5", + "prettier": "^2.1.1", + "typescript": "^4.0.2" } }, "node-abort-controller": { diff --git a/packages/nocodb/package.json b/packages/nocodb/package.json index 3045d52b5a..87bcff9e79 100644 --- a/packages/nocodb/package.json +++ b/packages/nocodb/package.json @@ -108,7 +108,7 @@ "nc-lib-gui": "0.105.3", "nc-plugin": "0.1.2", "ncp": "^2.0.0", - "nocodb-sdk": "0.105.3", + "nocodb-sdk": "file:../nocodb-sdk", "nodemailer": "^6.4.10", "object-hash": "^3.0.0", "os-locale": "^5.0.0", @@ -184,4 +184,4 @@ "prettier": { "singleQuote": true } -} \ No newline at end of file +}