From 8f09668d0f0fa7fe79d950412416c54dd2076c22 Mon Sep 17 00:00:00 2001
From: WK Wong <wingkwong.code@gmail.com>
Date: Tue, 3 Oct 2023 11:31:26 +0800
Subject: [PATCH] fix(nc-gui): lint issues

---
 .../components/dashboard/Sidebar/UserInfo.vue | 15 +++++++++++--
 .../dashboard/TreeView/ProjectNode.vue        | 21 ++++++++++++++++++-
 .../dashboard/TreeView/ViewsList.vue          |  9 +-------
 .../components/dashboard/TreeView/index.vue   |  2 +-
 packages/nc-gui/components/dlg/ViewCreate.vue |  2 +-
 .../nc-gui/components/smartsheet/Topbar.vue   |  2 --
 .../components/smartsheet/details/Fields.vue  |  2 --
 packages/nc-gui/composables/useViewData.ts    |  2 +-
 packages/nc-gui/pages/signin.vue              |  2 --
 9 files changed, 37 insertions(+), 20 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/Sidebar/UserInfo.vue b/packages/nc-gui/components/dashboard/Sidebar/UserInfo.vue
index 8a878878b5..e116190517 100644
--- a/packages/nc-gui/components/dashboard/Sidebar/UserInfo.vue
+++ b/packages/nc-gui/components/dashboard/Sidebar/UserInfo.vue
@@ -1,12 +1,23 @@
 <script lang="ts" setup>
 import GithubButton from 'vue-github-button'
+import {
+  computed,
+  message,
+  navigateTo,
+  onMounted,
+  ref,
+  storeToRefs,
+  useCopy,
+  useGlobal,
+  useSidebarStore,
+  useUsers,
+  watch,
+} from '#imports'
 
 const { user, signOut, token, appInfo } = useGlobal()
 // So watcher in users store is triggered
 useUsers()
 
-const { clearWorkspaces } = useWorkspace()
-
 const { leftSidebarState } = storeToRefs(useSidebarStore())
 
 const { copy } = useCopy(true)
diff --git a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
index df332f48d0..b135802c3f 100644
--- a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
@@ -10,10 +10,27 @@ import {
   ProjectInj,
   ProjectRoleInj,
   ToggleDialogInj,
+  TreeViewInj,
+  computed,
   extractSdkResponseErrorMsg,
+  h,
+  inject,
+  navigateTo,
   openLink,
+  ref,
+  resolveComponent,
   storeToRefs,
+  useBase,
   useBases,
+  useCopy,
+  useDialog,
+  useGlobal,
+  useI18n,
+  useRoles,
+  useRouter,
+  useTablesStore,
+  useTabs,
+  useToggle,
 } from '#imports'
 import type { NcProject } from '#imports'
 import { useNuxtApp } from '#app'
@@ -27,10 +44,10 @@ const indicator = h(LoadingOutlined, {
 })
 
 const router = useRouter()
+
 const route = router.currentRoute
 
 const { isSharedBase } = storeToRefs(useBase())
-const { projectUrl } = useBase()
 
 const { setMenuContext, openRenameTableDialog, duplicateTable, contextMenuTarget } = inject(TreeViewInj)!
 
@@ -41,9 +58,11 @@ const basesStore = useBases()
 const { isMobileMode } = useGlobal()
 
 const { loadProject, loadProjects, createProject: _createProject, updateProject, getProjectMetaInfo } = basesStore
+
 const { bases } = storeToRefs(basesStore)
 
 const { loadProjectTables } = useTablesStore()
+
 const { activeTable } = storeToRefs(useTablesStore())
 
 const { appInfo, navigateToProject } = useGlobal()
diff --git a/packages/nc-gui/components/dashboard/TreeView/ViewsList.vue b/packages/nc-gui/components/dashboard/TreeView/ViewsList.vue
index b6cfdae594..fa406a4f12 100644
--- a/packages/nc-gui/components/dashboard/TreeView/ViewsList.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/ViewsList.vue
@@ -5,7 +5,6 @@ import type { SortableEvent } from 'sortablejs'
 import Sortable from 'sortablejs'
 import type { Menu as AntMenu } from 'ant-design-vue'
 import {
-  isDefaultBase as _isDefaultBase,
   extractSdkResponseErrorMsg,
   message,
   onMounted,
@@ -36,14 +35,8 @@ const { isLeftSidebarOpen } = storeToRefs(useSidebarStore())
 const { isMobileMode } = useGlobal()
 
 const { $e } = useNuxtApp()
-const { t } = useI18n()
-
-const isDefaultBase = computed(() => {
-  const source = base.value?.sources?.find((b) => b.id === table.value.source_id)
-  if (!source) return false
 
-  return _isDefaultBase(source)
-})
+const { t } = useI18n()
 
 const { viewsByTable, activeView, recentViews } = storeToRefs(useViewsStore())
 
diff --git a/packages/nc-gui/components/dashboard/TreeView/index.vue b/packages/nc-gui/components/dashboard/TreeView/index.vue
index 3526dab0c0..9d2e387a52 100644
--- a/packages/nc-gui/components/dashboard/TreeView/index.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/index.vue
@@ -68,7 +68,7 @@ const setMenuContext = (type: 'base' | 'source' | 'table' | 'main' | 'layout', v
   contextMenuTarget.value = value
 }
 
-function openRenameTableDialog(table: TableType, rightClick = false) {
+function openRenameTableDialog(table: TableType, _ = false) {
   if (!table || !table.source_id) return
 
   $e('c:table:rename')
diff --git a/packages/nc-gui/components/dlg/ViewCreate.vue b/packages/nc-gui/components/dlg/ViewCreate.vue
index 5a7c7dfe0f..93644dac77 100644
--- a/packages/nc-gui/components/dlg/ViewCreate.vue
+++ b/packages/nc-gui/components/dlg/ViewCreate.vue
@@ -2,7 +2,7 @@
 import type { ComponentPublicInstance } from '@vue/runtime-core'
 import type { Form as AntForm, SelectProps } from 'ant-design-vue'
 import { capitalize } from '@vue/runtime-core'
-import type { FormType, GalleryType, GridType, KanbanType, MapType, TableType, ViewType } from 'nocodb-sdk'
+import type { FormType, GalleryType, GridType, KanbanType, MapType, TableType } from 'nocodb-sdk'
 import { UITypes, ViewTypes } from 'nocodb-sdk'
 import { computed, message, nextTick, onBeforeMount, reactive, ref, useApi, useI18n, useVModel, watch } from '#imports'
 
diff --git a/packages/nc-gui/components/smartsheet/Topbar.vue b/packages/nc-gui/components/smartsheet/Topbar.vue
index 1b25224e47..a61c868f4b 100644
--- a/packages/nc-gui/components/smartsheet/Topbar.vue
+++ b/packages/nc-gui/components/smartsheet/Topbar.vue
@@ -10,8 +10,6 @@ const isPublic = inject(IsPublicInj, ref(false))
 
 const { isViewsLoading } = storeToRefs(useViewsStore())
 
-const { isLeftSidebarOpen } = storeToRefs(useSidebarStore())
-
 const { isMobileMode } = storeToRefs(useConfigStore())
 
 const { appInfo } = useGlobal()
diff --git a/packages/nc-gui/components/smartsheet/details/Fields.vue b/packages/nc-gui/components/smartsheet/details/Fields.vue
index 3f66775416..3e134aaf6d 100644
--- a/packages/nc-gui/components/smartsheet/details/Fields.vue
+++ b/packages/nc-gui/components/smartsheet/details/Fields.vue
@@ -43,8 +43,6 @@ const moveOps = ref<moveOp[]>([])
 
 const visibilityOps = ref<fieldsVisibilityOps[]>([])
 
-const selectedView = inject(ActiveViewInj)
-
 const { fields: viewFields, toggleFieldVisibility, loadViewColumns } = useViewColumns(view, meta as Ref<TableType | undefined>)
 
 const loading = ref(false)
diff --git a/packages/nc-gui/composables/useViewData.ts b/packages/nc-gui/composables/useViewData.ts
index a159d7325d..6e2a5c2ef7 100644
--- a/packages/nc-gui/composables/useViewData.ts
+++ b/packages/nc-gui/composables/useViewData.ts
@@ -77,7 +77,7 @@ export function useViewData(
 
   const { sharedView, fetchSharedViewData, paginationData: sharedPaginationData } = useSharedView()
 
-  const { $api, $e } = useNuxtApp()
+  const { $api } = useNuxtApp()
 
   const { sorts, nestedFilters } = useSmartsheetStoreOrThrow()
 
diff --git a/packages/nc-gui/pages/signin.vue b/packages/nc-gui/pages/signin.vue
index 61f1162de4..33adce9d93 100644
--- a/packages/nc-gui/pages/signin.vue
+++ b/packages/nc-gui/pages/signin.vue
@@ -26,8 +26,6 @@ const { t } = useI18n()
 
 useSidebar('nc-left-sidebar', { hasSidebar: false })
 
-const { clearWorkspaces } = useWorkspace()
-
 const formValidator = ref()
 
 const form = reactive({