refactor: extract icon based on index

packages/nc-gui/components/cell/Rating.vue

@@ -1,4 +1,6 @@
 <script setup lang="ts">
+import { extractRatingIcon } from '../../utils/columnUtils'
+
 interface Props {
   modelValue?: number | null | undefined
 }
@@ -16,11 +18,9 @@ const rowHeight = inject(RowHeightInj, ref(undefined))
 const isExpandedFormOpen = inject(IsExpandedFormOpenInj, ref(false))!
 
 const ratingMeta = computed(() => {
+  const icon = extractRatingIcon(column?.value?.meta)
   return {
-    icon: {
+    icon,
-      full: 'mdi-star',
-      empty: 'mdi-star-outline',
-    },
     color: '#fcb401',
     max: 5,
     ...parseProp(column.value?.meta),

packages/nc-gui/components/smartsheet/column/CheckboxOptions.vue

@@ -25,6 +25,7 @@ const isOpenColorPicker = ref(false)
 vModel.value.meta = {
   ...columnDefaultMeta[UITypes.Checkbox],
   ...(vModel.value.meta || {}),
+  icon: extractCheckboxIcon(vModel.value.meta || {}),
 }
 
 // antdv doesn't support object as value

packages/nc-gui/components/smartsheet/column/RatingOptions.vue

@@ -22,6 +22,7 @@ const isOpenColorPicker = ref(false)
 vModel.value.meta = {
   ...columnDefaultMeta[UITypes.Rating],
   ...(vModel.value.meta || {}),
+  icon: extractRatingIcon(vModel.value.meta || {}),
 }
 
 // antdv doesn't support object as value

packages/nc-gui/utils/columnUtils.ts

@@ -323,9 +323,9 @@ function extractCheckboxIcon(meta: string | Record<string, any> = null) {
   if (parsedMeta.icon) {
     icon.checked = parsedMeta.icon.checked || icon.checked
     icon.unchecked = parsedMeta.icon.unchecked || icon.unchecked
-  } else if (typeof parsedMeta.iconIndex === 'number' && checkboxIconList[parsedMeta.iconIndex]) {
+  } else if (typeof parsedMeta.iconIdx === 'number' && checkboxIconList[parsedMeta.iconIdx]) {
-    icon.checked = checkboxIconList[parsedMeta.iconIndex].checked
+    icon.checked = checkboxIconList[parsedMeta.iconIdx].checked
-    icon.unchecked = checkboxIconList[parsedMeta.iconIndex].unchecked
+    icon.unchecked = checkboxIconList[parsedMeta.iconIdx].unchecked
   }
   return icon
 }
@@ -341,9 +341,9 @@ function extractRatingIcon(meta: string | Record<string, any> = null) {
   if (parsedMeta.icon) {
     icon.full = parsedMeta.icon.full || icon.full
     icon.empty = parsedMeta.icon.empty || icon.empty
-  } else if (typeof parsedMeta.iconIndex === 'number' && ratingIconList[parsedMeta.iconIndex]) {
+  } else if (typeof parsedMeta.iconIdx === 'number' && ratingIconList[parsedMeta.iconIdx]) {
-    icon.full = ratingIconList[parsedMeta.iconIndex].full
+    icon.full = ratingIconList[parsedMeta.iconIdx].full
-    icon.empty = ratingIconList[parsedMeta.iconIndex].empty
+    icon.empty = ratingIconList[parsedMeta.iconIdx].empty
   }
   return icon
 }
@@ -361,4 +361,5 @@ export {
   checkboxIconList,
   ratingIconList,
   extractCheckboxIcon,
+  extractRatingIcon,
 }