From 8e1c05090c0706d0cbdaa258e149b38ce8f160aa Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Wed, 16 Oct 2024 10:30:46 +0000
Subject: [PATCH] refactor: extract icon based on index

---
 packages/nc-gui/components/cell/Rating.vue          |  8 ++++----
 .../smartsheet/column/CheckboxOptions.vue           |  1 +
 .../components/smartsheet/column/RatingOptions.vue  |  1 +
 packages/nc-gui/utils/columnUtils.ts                | 13 +++++++------
 4 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/packages/nc-gui/components/cell/Rating.vue b/packages/nc-gui/components/cell/Rating.vue
index 9b97f7f37f..26cb5b5ad5 100644
--- a/packages/nc-gui/components/cell/Rating.vue
+++ b/packages/nc-gui/components/cell/Rating.vue
@@ -1,4 +1,6 @@
 <script setup lang="ts">
+import { extractRatingIcon } from '../../utils/columnUtils'
+
 interface Props {
   modelValue?: number | null | undefined
 }
@@ -16,11 +18,9 @@ const rowHeight = inject(RowHeightInj, ref(undefined))
 const isExpandedFormOpen = inject(IsExpandedFormOpenInj, ref(false))!
 
 const ratingMeta = computed(() => {
+  const icon = extractRatingIcon(column?.value?.meta)
   return {
-    icon: {
-      full: 'mdi-star',
-      empty: 'mdi-star-outline',
-    },
+    icon,
     color: '#fcb401',
     max: 5,
     ...parseProp(column.value?.meta),
diff --git a/packages/nc-gui/components/smartsheet/column/CheckboxOptions.vue b/packages/nc-gui/components/smartsheet/column/CheckboxOptions.vue
index 4b32cc513c..8de4a4a82d 100644
--- a/packages/nc-gui/components/smartsheet/column/CheckboxOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/CheckboxOptions.vue
@@ -25,6 +25,7 @@ const isOpenColorPicker = ref(false)
 vModel.value.meta = {
   ...columnDefaultMeta[UITypes.Checkbox],
   ...(vModel.value.meta || {}),
+  icon: extractCheckboxIcon(vModel.value.meta || {}),
 }
 
 // antdv doesn't support object as value
diff --git a/packages/nc-gui/components/smartsheet/column/RatingOptions.vue b/packages/nc-gui/components/smartsheet/column/RatingOptions.vue
index 041a149de4..31a909ac02 100644
--- a/packages/nc-gui/components/smartsheet/column/RatingOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/RatingOptions.vue
@@ -22,6 +22,7 @@ const isOpenColorPicker = ref(false)
 vModel.value.meta = {
   ...columnDefaultMeta[UITypes.Rating],
   ...(vModel.value.meta || {}),
+  icon: extractRatingIcon(vModel.value.meta || {}),
 }
 
 // antdv doesn't support object as value
diff --git a/packages/nc-gui/utils/columnUtils.ts b/packages/nc-gui/utils/columnUtils.ts
index 9a4299d843..10c6d03456 100644
--- a/packages/nc-gui/utils/columnUtils.ts
+++ b/packages/nc-gui/utils/columnUtils.ts
@@ -323,9 +323,9 @@ function extractCheckboxIcon(meta: string | Record<string, any> = null) {
   if (parsedMeta.icon) {
     icon.checked = parsedMeta.icon.checked || icon.checked
     icon.unchecked = parsedMeta.icon.unchecked || icon.unchecked
-  } else if (typeof parsedMeta.iconIndex === 'number' && checkboxIconList[parsedMeta.iconIndex]) {
-    icon.checked = checkboxIconList[parsedMeta.iconIndex].checked
-    icon.unchecked = checkboxIconList[parsedMeta.iconIndex].unchecked
+  } else if (typeof parsedMeta.iconIdx === 'number' && checkboxIconList[parsedMeta.iconIdx]) {
+    icon.checked = checkboxIconList[parsedMeta.iconIdx].checked
+    icon.unchecked = checkboxIconList[parsedMeta.iconIdx].unchecked
   }
   return icon
 }
@@ -341,9 +341,9 @@ function extractRatingIcon(meta: string | Record<string, any> = null) {
   if (parsedMeta.icon) {
     icon.full = parsedMeta.icon.full || icon.full
     icon.empty = parsedMeta.icon.empty || icon.empty
-  } else if (typeof parsedMeta.iconIndex === 'number' && ratingIconList[parsedMeta.iconIndex]) {
-    icon.full = ratingIconList[parsedMeta.iconIndex].full
-    icon.empty = ratingIconList[parsedMeta.iconIndex].empty
+  } else if (typeof parsedMeta.iconIdx === 'number' && ratingIconList[parsedMeta.iconIdx]) {
+    icon.full = ratingIconList[parsedMeta.iconIdx].full
+    icon.empty = ratingIconList[parsedMeta.iconIdx].empty
   }
   return icon
 }
@@ -361,4 +361,5 @@ export {
   checkboxIconList,
   ratingIconList,
   extractCheckboxIcon,
+  extractRatingIcon,
 }