Browse Source

chore: suggested changes

Signed-off-by: Pranav C <pranavxc@gmail.com>
pull/5174/head
Pranav C 2 years ago
parent
commit
8dbf966fdd
  1. 2
      packages/nocodb-sdk/package.json
  2. 1
      packages/nocodb/src/lib/meta/api/formViewColumnApis.ts
  3. 4
      packages/nocodb/src/lib/models/Filter.ts
  4. 4
      packages/nocodb/src/lib/models/Project.ts

2
packages/nocodb-sdk/package.json

@ -31,7 +31,7 @@
"test:prettier": "prettier \"src/**/*.ts\" --list-different", "test:prettier": "prettier \"src/**/*.ts\" --list-different",
"test:spelling": "cspell \"{README.md,.github/*.md,src/**/*.ts}\"", "test:spelling": "cspell \"{README.md,.github/*.md,src/**/*.ts}\"",
"watch:build": "tsc -p tsconfig.json -w", "watch:build": "tsc -p tsconfig.json -w",
"generate:sdk": "npx --yes swagger-typescript-api@10.0.3 -r -p ../../packages/nocodb/src/schema/swagger.json -o ./src/lib/ --axios --unwrap-response-data --module-name-first-tag --type-suffix=Type --templates ../../scripts/sdk/templates" "generate:sdk": "npx --yes swagger-typescript-api@10.0.3 -r -p ../nocodb/src/schema/swagger.json -o ./src/lib/ --axios --unwrap-response-data --module-name-first-tag --type-suffix=Type --templates ../../scripts/sdk/templates"
}, },
"dependencies": { "dependencies": {
"axios": "^0.21.1", "axios": "^0.21.1",

1
packages/nocodb/src/lib/meta/api/formViewColumnApis.ts

@ -4,7 +4,6 @@ import { Tele } from 'nc-help';
import ncMetaAclMw from '../helpers/ncMetaAclMw'; import ncMetaAclMw from '../helpers/ncMetaAclMw';
import { metaApiMetrics } from '../helpers/apiMetrics'; import { metaApiMetrics } from '../helpers/apiMetrics';
import { getAjvValidatorMw } from './helpers'; import { getAjvValidatorMw } from './helpers';
// import { getAjvValidatorMw } from './helpers'
export async function columnUpdate(req: Request, res: Response) { export async function columnUpdate(req: Request, res: Response) {
Tele.emit('evt', { evt_type: 'formViewColumn:updated' }); Tele.emit('evt', { evt_type: 'formViewColumn:updated' });

4
packages/nocodb/src/lib/models/Filter.ts

@ -9,7 +9,7 @@ import {
MetaTable, MetaTable,
} from '../utils/globals'; } from '../utils/globals';
import View from './View'; import View from './View';
import { FilterType, UITypes } from 'nocodb-sdk'; import { BoolType, FilterType, UITypes } from 'nocodb-sdk';
import NocoCache from '../cache/NocoCache'; import NocoCache from '../cache/NocoCache';
import { NcError } from '../meta/helpers/catchError'; import { NcError } from '../meta/helpers/catchError';
import { extractProps } from '../meta/helpers/extractProps'; import { extractProps } from '../meta/helpers/extractProps';
@ -55,7 +55,7 @@ export default class Filter {
value?: string; value?: string;
logical_op?: string; logical_op?: string;
is_group?: boolean | number; is_group?: BoolType;
children?: Filter[]; children?: Filter[];
project_id?: string; project_id?: string;
base_id?: string; base_id?: string;

4
packages/nocodb/src/lib/models/Project.ts

@ -1,6 +1,6 @@
import Base from './/Base'; import Base from './/Base';
import Noco from '../Noco'; import Noco from '../Noco';
import { BoolType, ProjectType } from 'nocodb-sdk'; import { BoolType, MetaType, ProjectType } from 'nocodb-sdk';
import { import {
CacheDelDirection, CacheDelDirection,
CacheGetType, CacheGetType,
@ -16,7 +16,7 @@ export default class Project implements ProjectType {
public prefix: string; public prefix: string;
public status: string; public status: string;
public description: string; public description: string;
public meta: string; public meta: MetaType;
public color: string; public color: string;
public deleted: BoolType; public deleted: BoolType;
public order: number; public order: number;

Loading…
Cancel
Save