Browse Source

fix/Added pr suggestions

pull/2641/head
Muhammed Mustafa 2 years ago
parent
commit
8d71e1c88b
  1. 12
      packages/nc-gui/components/FeedbackForm.vue
  2. 2
      packages/nc-gui/plugins/projectLoader.js
  3. 2
      packages/nc-gui/store/settings.js

12
packages/nc-gui/components/FeedbackForm.vue

@ -1,6 +1,6 @@
<template>
<div v-if="!feedbackIsShown" class="nc-feedback-form-wrapper">
<v-icon class="nc-close-icon" large @click="feedbackIsShown = true"> mdi-close-circle-outline </v-icon>
<div v-if="!feedbackFormIsHidden" class="nc-feedback-form-wrapper">
<v-icon class="nc-close-icon" large @click="feedbackFormIsHidden = true"> mdi-close-circle-outline </v-icon>
<iframe :src="feedbackFormUrl" width="100%" height="500" frameborder="0" marginheight="0" marginwidth="0"
>Loading
@ -13,12 +13,12 @@
export default {
name: 'FeedbackForm',
computed: {
feedbackIsShown: {
feedbackFormIsHidden: {
get() {
return this.$store.state.settings.feedbackForm.isShown;
return this.$store.state.settings.feedbackForm.isHidden;
},
set(isShown) {
this.$store.commit('settings/MutFeedbackForm', { ...this.$store.state.settings.feedbackForm, isShown });
set(isHidden) {
this.$store.commit('settings/MutFeedbackForm', { ...this.$store.state.settings.feedbackForm, isHidden });
},
},
feedbackFormUrl() {

2
packages/nc-gui/plugins/projectLoader.js

@ -97,7 +97,7 @@ const handleFeedbackForm = async({ store, $axios }) => {
url: feedbackForm.url,
validTill: feedbackForm.valid_till,
createdAt: feedbackForm.created_at,
isShown: false
isHidden: false
})
}
} catch (e) {

2
packages/nc-gui/store/settings.js

@ -43,7 +43,7 @@ export const state = () => ({
// eslint-disable-next-line max-len
url: 'https://docs.google.com/forms/d/e/1FAIpQLSeTlAfZjszgr53lArz3NvUEnJGOT9JtG9NAU5d0oQwunDS2Pw/viewform?embedded=true',
createdAt: new Date('2020-01-01T00:00:00.000Z'),
isShown: false
isHidden: false
}
})

Loading…
Cancel
Save