From 3cf5d5f860418c6ffb6206995144b188caa6e6b2 Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Mon, 19 Sep 2022 11:20:30 +0200 Subject: [PATCH 1/8] fix(nc-gui): reset roles on app load --- packages/nc-gui/composables/useGlobal/index.ts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/packages/nc-gui/composables/useGlobal/index.ts b/packages/nc-gui/composables/useGlobal/index.ts index 49ead004bf..4591ff46a0 100644 --- a/packages/nc-gui/composables/useGlobal/index.ts +++ b/packages/nc-gui/composables/useGlobal/index.ts @@ -62,6 +62,22 @@ export const useGlobal = (): UseGlobalReturn => { { immediate: true }, ) + watch( + state.jwtPayload, + (nextPayload) => { + if (nextPayload) { + state.user.value = { + id: nextPayload.id, + email: nextPayload.email, + firstname: nextPayload.firstname, + lastname: nextPayload.lastname, + roles: nextPayload.roles, + } + } + }, + { immediate: true }, + ) + const globalState = { ...state, ...getters, ...actions } as UseGlobalReturn /** provide a fresh state instance into nuxt app */ From 255d90686d5258e761e09cb50e4d5453eb62e961 Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Mon, 19 Sep 2022 11:31:03 +0200 Subject: [PATCH 2/8] refactor(nc-gui): remove user from local storage --- packages/nc-gui/composables/useGlobal/state.ts | 5 ++++- packages/nc-gui/composables/useGlobal/types.ts | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/nc-gui/composables/useGlobal/state.ts b/packages/nc-gui/composables/useGlobal/state.ts index 5c90a25002..09181dbf07 100644 --- a/packages/nc-gui/composables/useGlobal/state.ts +++ b/packages/nc-gui/composables/useGlobal/state.ts @@ -49,7 +49,6 @@ export function useGlobalState(storageKey = 'nocodb-gui-v2'): State { /** State */ const initialState: StoredState = { token: null, - user: null, lang: preferredLanguage, darkMode: prefersDarkMode, feedbackForm: { @@ -102,6 +101,9 @@ export function useGlobalState(storageKey = 'nocodb-gui-v2'): State { /** global error */ const error = ref() + /** our local user object */ + const user = ref(null) + return { ...toRefs(storage.value), storage, @@ -110,6 +112,7 @@ export function useGlobalState(storageKey = 'nocodb-gui-v2'): State { timestamp, runningRequests, error, + user, appInfo, } } diff --git a/packages/nc-gui/composables/useGlobal/types.ts b/packages/nc-gui/composables/useGlobal/types.ts index f1ec9534ee..18939fb7df 100644 --- a/packages/nc-gui/composables/useGlobal/types.ts +++ b/packages/nc-gui/composables/useGlobal/types.ts @@ -29,7 +29,6 @@ export interface AppInfo { export interface StoredState { token: string | null - user: User | null lang: keyof typeof Language darkMode: boolean feedbackForm: FeedbackForm @@ -43,6 +42,7 @@ export interface StoredState { export type State = ToRefs> & { storage: Ref + user: Ref token: WritableComputedRef jwtPayload: ComputedRef<(JwtPayload & User) | null> timestamp: Ref From ef53bf864ede68f9651e16387c2e0b6151c5f697 Mon Sep 17 00:00:00 2001 From: Raju Udava <86527202+dstala@users.noreply.github.com> Date: Mon, 19 Sep 2022 16:09:53 +0530 Subject: [PATCH 3/8] test: cy-stability-column edit operations Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com> --- .../common/00_pre_configurations.js | 2 +- .../common/1b_table_column_operations.js | 36 +++++++-- .../integration/common/3b_formula_column.js | 30 +++++-- .../integration/common/3c_lookup_column.js | 33 ++++++-- .../integration/common/3d_rollup_column.js | 80 ++++++++++++------- .../integration/common/3e_duration_column.js | 51 +++++++++--- .../common/3f_link_to_another_record.js | 20 +++-- scripts/cypress/support/commands.js | 40 +++++----- .../cypress/support/page_objects/mainPage.js | 21 +++-- 9 files changed, 220 insertions(+), 93 deletions(-) diff --git a/scripts/cypress/integration/common/00_pre_configurations.js b/scripts/cypress/integration/common/00_pre_configurations.js index 506a16b7d1..ff5ef09ed0 100644 --- a/scripts/cypress/integration/common/00_pre_configurations.js +++ b/scripts/cypress/integration/common/00_pre_configurations.js @@ -164,7 +164,7 @@ export const genTest = (apiType, dbType) => { it("Admin SignUp", () => { cy.task("log", "This will be output to the terminal"); - loginPage.signUp(roles.owner.credentials); + loginPage.signIn(roles.owner.credentials); }); function cy_createProjectBlock(proj, apiType, dbType) { diff --git a/scripts/cypress/integration/common/1b_table_column_operations.js b/scripts/cypress/integration/common/1b_table_column_operations.js index a7c0c00494..c6f5471ef2 100644 --- a/scripts/cypress/integration/common/1b_table_column_operations.js +++ b/scripts/cypress/integration/common/1b_table_column_operations.js @@ -65,13 +65,26 @@ export const genTest = (apiType, dbType) => { .trigger("mouseover", { force: true }) .click({ force: true }); - cy.get(".nc-column-edit").click(); - cy.get(".nc-column-edit").should("not.be.visible"); + // cy.get(".nc-column-edit").click(); + // cy.get(".nc-column-edit").should("not.be.visible"); + cy.getActiveMenu(".nc-dropdown-column-operations") + .find(".nc-column-edit") + .click(); // change column type and verify - cy.get(".nc-column-type-input").last().click(); - cy.getActiveSelection('.nc-dropdown-column-type').find('.ant-select-item-option').contains("LongText").click(); - cy.get(".ant-btn-primary:visible").contains("Save").click(); + // cy.get(".nc-column-type-input").last().click(); + cy.getActiveMenu('.nc-dropdown-edit-column') + .find(".nc-column-type-input") + .last() + .click(); + cy.getActiveSelection('.nc-dropdown-column-type') + .find('.ant-select-item-option') + .contains("LongText") + .click(); + cy.getActiveMenu('.nc-dropdown-edit-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); cy.toastWait("Column updated"); } @@ -83,15 +96,22 @@ export const genTest = (apiType, dbType) => { .trigger("mouseover", { force: true }) .click({ force: true }); - cy.get(".nc-column-edit").click(); - cy.get(".nc-column-edit").should("not.be.visible"); + // cy.get(".nc-column-edit").click(); + // cy.get(".nc-column-edit").should("not.be.visible"); + cy.getActiveMenu(".nc-dropdown-column-operations") + .find(".nc-column-edit") + .click(); // rename column and verify cy.getActiveMenu(".nc-dropdown-edit-column").find('input.nc-column-name-input', { timeout: 3000 }) .should('exist') .clear() .type(updatedColName); - cy.get(".ant-btn-primary:visible").contains("Save").click(); + // cy.get(".ant-btn-primary:visible").contains("Save").click(); + cy.getActiveMenu('.nc-dropdown-edit-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); cy.toastWait("Column updated"); diff --git a/scripts/cypress/integration/common/3b_formula_column.js b/scripts/cypress/integration/common/3b_formula_column.js index 9d6e0a6171..f79ab26b56 100644 --- a/scripts/cypress/integration/common/3b_formula_column.js +++ b/scripts/cypress/integration/common/3b_formula_column.js @@ -57,10 +57,25 @@ export const genTest = (apiType, dbType) => { .should('exist') .clear() .type(columnName); - cy.get(".nc-column-type-input").last().click().type("Formula"); - cy.getActiveSelection('.nc-dropdown-column-type').find('.ant-select-item-option').contains("Formula").click(); - cy.get('textarea.nc-formula-input').click().type(formula, { parseSpecialCharSequences: false }); - cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + // cy.get(".nc-column-type-input").last().click().type("Formula"); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".nc-column-type-input") + .last() + .click() + .type("Formula"); + cy.getActiveSelection('.nc-dropdown-column-type') + .find('.ant-select-item-option') + .contains("Formula") + .click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find('textarea.nc-formula-input') + .click() + .type(formula, { parseSpecialCharSequences: false }); + // cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); // cy.toastWait(`Column created`); cy.closeTableTab("City"); @@ -82,8 +97,11 @@ export const genTest = (apiType, dbType) => { .trigger("mouseover", { force: true }) .click({ force: true }); - cy.get(".nc-column-edit").click(); - cy.get(".nc-column-edit").should("not.be.visible"); + // cy.get(".nc-column-edit").click(); + // cy.get(".nc-column-edit").should("not.be.visible"); + cy.getActiveMenu(".nc-dropdown-column-operations") + .find(".nc-column-edit") + .click(); cy.getActiveMenu(".nc-dropdown-edit-column").find('input.nc-column-name-input', { timeout: 3000 }) .should('exist') diff --git a/scripts/cypress/integration/common/3c_lookup_column.js b/scripts/cypress/integration/common/3c_lookup_column.js index 2656041826..6db00e01c4 100644 --- a/scripts/cypress/integration/common/3c_lookup_column.js +++ b/scripts/cypress/integration/common/3c_lookup_column.js @@ -48,21 +48,40 @@ export const genTest = (apiType, dbType) => { force: true, }); - cy.getActiveMenu(".nc-dropdown-grid-add-column").find('input.nc-column-name-input', { timeout: 3000 }) + cy.getActiveMenu(".nc-dropdown-grid-add-column") + .find('input.nc-column-name-input') .should('exist') .clear() .type(childCol); - cy.get(".nc-column-type-input").last().click().type("Lookup"); - cy.getActiveSelection('.nc-dropdown-column-type').find('.ant-select-item-option').contains("Lookup").click(); + // cy.get(".nc-column-type-input").last().click().type("Lookup"); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".nc-column-type-input") + .last() + .click() + .type("Lookup"); + cy.getActiveSelection('.nc-dropdown-column-type') + .find('.ant-select-item-option') + .contains("Lookup") + .click(); // Configure Child table & column names fetchParentFromLabel("Child table"); - cy.getActiveSelection('.nc-dropdown-relation-table').find('.ant-select-item-option').contains(childTable).click(); + cy.getActiveSelection('.nc-dropdown-relation-table') + .find('.ant-select-item-option') + .contains(childTable) + .click(); fetchParentFromLabel("Child column"); - cy.getActiveSelection('.nc-dropdown-relation-column').find('.ant-select-item-option').contains(childCol).click(); - - cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveSelection('.nc-dropdown-relation-column') + .find('.ant-select-item-option') + .contains(childCol) + .click(); + + // cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); cy.toastWait(`Column created`); cy.get(`th[data-title="${childCol}"]`).should("exist"); diff --git a/scripts/cypress/integration/common/3d_rollup_column.js b/scripts/cypress/integration/common/3d_rollup_column.js index a3867b008d..7446611c9d 100644 --- a/scripts/cypress/integration/common/3d_rollup_column.js +++ b/scripts/cypress/integration/common/3d_rollup_column.js @@ -54,24 +54,46 @@ export const genTest = (apiType, dbType) => { force: true, }); - cy.getActiveMenu(".nc-dropdown-grid-add-column").find('input.nc-column-name-input', { timeout: 3000 }) + cy.getActiveMenu(".nc-dropdown-grid-add-column") + .find('input.nc-column-name-input') .should('exist') .clear() .type(columnName); - cy.get(".nc-column-type-input").last().click().type("RollUp"); - cy.getActiveSelection('.nc-dropdown-column-type').find('.ant-select-item-option').contains("Rollup").click(); + // cy.get(".nc-column-type-input").last().click().type("RollUp"); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".nc-column-type-input") + .last() + .click() + .type("RollUp") + cy.getActiveSelection('.nc-dropdown-column-type') + .find('.ant-select-item-option') + .contains("Rollup") + .click(); // Configure Child table & column names fetchParentFromLabel("Child table"); - cy.getActiveSelection('.nc-dropdown-relation-table').find('.ant-select-item-option').contains(childTable).click(); + cy.getActiveSelection('.nc-dropdown-relation-table') + .find('.ant-select-item-option') + .contains(childTable) + .click(); fetchParentFromLabel("Child column"); - cy.getActiveSelection('.nc-dropdown-relation-column').find('.ant-select-item-option').contains(childCol).click(); + cy.getActiveSelection('.nc-dropdown-relation-column') + .find('.ant-select-item-option') + .contains(childCol) + .click(); fetchParentFromLabel("Aggregate function"); - cy.getActiveSelection('.nc-dropdown-rollup-function').find('.ant-select-item-option').contains(aggregateFunc).click(); - - cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveSelection('.nc-dropdown-rollup-function') + .find('.ant-select-item-option') + .contains(aggregateFunc) + .click(); + + // cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); cy.toastWait(`Column created`); cy.get(`th[data-title="${columnName}"]`).should("exist"); @@ -85,26 +107,26 @@ export const genTest = (apiType, dbType) => { // routine to edit column // - const editColumnByName = (oldName, newName) => { - // verify if column exists before delete - cy.get(`th:contains(${oldName})`).should("exist"); - - // delete opiton visible on mouse-over - cy.get(`th:contains(${oldName}) .mdi-menu-down`) - .trigger("mouseover") - .click(); - - // edit/ save on pop-up - cy.get(".nc-column-edit").click(); - cy.get(".nc-column-name-input input").clear().type(newName); - cy.get(".nc-col-create-or-edit-card").contains("Save").click(); - - cy.toastWait("Successfully updated alias"); - - // validate if deleted (column shouldnt exist) - cy.get(`th:contains(${oldName})`).should("not.exist"); - cy.get(`th:contains(${newName})`).should("exist"); - }; + // const editColumnByName = (oldName, newName) => { + // // verify if column exists before delete + // cy.get(`th:contains(${oldName})`).should("exist"); + // + // // delete opiton visible on mouse-over + // cy.get(`th:contains(${oldName}) .mdi-menu-down`) + // .trigger("mouseover") + // .click(); + // + // // edit/ save on pop-up + // cy.get(".nc-column-edit").click(); + // cy.get(".nc-column-name-input input").clear().type(newName); + // cy.get(".nc-col-create-or-edit-card").contains("Save").click(); + // + // cy.toastWait("Successfully updated alias"); + // + // // validate if deleted (column shouldnt exist) + // cy.get(`th:contains(${oldName})`).should("not.exist"); + // cy.get(`th:contains(${newName})`).should("exist"); + // }; /////////////////////////////////////////////////// // Test case @@ -134,7 +156,7 @@ export const genTest = (apiType, dbType) => { .contains("2") .should("exist"); - editColumnByName("RollUpCol_1", "RollUpCol_New"); + // editColumnByName("RollUpCol_1", "RollUpCol_New"); deleteColumnByName("RollUpCol_New"); }); }); diff --git a/scripts/cypress/integration/common/3e_duration_column.js b/scripts/cypress/integration/common/3e_duration_column.js index 7aae994389..ce1a4d327d 100644 --- a/scripts/cypress/integration/common/3e_duration_column.js +++ b/scripts/cypress/integration/common/3e_duration_column.js @@ -44,18 +44,34 @@ export const genTest = (apiType, dbType) => { force: true, }); - cy.getActiveMenu(".nc-dropdown-grid-add-column").find('input.nc-column-name-input', { timeout: 3000 }) + cy.getActiveMenu(".nc-dropdown-grid-add-column") + .find('input.nc-column-name-input', { timeout: 3000 }) .should('exist') .clear() .type(columnName); - cy.get(".nc-column-type-input").last().click().type("Duration"); - cy.getActiveSelection('.nc-dropdown-column-type').find('.ant-select-item-option').contains("Duration").click(); + // cy.get(".nc-column-type-input").last().click().type("Duration"); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".nc-column-type-input") + .last() + .click() + .type("Duration") + cy.getActiveSelection('.nc-dropdown-column-type') + .find('.ant-select-item-option') + .contains("Duration") + .click(); // Configure Duration format fetchParentFromLabel("Duration Format"); - cy.getActiveSelection('.nc-dropdown-duration-option').find('.ant-select-item-option').contains(durationFormat).click(); - - cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveSelection('.nc-dropdown-duration-option') + .find('.ant-select-item-option') + .contains(durationFormat) + .click(); + + // cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); cy.toastWait(`Column created`); cy.get(`th[data-title="${columnName}"]`).should("exist"); @@ -75,19 +91,30 @@ export const genTest = (apiType, dbType) => { .trigger("mouseover", { force: true }) .click({ force: true }); - cy.get(".nc-column-edit").click(); - cy.get(".nc-column-edit").should("not.be.visible"); + // cy.get(".nc-column-edit").click(); + // cy.get(".nc-column-edit").should("not.be.visible"); + cy.getActiveMenu(".nc-dropdown-column-operations") + .find(".nc-column-edit") + .click(); // rename column and verify - cy.getActiveMenu(".nc-dropdown-column-operations").find('input.nc-column-name-input', { timeout: 3000 }) + cy.getActiveMenu(".nc-dropdown-edit-column") + .find('input.nc-column-name-input', { timeout: 3000 }) .should('exist') .clear() .type(newName); // Configure Duration format fetchParentFromLabel("Duration Format"); - cy.getActiveSelection('.nc-dropdown-duration-option').find('.ant-select-item-option').contains(newDurationFormat).click(); - - cy.get(".ant-btn-primary:visible").contains("Save").click(); + cy.getActiveSelection('.nc-dropdown-duration-option') + .find('.ant-select-item-option') + .contains(newDurationFormat) + .click(); + + // cy.get(".ant-btn-primary:visible").contains("Save").click(); + cy.getActiveMenu('.nc-dropdown-edit-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); cy.toastWait("Column updated"); diff --git a/scripts/cypress/integration/common/3f_link_to_another_record.js b/scripts/cypress/integration/common/3f_link_to_another_record.js index dc25b2c8e2..0a8ed1f7a1 100644 --- a/scripts/cypress/integration/common/3f_link_to_another_record.js +++ b/scripts/cypress/integration/common/3f_link_to_another_record.js @@ -37,12 +37,18 @@ export const genTest = (apiType, dbType) => { .type(columnName); // Column type - cy.get(".nc-column-type-input").last() + // cy.get(".nc-column-type-input").last() + // .click() + // .type("Link"); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".nc-column-type-input") + .last() .click() - .type("Link"); + .type("Link") cy.getActiveSelection('.nc-dropdown-column-type') .find('.ant-select-item-option') - .contains("LinkToAnotherRecord").click(); + .contains("LinkToAnotherRecord") + .click(); // relation type (hm/ mm) cy.get('.nc-ltar-relation-type') @@ -62,9 +68,13 @@ export const genTest = (apiType, dbType) => { .click(); // Save - cy.get(".ant-btn-primary") + // cy.get(".ant-btn-primary") + // .contains("Save") + // .should('exist') + // .click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".ant-btn-primary:visible") .contains("Save") - .should('exist') .click(); // Toast diff --git a/scripts/cypress/support/commands.js b/scripts/cypress/support/commands.js index db8493087f..ee7ba6bb35 100644 --- a/scripts/cypress/support/commands.js +++ b/scripts/cypress/support/commands.js @@ -352,26 +352,26 @@ Cypress.Commands.add('renameTable', (oldName, newName) => { }); -Cypress.Commands.add('createColumn', (table, columnName) => { - cy.get('.nc-project-tree') - .find('.v-list-item__title:contains(Tables)') - .should('exist') - .first() - .click(); - cy.get('.nc-project-tree') - .contains(table) - .should('exist') - .first() - .click({ force: true }); - cy.get(`.project-tab:contains(${table}):visible`).should('exist'); - cy.get('.v-window-item--active .nc-grid tr > th:last button').click({ - force: true, - }); - cy.get('.nc-column-name-input input').clear().type(columnName); - cy.getActiveMenu('Menu_CreateColumn'); - cy.get('.nc-col-create-or-edit-card').contains('Save').click(); - cy.get('th:contains(new_column)').should('exist'); -}); +// Cypress.Commands.add('createColumn', (table, columnName) => { +// cy.get('.nc-project-tree') +// .find('.v-list-item__title:contains(Tables)') +// .should('exist') +// .first() +// .click(); +// cy.get('.nc-project-tree') +// .contains(table) +// .should('exist') +// .first() +// .click({ force: true }); +// cy.get(`.project-tab:contains(${table}):visible`).should('exist'); +// cy.get('.v-window-item--active .nc-grid tr > th:last button').click({ +// force: true, +// }); +// cy.get('.nc-column-name-input input').clear().type(columnName); +// cy.getActiveMenu('Menu_CreateColumn'); +// cy.get('.nc-col-create-or-edit-card').contains('Save').click(); +// cy.get('th:contains(new_column)').should('exist'); +// }); Cypress.Commands.add('toastWait', (msg) => { cy.get('.ant-message-notice-content:visible', { timeout: 60000 }).contains(msg).should('exist'); diff --git a/scripts/cypress/support/page_objects/mainPage.js b/scripts/cypress/support/page_objects/mainPage.js index 1771009ab8..8be004e673 100644 --- a/scripts/cypress/support/page_objects/mainPage.js +++ b/scripts/cypress/support/page_objects/mainPage.js @@ -183,11 +183,13 @@ export class _mainPage { force: true, }); - cy.getActiveMenu(".nc-dropdown-grid-add-column").find('input.nc-column-name-input', { timeout: 3000 }) + cy.getActiveMenu(".nc-dropdown-grid-add-column") + .find('input.nc-column-name-input') .should('exist') .clear() .type(colName); - cy.get(".ant-btn-primary").contains("Save").should('exist').click(); + cy.getActiveMenu(".nc-dropdown-grid-add-column") + .find(".ant-btn-primary").contains("Save").should('exist').click(); cy.toastWait(`Column created`); cy.get(`th[data-title="${colName}"]`).should("exist"); }; @@ -197,15 +199,24 @@ export class _mainPage { force: true, }); - cy.getActiveMenu(".nc-dropdown-grid-add-column").find('input.nc-column-name-input', { timeout: 3000 }) + cy.getActiveMenu(".nc-dropdown-grid-add-column") + .find('input.nc-column-name-input') .should('exist') .clear() .type(colName); // change column type and verify - cy.get(".nc-column-type-input").last().click(); + // cy.get(".nc-column-type-input").last().click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".nc-column-type-input") + .last() + .click() cy.getActiveSelection('.nc-dropdown-column-type').find('.ant-select-item-option').contains(colType).click(); - cy.get(".ant-btn-primary:visible").contains("Save").click(); + // cy.get(".ant-btn-primary:visible").contains("Save").click(); + cy.getActiveMenu('.nc-dropdown-grid-add-column') + .find(".ant-btn-primary:visible") + .contains("Save") + .click(); cy.toastWait(`Column created`); cy.get(`th[data-title="${colName}"]`).should("exist"); From bc741d470f0b2e4ed040c8659913fca69c10c762 Mon Sep 17 00:00:00 2001 From: Raju Udava <86527202+dstala@users.noreply.github.com> Date: Mon, 19 Sep 2022 17:03:21 +0530 Subject: [PATCH 4/8] test: typo fix Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com> --- scripts/cypress/integration/common/00_pre_configurations.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/cypress/integration/common/00_pre_configurations.js b/scripts/cypress/integration/common/00_pre_configurations.js index ff5ef09ed0..506a16b7d1 100644 --- a/scripts/cypress/integration/common/00_pre_configurations.js +++ b/scripts/cypress/integration/common/00_pre_configurations.js @@ -164,7 +164,7 @@ export const genTest = (apiType, dbType) => { it("Admin SignUp", () => { cy.task("log", "This will be output to the terminal"); - loginPage.signIn(roles.owner.credentials); + loginPage.signUp(roles.owner.credentials); }); function cy_createProjectBlock(proj, apiType, dbType) { From 2bcd632777b8602dd2ae41d0b9fc31b4fce9e6d3 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Mon, 19 Sep 2022 20:08:28 +0530 Subject: [PATCH 5/8] fix(gui): use index as key to avoid re-rendering Signed-off-by: Pranav C --- packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue b/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue index 3a845b81d0..fed47eef44 100644 --- a/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue +++ b/packages/nc-gui/components/smartsheet-toolbar/ColumnFilter.vue @@ -137,7 +137,7 @@ defineExpose({ :class="{ 'shadow min-w-[430px] max-w-[630px] max-h-[max(80vh,500px)] overflow-auto': !nested, 'border-1 w-full': nested }" >
-