From b47ca3cdbb58ad841bfdd1d7f4823b3c7b10fe5d Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Fri, 22 Dec 2023 12:02:34 +0530
Subject: [PATCH 1/2] fix: update dtxs when decimal precision is changing

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../nc-gui/components/smartsheet/column/DecimalOptions.vue  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue b/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue
index 65794cbc78..d7884e26f4 100644
--- a/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue
@@ -30,6 +30,11 @@ onMounted(() => {
     vModel.value.meta.precision = precisionFormats[0]
   }
 })
+
+// update datatype precision when precision is less than the new value
+const onPrecisionChange = (value: number) => {
+  vModel.value.dtxs = vModel.value.dtxs < value ? value : vModel.value.dtxs
+}
 </script>
 
 <template>
@@ -38,6 +43,7 @@ onMounted(() => {
       v-if="vModel.meta?.precision"
       v-model:value="vModel.meta.precision"
       dropdown-class-name="nc-dropdown-decimal-format"
+      @change="onPrecisionChange"
     >
       <a-select-option v-for="(format, i) of precisionFormats" :key="i" :value="format">
         <div class="flex gap-2 w-full justify-between items-center">

From 75b296dbdb44c9054d7a982a5ab443f6f7e6de3a Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Sat, 23 Dec 2023 00:21:16 +0530
Subject: [PATCH 2/2] refactor: suggested changes

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../nc-gui/components/smartsheet/column/DecimalOptions.vue    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue b/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue
index d7884e26f4..bed26bf19c 100644
--- a/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/DecimalOptions.vue
@@ -32,8 +32,10 @@ onMounted(() => {
 })
 
 // update datatype precision when precision is less than the new value
+// avoid downgrading precision if the new value is less than the current precision
+// to avoid fractional part data loss(eg. 1.2345 -> 1.23)
 const onPrecisionChange = (value: number) => {
-  vModel.value.dtxs = vModel.value.dtxs < value ? value : vModel.value.dtxs
+  vModel.value.dtxs = Math.max(value, vModel.value.dtxs)
 }
 </script>