From 86586fd1a9e1382dba80dbad8cb3407ed6baac20 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Tue, 30 Aug 2022 11:57:10 +0530
Subject: [PATCH] refactor(gui-v2): replace pain object with Map

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../nc-gui/components/tabs/Smartsheet.vue     | 36 +++++++++++++------
 packages/nc-gui/composables/useTabs.ts        |  1 +
 2 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/packages/nc-gui/components/tabs/Smartsheet.vue b/packages/nc-gui/components/tabs/Smartsheet.vue
index 75471ef24d..a259d7c966 100644
--- a/packages/nc-gui/components/tabs/Smartsheet.vue
+++ b/packages/nc-gui/components/tabs/Smartsheet.vue
@@ -1,5 +1,8 @@
 <script setup lang="ts">
 import type { ColumnType, TableType, ViewType } from 'nocodb-sdk'
+import type { Ref } from 'vue'
+import { useUIPermission } from '#imports'
+import SmartsheetGrid from '../smartsheet/Grid.vue'
 import {
   ActiveViewInj,
   FieldsInj,
@@ -45,25 +48,38 @@ const reloadViewMetaEventHook = createEventHook()
 
 useProvideKanbanViewStore(meta, activeView)
 
+const { isUIAllowed } = useUIPermission()
 
 /** keep view level state in tabMeta and restore on view change */
 watch(nestedFilters, (newFilters) => {
-  activeTab.value.state = activeTab.value.state || {}
-  activeTab.value.state[activeView.value.id] = activeTab.value.state[activeView.value.id] || {}
-  activeTab.value.state[activeView.value.id].filters = newFilters
+  activeTab.value.state = activeTab.value.state || new Map()
+  if (!activeTab.value.state.has(activeView.value.id)) {
+    activeTab.value.state.set(activeView.value.id, new Map())
+  }
+  activeTab.value.state.get(activeView.value.id)!.set('filters', newFilters)
 })
 
 watch(sorts, (newSorts) => {
-  activeTab.value.state = activeTab.value.state || {}
-  activeTab.value.state[activeView.value.id] = activeTab.value.state[activeView.value.id] || {}
-  activeTab.value.state[activeView.value.id].sorts = newSorts
+  activeTab.value.state = activeTab.value.state || new Map()
+  if (!activeTab.value.state.has(activeView.value.id)) {
+    activeTab.value.state.set(activeView.value.id, new Map())
+  }
+  activeTab.value.state.get(activeView.value.id)!.set('sorts', newSorts)
 })
 
 watch(activeView, (newView: ViewType) => {
-  if (activeTab.value.state?.[newView.id!]?.filters)
-    nestedFilters.value = activeTab.value.state?.[newView.id!]?.filters || []
-  if (activeTab.value.state?.[newView.id!]?.sorts)
-    sorts.value = activeTab.value.state?.[newView.id!]?.sorts || []
+  if(!newView || !activeTab.value?.state?.get(newView.id as string)) return
+
+  if (
+    activeTab.value?.state?.get(newView.id as string)?.has('filters') &&
+    !isUIAllowed('filterSync') &&
+    !isUIAllowed('filterChildrenRead')
+  ) {
+    nestedFilters.value = activeTab.value?.state?.get(newView.id as string)?.get('filters') || []
+  }
+  if (activeTab.value?.state?.get(newView.id as string)?.has('sorts') && !isUIAllowed('sortSync')) {
+    nestedFilters.value = activeTab.value?.state?.get(newView.id as string)?.get('sorts') || []
+  }
 })
 
 // todo: move to store
diff --git a/packages/nc-gui/composables/useTabs.ts b/packages/nc-gui/composables/useTabs.ts
index 88ce60ec42..f41b2afc77 100644
--- a/packages/nc-gui/composables/useTabs.ts
+++ b/packages/nc-gui/composables/useTabs.ts
@@ -38,6 +38,7 @@ const [setup, use] = useInjectionState(() => {
         let index = tabs.value.findIndex((t) => t.id === tab.id)
 
         if (index === -1) {
+          tab.state = tab.state || new Map()
           tabs.value.push(tab)
           index = tabs.value.length - 1
         }