Browse Source

Merge pull request #5833 from nocodb/fix/5812-handle-invalid-rowId

fix: Read api - if record is missing return null
pull/5839/head
Raju Udava 1 year ago committed by GitHub
parent
commit
845a763a2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      packages/nocodb/src/db/BaseModelSqlv2.ts
  2. 2
      packages/nocodb/tests/unit/model/tests/baseModelSql.test.ts

2
packages/nocodb/src/db/BaseModelSqlv2.ts

@ -172,7 +172,7 @@ class BaseModelSqlv2 {
data.__proto__ = proto;
}
return data ? await nocoExecute(ast, data, {}, query) : {};
return data ? await nocoExecute(ast, data, {}, query) : null;
}
public async exist(id?: any): Promise<any> {

2
packages/nocodb/tests/unit/model/tests/baseModelSql.test.ts

@ -282,7 +282,7 @@ function baseModelSqlTests() {
const deletedRow = await baseModelSql.readByPk(rowIdToDeleted);
expect(deletedRow).to.be.an('object').that.is.empty;
expect(deletedRow).to.be.null;
console.log('Delete record', await Audit.projectAuditList(project.id, {}));
const rowDeletedAudit = (await Audit.projectAuditList(project.id, {})).find(

Loading…
Cancel
Save