From e6774e1524766b721eb0de17532dd5b0d683bcb1 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Wed, 26 Jun 2024 11:21:26 +0000
Subject: [PATCH] fix(nc-gui): update roundUpToPrecision function

---
 packages/nc-gui/components/cell/Decimal.vue   |  8 +--
 .../nocodb-sdk/src/lib/helperFunctions.ts     | 60 ++++++++++++-------
 2 files changed, 39 insertions(+), 29 deletions(-)

diff --git a/packages/nc-gui/components/cell/Decimal.vue b/packages/nc-gui/components/cell/Decimal.vue
index 0263273dbd..3dd6cd6e72 100644
--- a/packages/nc-gui/components/cell/Decimal.vue
+++ b/packages/nc-gui/components/cell/Decimal.vue
@@ -1,5 +1,6 @@
 <script lang="ts" setup>
 import type { VNodeRef } from '@vue/runtime-core'
+import { roundUpToPrecision } from 'nocodb-sdk'
 
 interface Props {
   // when we set a number, then it is number type
@@ -35,13 +36,6 @@ const meta = computed(() => {
 
 const _vModel = useVModel(props, 'modelValue', emits)
 
-function roundUpToPrecision(value: number, precision = 1) {
-  const factor = Math.pow(10, precision)
-  const roundedValue = Math.round(value * factor) / factor
-
-  return roundedValue.toFixed(precision)
-}
-
 const displayValue = computed(() => {
   if (_vModel.value === null) return null
 
diff --git a/packages/nocodb-sdk/src/lib/helperFunctions.ts b/packages/nocodb-sdk/src/lib/helperFunctions.ts
index f2fccca71f..c729130cfc 100644
--- a/packages/nocodb-sdk/src/lib/helperFunctions.ts
+++ b/packages/nocodb-sdk/src/lib/helperFunctions.ts
@@ -108,31 +108,46 @@ const getAvailableRollupForUiType = (type: string) => {
   }
 };
 
-const getFileName = ({
-  name,
-  count,
-  ext
-}) => `${name}${count ? `(${count})` : ''}${ext? `${ext}` : ''}`
+const getFileName = ({ name, count, ext }) =>
+  `${name}${count ? `(${count})` : ''}${ext ? `${ext}` : ''}`;
 
 // add count before extension if duplicate name found
-function populateUniqueFileName(
-  fileName: string,
-  attachments: string[]
-) {
-  return fileName.replace(/^(.+?)(?:\((\d+)\))?(\.(?:tar|min)\.(?:\w{2,4})|\.\w+)$/, (fileName,name, count, ext) =>{
-    let genFileName = fileName;
-    let c = count || 1;
-
-    // iterate until a unique name
-    while (attachments.some((fn) => fn === genFileName)) {
-      genFileName = getFileName({
-        name,
-        ext,
-        count: c++
-      });
+function populateUniqueFileName(fileName: string, attachments: string[]) {
+  return fileName.replace(
+    /^(.+?)(?:\((\d+)\))?(\.(?:tar|min)\.(?:\w{2,4})|\.\w+)$/,
+    (fileName, name, count, ext) => {
+      let genFileName = fileName;
+      let c = count || 1;
+
+      // iterate until a unique name
+      while (attachments.some((fn) => fn === genFileName)) {
+        genFileName = getFileName({
+          name,
+          ext,
+          count: c++,
+        });
+      }
+      return genFileName;
     }
-    return genFileName;
-  });
+  );
+}
+
+function roundUpToPrecision(number: number, precision: number = 0) {
+  precision =
+    precision == null
+      ? 0
+      : precision >= 0
+      ? Math.min(precision, 292)
+      : Math.max(precision, -292);
+  if (precision) {
+    // Shift with exponential notation to avoid floating-point issues.
+    // See [MDN](https://mdn.io/round#Examples) for more details.
+    let pair = `${number}e`.split('e');
+    const value = Math.round(Number(`${pair[0]}e${+pair[1] + precision}`));
+    pair = `${value}e`.split('e');
+    return +`${pair[0]}e${+pair[1] - precision}`;
+  }
+  return Math.round(number);
 }
 
 export {
@@ -145,4 +160,5 @@ export {
   stringifyRolesObj,
   getAvailableRollupForUiType,
   populateUniqueFileName,
+  roundUpToPrecision,
 };