From 83ce692f0b690f60d054ad3d0910ce6c88cea7ef Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Wed, 11 Jan 2023 15:58:24 +0800
Subject: [PATCH] fix(workflows): use softprops/action-gh-release@v1 instead

---
 .github/workflows/release-executables.yml | 84 ++++-------------------
 1 file changed, 13 insertions(+), 71 deletions(-)

diff --git a/.github/workflows/release-executables.yml b/.github/workflows/release-executables.yml
index fff82b1e69..3388645b31 100644
--- a/.github/workflows/release-executables.yml
+++ b/.github/workflows/release-executables.yml
@@ -107,46 +107,17 @@ jobs:
           mv ./dist/Noco-macos-arm64 ./mac-dist/
           mv ./dist/Noco-macos-x64 ./mac-dist/
 
-      - name: Upload win-arm64 build to asset
+      - name: Upload executables to asset
         id: upload-release-asset
-        uses: actions/upload-release-asset@v1
+        uses: softprops/action-gh-release@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          upload_url: ${{ steps.get_release.outputs.upload_url }}
-          asset_path: ./scripts/pkg-executable/dist/Noco-win-arm64.exe
-          asset_name: Noco-win-arm64.exe
-          asset_content_type: application/octet-stream
-
-      - name: Upload win-x64 build to asset
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ steps.get_release.outputs.upload_url }}
-          asset_path: ./scripts/pkg-executable/dist/Noco-win-x64.exe
-          asset_name: Noco-win-x64.exe
-          asset_content_type: application/octet-stream
-
-      - name: Upload linux-arm64 build to asset
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ steps.get_release.outputs.upload_url }}
-          asset_path: ./scripts/pkg-executable/dist/Noco-linux-arm64
-          asset_name: Noco-linux-arm64
-          asset_content_type: application/octet-stream
-
-      - name: Upload linux-x64 build to asset
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ steps.get_release.outputs.upload_url }}
-          asset_path: ./scripts/pkg-executable/dist/Noco-linux-x64
-          asset_name: Noco-linux-x64
-          asset_content_type: application/octet-stream
+          files: |
+             ./scripts/pkg-executable/dist/Noco-win-arm64.exe
+             ./scripts/pkg-executable/dist/Noco-win-x64.exe
+             ./scripts/pkg-executable/dist/Noco-linux-arm64
+             ./scripts/pkg-executable/dist/Noco-linux-x64
 
       - uses: actions/upload-artifact@master
         with:
@@ -205,40 +176,15 @@ jobs:
         id: compress
 
 
-      - name: Upload macos-x64 build to asset
-        uses: actions/upload-release-asset@v1
+      - name: Upload macos executable to asset
+        uses: softprops/action-gh-release@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          upload_url: ${{ needs.build-executables.outputs.upload_url }}
-          asset_path: ./scripts/pkg-executable/mac-dist/Noco-macos-x64
-          asset_name: Noco-macos-x64
-          asset_content_type: application/octet-stream
-
-
-
-      - name: Upload macos-arm64 build to asset
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ needs.build-executables.outputs.upload_url }}
-          asset_path: ./scripts/pkg-executable/mac-dist/Noco-macos-arm64
-          asset_name: Noco-macos-arm64
-          asset_content_type: application/octet-stream
-
-
-
-      - name: Upload macos compressed build(for homebrew) to asset
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ needs.build-executables.outputs.upload_url }}
-          asset_path: ./scripts/pkg-executable/mac-dist/nocodb.tar.gz
-          asset_name: nocodb.tar.gz
-          asset_content_type: application/octet-stream
-
+          files: |
+            ./scripts/pkg-executable/mac-dist/Noco-macos-x64
+            ./scripts/pkg-executable/mac-dist/Noco-macos-arm64
+            ./scripts/pkg-executable/mac-dist/nocodb.tar.gz
 
       - name: Generate Homebrew Formula class and push
         run: |
@@ -267,7 +213,3 @@ jobs:
 
           git commit ./Formula/nocodb.rb -m "Automatic publish"
           git push
-
-
-
-