From c777463ac36a3a17f3af126bec1765caa44e014a Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Thu, 8 Sep 2022 12:39:48 +0200 Subject: [PATCH 01/52] chore(nc-gui): remove unnecessary margin --- packages/nc-gui/pages/signup/[[token]].vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nc-gui/pages/signup/[[token]].vue b/packages/nc-gui/pages/signup/[[token]].vue index 5693552c3a..6b732355d8 100644 --- a/packages/nc-gui/pages/signup/[[token]].vue +++ b/packages/nc-gui/pages/signup/[[token]].vue @@ -113,7 +113,7 @@ function resetError() { {{ $route.query.redirect_to === '/pricing' ? '& BUY' : '' }} -

+

{{ $t('msg.info.signUp.superAdmin') }}

From 20eef38acb0284ddfe818f619de9e80608538bdc Mon Sep 17 00:00:00 2001 From: Pranav C Date: Fri, 9 Sep 2022 12:00:09 +0530 Subject: [PATCH 02/52] chore(swagger): provide required as an array Signed-off-by: Pranav C --- scripts/sdk/swagger.json | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/scripts/sdk/swagger.json b/scripts/sdk/swagger.json index 5e8b6b1f02..d484f4d2be 100644 --- a/scripts/sdk/swagger.json +++ b/scripts/sdk/swagger.json @@ -5821,9 +5821,6 @@ "pageInfo": { "$ref": "#/components/schemas/Paginated" } - }, - "": { - "type": "string" } }, "Base": { @@ -6148,8 +6145,7 @@ "type": "string" }, "title": { - "type": "string", - "required": true + "type": "string" }, "deleted": { "type": "boolean" @@ -6193,7 +6189,8 @@ } ] } - } + }, + "required": ["title"] }, "TableInfo": { "title": "Table", @@ -6981,10 +6978,12 @@ "properties": { "options": { "type": "array", - "required": true, "$ref": "#/components/schemas/SelectOption" } }, + "required": [ + "options" + ], "examples": [ { "options": [ From 93840ab1e302ff59de4dcd40dc18c984b4d4a8e5 Mon Sep 17 00:00:00 2001 From: Raju Udava <86527202+dstala@users.noreply.github.com> Date: Fri, 9 Sep 2022 13:23:38 +0530 Subject: [PATCH 03/52] fix: duplicate entry in rollup function table Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com> --- packages/nc-gui/components/smartsheet-column/RollupOptions.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/nc-gui/components/smartsheet-column/RollupOptions.vue b/packages/nc-gui/components/smartsheet-column/RollupOptions.vue index f048f0176d..ebfe0cb776 100644 --- a/packages/nc-gui/components/smartsheet-column/RollupOptions.vue +++ b/packages/nc-gui/components/smartsheet-column/RollupOptions.vue @@ -35,7 +35,6 @@ const aggrFunctionsList = [ { text: 'min', value: 'min' }, { text: 'max', value: 'max' }, { text: 'avg', value: 'avg' }, - { text: 'min', value: 'min' }, { text: 'sum', value: 'sum' }, { text: 'countDistinct', value: 'countDistinct' }, { text: 'sumDistinct', value: 'sumDistinct' }, From 6769439f0e230afda13bab6cdd68f2d72bfdd90d Mon Sep 17 00:00:00 2001 From: Raju Udava <86527202+dstala@users.noreply.github.com> Date: Fri, 9 Sep 2022 15:43:18 +0530 Subject: [PATCH 04/52] refactor: display text correction for collab/locked view menu Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com> --- packages/nc-gui/components/smartsheet-toolbar/LockType.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/nc-gui/components/smartsheet-toolbar/LockType.vue b/packages/nc-gui/components/smartsheet-toolbar/LockType.vue index b34b580cce..947606bfed 100644 --- a/packages/nc-gui/components/smartsheet-toolbar/LockType.vue +++ b/packages/nc-gui/components/smartsheet-toolbar/LockType.vue @@ -13,17 +13,17 @@ const types = { [LockType.Personal]: { title: 'title.personalView', icon: MdiAccountIcon, - subtitle: 'msg.info.collabView', + subtitle: 'msg.info.personalView', }, [LockType.Collaborative]: { title: 'title.collabView', icon: MdiAccountGroupIcon, - subtitle: 'msg.info.lockedView', + subtitle: 'msg.info.collabView', }, [LockType.Locked]: { title: 'title.lockedView', icon: MdiLockOutlineIcon, - subtitle: 'msg.info.personalView', + subtitle: 'msg.info.lockedView', }, } From c1c5ab9d2bdc553a16a89b47db78b91f3a7fef6c Mon Sep 17 00:00:00 2001 From: Pranav C Date: Fri, 9 Sep 2022 17:01:57 +0530 Subject: [PATCH 05/52] fix(gui): after save maintain the relation data in expanded-form re #3566 Signed-off-by: Pranav C --- .../smartsheet/expanded-form/Header.vue | 5 ++-- .../smartsheet/expanded-form/index.vue | 25 +++---------------- .../composables/useExpandedFormStore.ts | 17 +++++++++++++ 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/packages/nc-gui/components/smartsheet/expanded-form/Header.vue b/packages/nc-gui/components/smartsheet/expanded-form/Header.vue index b215fd4a47..0ef3fe57b0 100644 --- a/packages/nc-gui/components/smartsheet/expanded-form/Header.vue +++ b/packages/nc-gui/components/smartsheet/expanded-form/Header.vue @@ -5,7 +5,7 @@ const emit = defineEmits(['cancel']) const { meta, isSqlView } = useSmartsheetStoreOrThrow() -const { commentsDrawer, primaryValue, save: _save } = useExpandedFormStoreOrThrow() +const { commentsDrawer, primaryValue, save: _save, loadRow } = useExpandedFormStoreOrThrow() const { isNew, syncLTARRefs } = useSmartsheetRowStoreOrThrow() @@ -15,6 +15,7 @@ const save = async () => { if (isNew.value) { const data = await _save() await syncLTARRefs(data) + await loadRow() } else { await _save() } @@ -46,7 +47,7 @@ const iconColor = '#1890ff' - + diff --git a/packages/nc-gui/components/smartsheet/expanded-form/index.vue b/packages/nc-gui/components/smartsheet/expanded-form/index.vue index be6aba144d..7badc55815 100644 --- a/packages/nc-gui/components/smartsheet/expanded-form/index.vue +++ b/packages/nc-gui/components/smartsheet/expanded-form/index.vue @@ -1,5 +1,5 @@