Browse Source

Merge pull request #6550 from nocodb/nc-test/fix-header

fix: drop overlapping tooltip
pull/6375/head
mertmit 1 year ago committed by GitHub
parent
commit
80af6fc1e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      packages/nc-gui/components/smartsheet/header/Cell.vue
  2. 2
      packages/nc-gui/components/smartsheet/header/VirtualCell.vue
  3. 4
      tests/playwright/pages/Dashboard/Grid/index.ts

2
packages/nc-gui/components/smartsheet/header/Cell.vue

@ -75,7 +75,7 @@ const openDropDown = () => {
v-if="column" v-if="column"
class="name pl-1" class="name pl-1"
:class="{ 'cursor-pointer pt-0.25': !isForm && isUIAllowed('fieldEdit') && !hideMenu }" :class="{ 'cursor-pointer pt-0.25': !isForm && isUIAllowed('fieldEdit') && !hideMenu }"
:title="column.title" :data-test-id="column.title"
> >
{{ column.title }} {{ column.title }}
</div> </div>

2
packages/nc-gui/components/smartsheet/header/VirtualCell.vue

@ -137,7 +137,7 @@ const closeAddColumnDropdown = () => {
<span <span
class="name pl-1" class="name pl-1"
:class="{ 'truncate': !isForm || !isExpandedForm, 'whitespace-pre-line': isForm || isExpandedForm }" :class="{ 'truncate': !isForm || !isExpandedForm, 'whitespace-pre-line': isForm || isExpandedForm }"
:title="column.title" :data-test-id="column.title"
> >
{{ column.title }} {{ column.title }}
</span> </span>

4
tests/playwright/pages/Dashboard/Grid/index.ts

@ -129,7 +129,7 @@ export class GridPage extends BasePage {
await this._fillRow({ index, columnHeader, value: rowValue }); await this._fillRow({ index, columnHeader, value: rowValue });
const clickOnColumnHeaderToSave = () => const clickOnColumnHeaderToSave = () =>
this.get().locator(`[data-title="${columnHeader}"]`).locator(`div[title="${columnHeader}"]`).click(); this.get().locator(`[data-title="${columnHeader}"]`).locator(`div[data-test-id="${columnHeader}"]`).click();
if (networkValidation) { if (networkValidation) {
await this.waitForResponse({ await this.waitForResponse({
@ -161,7 +161,7 @@ export class GridPage extends BasePage {
await this._fillRow({ index, columnHeader, value }); await this._fillRow({ index, columnHeader, value });
const clickOnColumnHeaderToSave = () => const clickOnColumnHeaderToSave = () =>
this.get().locator(`[data-title="${columnHeader}"]`).locator(`div[title="${columnHeader}"]`).click(); this.get().locator(`[data-title="${columnHeader}"]`).locator(`div[data-test-id="${columnHeader}"]`).click();
if (networkValidation) { if (networkValidation) {
await this.waitForResponse({ await this.waitForResponse({

Loading…
Cancel
Save