From 7e35eedae997b8c2d03ff9866857c52fd5943bc8 Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Wed, 8 Nov 2023 10:17:32 +0000
Subject: [PATCH] fix: Added tooltip for open in new tab and copy iframe btn in
 share modal

---
 .../nc-gui/components/general/CopyUrl.vue     | 35 ++++++++++++-------
 packages/nc-gui/lang/en.json                  |  2 ++
 2 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/packages/nc-gui/components/general/CopyUrl.vue b/packages/nc-gui/components/general/CopyUrl.vue
index 43d516a4db..dace5df465 100644
--- a/packages/nc-gui/components/general/CopyUrl.vue
+++ b/packages/nc-gui/components/general/CopyUrl.vue
@@ -40,18 +40,29 @@ const copyUrl = async () => {
       <div class="overflow-hidden whitespace-nowrap text-gray-500">{{ url }}</div>
     </div>
     <div class="flex flex-row gap-x-1">
-      <div class="button" @click="openUrl">
-        <RiExternalLinkLine class="h-3.75" />
-      </div>
-      <div
-        class="button"
-        :class="{
-          '!text-gray-300 !border-gray-200 !cursor-not-allowed': isCopied.embed,
-        }"
-        @click="embedHtml"
-      >
-        <MdiCodeTags class="h-4" />
-      </div>
+      <NcTooltip>
+        <template #title>
+          {{ $t('activity.openInANewTab') }}
+        </template>
+
+        <div class="button" @click="openUrl">
+          <RiExternalLinkLine class="h-3.75" />
+        </div>
+      </NcTooltip>
+      <NcTooltip>
+        <template #title>
+          {{ $t('activity.copyIFrameCode') }}
+        </template>
+        <div
+          class="button"
+          :class="{
+            '!text-gray-300 !border-gray-200 !cursor-not-allowed': isCopied.embed,
+          }"
+          @click="embedHtml"
+        >
+          <MdiCodeTags class="h-4" />
+        </div>
+      </NcTooltip>
       <div class="button" data-testid="docs-share-page-copy-link" @click="copyUrl">
         <MdiCheck v-if="isCopied.link" class="h-3.5" />
         <MdiContentCopy v-else class="h-3.5" />
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 5e82f7cc51..0d3eaffe40 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -620,6 +620,8 @@
     "newFormLoaded": "New form will be loaded after"
   },
   "activity": {
+    "openInANewTab": "Open in a new tab",
+    "copyIFrameCode": "Copy IFrame code",
     "onCondition": "On Condition",
     "bulkDownload": "Bulk Download",
     "attachFile": "Attach File",