Browse Source

fix(nocodb): comment update not working for other users (#7873)

pull/7875/head
Anbarasu 8 months ago committed by GitHub
parent
commit
7dbd824a15
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 11
      packages/nocodb/src/middlewares/extract-ids/extract-ids.middleware.ts
  2. 2
      packages/nocodb/src/utils/acl.ts

11
packages/nocodb/src/middlewares/extract-ids/extract-ids.middleware.ts

@ -11,6 +11,7 @@ import type {
NestMiddleware, NestMiddleware,
} from '@nestjs/common'; } from '@nestjs/common';
import { import {
Audit,
Base, Base,
Column, Column,
Filter, Filter,
@ -159,6 +160,16 @@ export class ExtractIdsMiddleware implements NestMiddleware, CanActivate {
id: req.query?.fk_model_id, id: req.query?.fk_model_id,
}); });
req.ncBaseId = model?.base_id; req.ncBaseId = model?.base_id;
} else if (
[
'/api/v1/db/meta/audits/:auditId/comment',
'/api/v2/meta/audits/:auditId/comment',
].some((auditPatchPath) => req.route.path === auditPatchPath) &&
req.method === 'PATCH' &&
req.params.auditId
) {
const audit = await Audit.get(params.auditId);
req.ncBaseId = audit?.base_id;
} }
// extract base id from query params only if it's userMe endpoint or webhook plugin list // extract base id from query params only if it's userMe endpoint or webhook plugin list
else if ( else if (

2
packages/nocodb/src/utils/acl.ts

@ -92,6 +92,7 @@ const permissionScopes = {
'swaggerJson', 'swaggerJson',
'commentList', 'commentList',
'commentsCount', 'commentsCount',
'commentUpdate',
'hideAllColumns', 'hideAllColumns',
'showAllColumns', 'showAllColumns',
'auditRowUpdate', 'auditRowUpdate',
@ -197,6 +198,7 @@ const rolePermissions:
commentList: true, commentList: true,
commentsCount: true, commentsCount: true,
commentRow: true, commentRow: true,
commentUpdate: true,
}, },
}, },
[ProjectRoles.EDITOR]: { [ProjectRoles.EDITOR]: {

Loading…
Cancel
Save