From 7a8d89b3d754f9f0b0806e90a87058cdf383745e Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Wed, 10 Aug 2022 01:18:28 +0530
Subject: [PATCH] refactor(gui-v2): code cleanup

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 packages/nc-gui-v2/components.d.ts                       | 2 ++
 packages/nc-gui-v2/components/dashboard/TreeView.vue     | 4 +++-
 packages/nc-gui-v2/components/dlg/TableCreate.vue        | 9 ---------
 packages/nc-gui-v2/components/dlg/TableRename.vue        | 2 --
 packages/nc-gui-v2/components/general/MiniSidebar.vue    | 4 ----
 .../components/smartsheet-toolbar/MoreActions.vue        | 5 -----
 .../components/smartsheet-toolbar/SharedViewList.vue     | 5 -----
 packages/nc-gui-v2/components/smartsheet/Cell.vue        | 4 ----
 packages/nc-gui-v2/components/smartsheet/Gallery.vue     | 3 ---
 packages/nc-gui-v2/components/smartsheet/Grid.vue        | 4 ++--
 packages/nc-gui-v2/components/webhook/Test.vue           | 2 +-
 packages/nc-gui-v2/composables/useColumnCreateStore.ts   | 2 +-
 packages/nc-gui-v2/layouts/base.vue                      | 4 ----
 13 files changed, 9 insertions(+), 41 deletions(-)

diff --git a/packages/nc-gui-v2/components.d.ts b/packages/nc-gui-v2/components.d.ts
index 8706c282ff..e41983c665 100644
--- a/packages/nc-gui-v2/components.d.ts
+++ b/packages/nc-gui-v2/components.d.ts
@@ -91,6 +91,7 @@ declare module '@vue/runtime-core' {
     MdiDatabase: typeof import('~icons/mdi/database')['default']
     MdiDeleteOutline: typeof import('~icons/mdi/delete-outline')['default']
     MdiDiscord: typeof import('~icons/mdi/discord')['default']
+    MdiDotsHorizontal: typeof import('~icons/mdi/dots-horizontal')['default']
     MdiDotsVertical: typeof import('~icons/mdi/dots-vertical')['default']
     MdiDownload: typeof import('~icons/mdi/download')['default']
     MdiDrag: typeof import('~icons/mdi/drag')['default']
@@ -115,6 +116,7 @@ declare module '@vue/runtime-core' {
     MdiPlus: typeof import('~icons/mdi/plus')['default']
     MdiPlusOutline: typeof import('~icons/mdi/plus-outline')['default']
     MdiReload: typeof import('~icons/mdi/reload')['default']
+    MdiSearch: typeof import('~icons/mdi/search')['default']
     MdiShieldLockOutline: typeof import('~icons/mdi/shield-lock-outline')['default']
     MdiSlack: typeof import('~icons/mdi/slack')['default']
     MdiStar: typeof import('~icons/mdi/star')['default']
diff --git a/packages/nc-gui-v2/components/dashboard/TreeView.vue b/packages/nc-gui-v2/components/dashboard/TreeView.vue
index 3b1c67522b..5723611ff5 100644
--- a/packages/nc-gui-v2/components/dashboard/TreeView.vue
+++ b/packages/nc-gui-v2/components/dashboard/TreeView.vue
@@ -31,8 +31,10 @@ const tablesById = $computed<Record<string, TableType>>(() =>
 
 const showTableList = ref(true)
 const tableCreateDlg = ref(false)
-const menuRef = $ref<HTMLLIElement>()
 let key = $ref(0)
+
+const menuRef = $ref<HTMLLIElement>()
+
 let sortable: Sortable
 
 // todo: replace with vuedraggable
diff --git a/packages/nc-gui-v2/components/dlg/TableCreate.vue b/packages/nc-gui-v2/components/dlg/TableCreate.vue
index 7fd815f2ce..596eb44adc 100644
--- a/packages/nc-gui-v2/components/dlg/TableCreate.vue
+++ b/packages/nc-gui-v2/components/dlg/TableCreate.vue
@@ -31,18 +31,9 @@ const { table, createTable, generateUniqueTitle, tables, project } = useTable(as
   dialogShow.value = false
 })
 
-// const prefix = computed(() => project?.value?.prefix || '')
-
 const validateDuplicateAlias = (v: string) => {
   return (tables?.value || []).every((t) => t.title !== (v || '')) || 'Duplicate table alias'
 }
-// const validateLeadingOrTrailingWhiteSpace = (v: string) => {
-//   return !/^\s+|\s+$/.test(v) || 'Leading or trailing whitespace not allowed in table name'
-// }
-// const validateDuplicate = (v: string) => {
-//   return (tables?.value || []).every((t) => t.table_name.toLowerCase() !== (v || '').toLowerCase()) || 'Duplicate table name'
-// }
-
 const inputEl = ref<HTMLInputElement>()
 
 const useForm = Form.useForm
diff --git a/packages/nc-gui-v2/components/dlg/TableRename.vue b/packages/nc-gui-v2/components/dlg/TableRename.vue
index 1e4fffac4f..bf4c35fa83 100644
--- a/packages/nc-gui-v2/components/dlg/TableRename.vue
+++ b/packages/nc-gui-v2/components/dlg/TableRename.vue
@@ -30,8 +30,6 @@ const { updateTab } = useTabs()
 const { loadTables } = useProject()
 const { tables } = useProject()
 
-// const prefix = computed(() => project?.value?.prefix || '')
-
 const inputEl = $ref<any>()
 let loading = $ref(false)
 const useForm = Form.useForm
diff --git a/packages/nc-gui-v2/components/general/MiniSidebar.vue b/packages/nc-gui-v2/components/general/MiniSidebar.vue
index 2fdfa98a5b..48cd9416c5 100644
--- a/packages/nc-gui-v2/components/general/MiniSidebar.vue
+++ b/packages/nc-gui-v2/components/general/MiniSidebar.vue
@@ -1,11 +1,7 @@
 <script lang="ts" setup>
-// import { breakpointsTailwind } from '@vueuse/core'
 import { navigateTo } from '#app'
 import { computed, useGlobal, useProject, useRoute, useSidebar } from '#imports'
 
-/** get current breakpoints (for enabling sidebar) */
-// const breakpoints = useBreakpoints(breakpointsTailwind)
-
 const { signOut, signedIn, user } = useGlobal()
 
 const { isOpen } = useSidebar({ isOpen: true })
diff --git a/packages/nc-gui-v2/components/smartsheet-toolbar/MoreActions.vue b/packages/nc-gui-v2/components/smartsheet-toolbar/MoreActions.vue
index 967b067295..cd988a65fb 100644
--- a/packages/nc-gui-v2/components/smartsheet-toolbar/MoreActions.vue
+++ b/packages/nc-gui-v2/components/smartsheet-toolbar/MoreActions.vue
@@ -18,11 +18,6 @@ const sharedViewListDlg = ref(false)
 // todo : replace with inject
 const publicViewId = null
 
-// // TODO:: identify based on meta
-// const isView = ref(false)
-//
-// const { isUIAllowed } = useUIPermission()
-
 const { project } = useProject()
 
 const { $api } = useNuxtApp()
diff --git a/packages/nc-gui-v2/components/smartsheet-toolbar/SharedViewList.vue b/packages/nc-gui-v2/components/smartsheet-toolbar/SharedViewList.vue
index 6d350ba68b..9156919d1f 100644
--- a/packages/nc-gui-v2/components/smartsheet-toolbar/SharedViewList.vue
+++ b/packages/nc-gui-v2/components/smartsheet-toolbar/SharedViewList.vue
@@ -24,12 +24,9 @@ const { copy } = useClipboard()
 const toast = useToast()
 const { dashboardUrl } = useDashboard()
 
-// let isLoading = $ref(false)
-// let activeSharedView = $ref(null)
 const sharedViewList = ref<SharedViewType[]>()
 
 const loadSharedViewsList = async () => {
-  // isLoading = true
   const list = await $api.dbViewShare.list(meta.value?.id as string)
 
   console.log(unref(sharedViewList))
@@ -47,8 +44,6 @@ const loadSharedViewsList = async () => {
   // } else {
   //   activeSharedView = null
   // }
-
-  // isLoading = false
 }
 
 onMounted(loadSharedViewsList)
diff --git a/packages/nc-gui-v2/components/smartsheet/Cell.vue b/packages/nc-gui-v2/components/smartsheet/Cell.vue
index bba80bba88..1769cdd9c4 100644
--- a/packages/nc-gui-v2/components/smartsheet/Cell.vue
+++ b/packages/nc-gui-v2/components/smartsheet/Cell.vue
@@ -12,10 +12,6 @@ interface Props {
   editEnabled: boolean
 }
 
-// interface Emits {
-//   (event: 'update:modelValue', value: any): void
-// }
-
 const props = defineProps<Props>()
 const emit = defineEmits(['update:modelValue', 'save', 'navigate', 'update:editEnabled'])
 const column = toRef(props, 'column')
diff --git a/packages/nc-gui-v2/components/smartsheet/Gallery.vue b/packages/nc-gui-v2/components/smartsheet/Gallery.vue
index 11ea16cf53..21cd416d98 100644
--- a/packages/nc-gui-v2/components/smartsheet/Gallery.vue
+++ b/packages/nc-gui-v2/components/smartsheet/Gallery.vue
@@ -11,9 +11,6 @@ interface Attachment {
 const meta = inject(MetaInj)
 const view = inject(ActiveViewInj)
 
-// todo: get from parent ( inject or use prop )
-// const isPublicView = false
-
 const { loadData, paginationData, formattedData: data, loadGalleryData, galleryData, changePage } = useViewData(meta, view as any)
 
 provide(IsFormInj, false)
diff --git a/packages/nc-gui-v2/components/smartsheet/Grid.vue b/packages/nc-gui-v2/components/smartsheet/Grid.vue
index 599cb4312a..61f5b4c911 100644
--- a/packages/nc-gui-v2/components/smartsheet/Grid.vue
+++ b/packages/nc-gui-v2/components/smartsheet/Grid.vue
@@ -379,8 +379,8 @@ const onNavigate = (dir: NavigateDir) => {
             >
             <a-menu-item @click="deleteSelectedRows"><span class="text-xs">Delete all selected rows</span></a-menu-item>
             <a-menu-item v-if="contextMenuTarget" @click="clearCell(contextMenuTarget)"
-              ><span class="text-xs">Clear cell</span></a-menu-item
-            >
+              ><span class="text-xs">Clear cell</span>
+            </a-menu-item>
             <a-menu-item v-if="contextMenuTarget" @click="addEmptyRow(contextMenuTarget.row + 1)">
               <span class="text-xs">Insert new row</span>
             </a-menu-item>
diff --git a/packages/nc-gui-v2/components/webhook/Test.vue b/packages/nc-gui-v2/components/webhook/Test.vue
index 06ca930d0b..501d4c4480 100644
--- a/packages/nc-gui-v2/components/webhook/Test.vue
+++ b/packages/nc-gui-v2/components/webhook/Test.vue
@@ -23,7 +23,7 @@ const activeKey = ref(0)
 
 watch(
   () => hook?.operation,
-  async (_v) => {
+  async () => {
     await loadSampleData()
   },
 )
diff --git a/packages/nc-gui-v2/composables/useColumnCreateStore.ts b/packages/nc-gui-v2/composables/useColumnCreateStore.ts
index 2ede66d9ba..2a99849b50 100644
--- a/packages/nc-gui-v2/composables/useColumnCreateStore.ts
+++ b/packages/nc-gui-v2/composables/useColumnCreateStore.ts
@@ -198,7 +198,7 @@ const [useProvideColumnCreateStore, useColumnCreateStore] = createInjectionState
 
           /** if LTAR column then force reload related table meta */
           if (formState.value.uidt === UITypes.LinkToAnotherRecord && meta.value.id !== formState.value.childId) {
-            getMeta(formState.value.childId, true)
+            getMeta(formState.value.childId, true).then(() => {})
           }
 
           toast.success('Column created')
diff --git a/packages/nc-gui-v2/layouts/base.vue b/packages/nc-gui-v2/layouts/base.vue
index d9918be88f..72d3aee78a 100644
--- a/packages/nc-gui-v2/layouts/base.vue
+++ b/packages/nc-gui-v2/layouts/base.vue
@@ -1,11 +1,7 @@
 <script lang="ts" setup>
-// import { breakpointsTailwind } from '@vueuse/core'
 import { navigateTo } from '#app'
 import { computed, useGlobal, useRoute } from '#imports'
 
-/** get current breakpoints (for enabling sidebar) */
-// const breakpoints = useBreakpoints(breakpointsTailwind)
-
 const { signOut, signedIn, isLoading, user } = useGlobal()
 
 const route = useRoute()