From 7a5a34c0b8229fef3edc8ab42c528fd757e20a8f Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Thu, 8 Jun 2023 18:56:56 +0300
Subject: [PATCH] refactor: function name for bulk update

Signed-off-by: mertmit <mertmit99@gmail.com>
---
 packages/nc-gui/components/smartsheet/Grid.vue      | 4 ++--
 packages/nc-gui/composables/useMultiSelect/index.ts | 6 +++---
 packages/nc-gui/composables/useViewData.ts          | 8 ++++----
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/Grid.vue b/packages/nc-gui/components/smartsheet/Grid.vue
index c0f7d6c2c9..15d6d3b4dc 100644
--- a/packages/nc-gui/components/smartsheet/Grid.vue
+++ b/packages/nc-gui/components/smartsheet/Grid.vue
@@ -125,7 +125,7 @@ const {
   navigateToSiblingRow,
   getExpandedRowIndex,
   deleteRangeOfRows,
-  updateMultipleRows,
+  bulkUpdateRows,
 } = useViewData(meta, view, xWhere)
 
 const { getMeta } = useMetas()
@@ -338,7 +338,7 @@ const {
     // update/save cell value
     await updateOrSaveRow(rowObj, ctx.updatedColumnTitle || columnObj.title)
   },
-  updateMultipleRows,
+  bulkUpdateRows,
 )
 
 function scrollToCell(row?: number | null, col?: number | null) {
diff --git a/packages/nc-gui/composables/useMultiSelect/index.ts b/packages/nc-gui/composables/useMultiSelect/index.ts
index 439a61985e..a936b49c76 100644
--- a/packages/nc-gui/composables/useMultiSelect/index.ts
+++ b/packages/nc-gui/composables/useMultiSelect/index.ts
@@ -43,7 +43,7 @@ export function useMultiSelect(
   scrollToActiveCell?: (row?: number | null, col?: number | null) => void,
   keyEventHandler?: Function,
   syncCellData?: Function,
-  updateMultipleRows?: Function,
+  bulkUpdateRows?: Function,
 ) {
   const meta = ref(_meta)
 
@@ -392,8 +392,8 @@ export function useMultiSelect(
         const rowsToPaste = unref(data).slice(activeCell.row, activeCell.row + pasteMatrixRows)
 
         for (let i = 0; i < pasteMatrixRows; i++) {
+          const pasteRow = rowsToPaste[i]
           for (let j = 0; j < pasteMatrixCols; j++) {
-            const pasteRow = rowsToPaste[i]
             const pasteCol = colsToPaste[j]
 
             if (!pasteRow || !pasteCol) {
@@ -416,7 +416,7 @@ export function useMultiSelect(
             )
           }
         }
-        await updateMultipleRows?.(rowsToPaste)
+        await bulkUpdateRows?.(rowsToPaste)
       } else {
         // handle belongs to column
         if (
diff --git a/packages/nc-gui/composables/useViewData.ts b/packages/nc-gui/composables/useViewData.ts
index d1ffcc2c5d..134e7aeea3 100644
--- a/packages/nc-gui/composables/useViewData.ts
+++ b/packages/nc-gui/composables/useViewData.ts
@@ -448,7 +448,7 @@ export function useViewData(
     }
   }
 
-  async function updateMultipleRows(
+  async function bulkUpdateRows(
     rows: Row[],
     { metaValue = meta.value, viewMetaValue = viewMeta.value }: { metaValue?: TableType; viewMetaValue?: ViewType } = {},
     undo = false,
@@ -479,7 +479,7 @@ export function useViewData(
       addUndo({
         redo: {
           fn: async function redo(redoRows: Row[], pg: { page: number; pageSize: number }) {
-            await updateMultipleRows(redoRows, { metaValue, viewMetaValue }, true)
+            await bulkUpdateRows(redoRows, { metaValue, viewMetaValue }, true)
             if (pg.page === paginationData.value.page && pg.pageSize === paginationData.value.pageSize) {
               for (const toUpdate of redoRows) {
                 const rowIndex = findIndexByPk(rowPkData(toUpdate.row, meta?.value?.columns as ColumnType[]))
@@ -500,7 +500,7 @@ export function useViewData(
         },
         undo: {
           fn: async function undo(undoRows: Row[], pg: { page: number; pageSize: number }) {
-            await updateMultipleRows(undoRows, { metaValue, viewMetaValue }, true)
+            await bulkUpdateRows(undoRows, { metaValue, viewMetaValue }, true)
             if (pg.page === paginationData.value.page && pg.pageSize === paginationData.value.pageSize) {
               for (const toUpdate of undoRows) {
                 const rowIndex = findIndexByPk(rowPkData(toUpdate.row, meta?.value?.columns as ColumnType[]))
@@ -918,7 +918,7 @@ export function useViewData(
     deleteSelectedRows,
     deleteRangeOfRows,
     updateOrSaveRow,
-    updateMultipleRows,
+    bulkUpdateRows,
     selectedAllRecords,
     syncCount,
     syncPagination,