From 797dac54633e4e73634c624c48d18dcac7d4b2ca Mon Sep 17 00:00:00 2001 From: Muhammed Mustafa Date: Mon, 12 Sep 2022 19:15:25 +0530 Subject: [PATCH] fix/Improved unit tests --- .../nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts | 2 +- packages/nocodb/tests/unit/model/tests/baseModelSql.test.ts | 1 + packages/nocodb/tests/unit/rest/tests/tableRow.test.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts b/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts index fd9762b608..ed3d0542d4 100644 --- a/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts +++ b/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts @@ -1976,7 +1976,7 @@ class BaseModelSqlv2 { public async afterDelete(data: any, _trx: any, req): Promise { // if (req?.headers?.['xc-gui']) { const id = req?.params?.id; - Audit.insert({ + await Audit.insert({ fk_model_id: this.model.id, row_id: id, op_type: AuditOperationTypes.DATA, diff --git a/packages/nocodb/tests/unit/model/tests/baseModelSql.test.ts b/packages/nocodb/tests/unit/model/tests/baseModelSql.test.ts index ca0da2dc90..8b330f310c 100644 --- a/packages/nocodb/tests/unit/model/tests/baseModelSql.test.ts +++ b/packages/nocodb/tests/unit/model/tests/baseModelSql.test.ts @@ -218,6 +218,7 @@ function baseModelSqlTests() { expect(deletedRow).to.be.undefined; + console.log('Delete record', await Audit.projectAuditList(project.id, {})); const rowDeletedAudit = (await Audit.projectAuditList(project.id, {})).find((audit) => audit.op_sub_type === 'DELETE'); expect(rowDeletedAudit).to.include({ user: 'test@example.com', diff --git a/packages/nocodb/tests/unit/rest/tests/tableRow.test.ts b/packages/nocodb/tests/unit/rest/tests/tableRow.test.ts index eec6fb7534..518f701c08 100644 --- a/packages/nocodb/tests/unit/rest/tests/tableRow.test.ts +++ b/packages/nocodb/tests/unit/rest/tests/tableRow.test.ts @@ -1860,7 +1860,7 @@ function tableTest() { .expect(400); if(!response.body.msg.includes("Column 'customer_id' cannot be null")){ - console.log(response.body) + console.log('Delete list hm with existing ref row id with non nullable clause', response.body) throw new Error('Wrong error message') } })