From 776454cc4e3aab8b1675a961a0743e6d09e74c88 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Sat, 2 Mar 2024 07:32:43 +0000
Subject: [PATCH] fix(nc-gui): PR review changes #2417

---
 .../cell/RichText/SelectedBubbleMenu.vue       | 15 ++++++---------
 .../nc-gui/components/project/AllTables.vue    |  7 ++++++-
 .../smartsheet/form/LimitOptions.vue           | 18 ++++++++----------
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/packages/nc-gui/components/cell/RichText/SelectedBubbleMenu.vue b/packages/nc-gui/components/cell/RichText/SelectedBubbleMenu.vue
index 6132520f14..ed5048d9fd 100644
--- a/packages/nc-gui/components/cell/RichText/SelectedBubbleMenu.vue
+++ b/packages/nc-gui/components/cell/RichText/SelectedBubbleMenu.vue
@@ -79,15 +79,12 @@ const onToggleLink = () => {
 <template>
   <div
     class="bubble-menu flex-row gap-x-1 py-1 rounded-lg"
-    :class="[
-      `${isFormField ? 'inline-flex !bg-transparent' : 'flex bg-gray-100 px-1'}`,
-      {
-        'embed-mode': embedMode,
-      },
-      {
-        'full-mode': !embedMode,
-      },
-    ]"
+    :class="{
+      'inline-flex !bg-transparent': isFormField,
+      'flex bg-gray-100 px-1': !isFormField,
+      'embed-mode': embedMode,
+      'full-mode': !embedMode,
+    }"
   >
     <NcTooltip :placement="isFormField ? 'bottom' : undefined" :disabled="editor.isActive('codeBlock')">
       <template #title>
diff --git a/packages/nc-gui/components/project/AllTables.vue b/packages/nc-gui/components/project/AllTables.vue
index 8c5f14d388..00391c042d 100644
--- a/packages/nc-gui/components/project/AllTables.vue
+++ b/packages/nc-gui/components/project/AllTables.vue
@@ -80,7 +80,12 @@ const onCreateBaseClick = () => {
 
 <template>
   <div class="nc-all-tables-view">
-    <div class="flex flex-row gap-x-6 pb-3 pt-6" :class="base?.isLoading ? 'pointer-events-none' : ''">
+    <div
+      class="flex flex-row gap-x-6 pb-3 pt-6"
+      :class="{
+        'pointer-events-none': base?.isLoading,
+      }"
+    >
       <div
         v-if="isUIAllowed('tableCreate')"
         role="button"
diff --git a/packages/nc-gui/components/smartsheet/form/LimitOptions.vue b/packages/nc-gui/components/smartsheet/form/LimitOptions.vue
index b7b4e194ac..c12b9ba4c5 100644
--- a/packages/nc-gui/components/smartsheet/form/LimitOptions.vue
+++ b/packages/nc-gui/components/smartsheet/form/LimitOptions.vue
@@ -127,14 +127,12 @@ const showOrHideAll = (showAll: boolean) => {
   if (props.isRequired && !showAll) {
     return
   }
-  vModel.value = [
-    ...vModel.value.map((o) => {
-      return {
-        ...o,
-        show: showAll,
-      }
-    }),
-  ]
+  vModel.value = vModel.value.map((o) => {
+    return {
+      ...o,
+      show: showAll,
+    }
+  })
 }
 </script>
 
@@ -170,7 +168,7 @@ const showOrHideAll = (showAll: boolean) => {
         <NcButton
           type="secondary"
           size="xxsmall"
-          class="!border-none !px-2 !text-xs !text-gray-500 disabled:!text-gray-300"
+          class="!border-none !px-2 !text-xs !text-gray-500 !disabled:text-gray-300"
           :disabled="isRequired || vModel.filter((o) => !o.show).length === vModel.length"
           @click="showOrHideAll(false)"
         >
@@ -182,7 +180,7 @@ const showOrHideAll = (showAll: boolean) => {
         <NcButton
           type="secondary"
           size="xxsmall"
-          class="!border-none !px-2 !text-xs !text-gray-500 disabled:!text-gray-300"
+          class="!border-none !px-2 !text-xs !text-gray-500 !disabled:text-gray-300"
           :disabled="vModel.filter((o) => o.show).length === vModel.length"
           @click="showOrHideAll(true)"
         >