From 76b88b7c745d1009ebebb8ac9a05ef27ce8dcf00 Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Fri, 29 Sep 2023 12:48:16 +0530
Subject: [PATCH] fix: i18n for Percentage

---
 packages/nc-gui/components/cell/Percent.vue            |  4 ++--
 .../components/smartsheet/column/PercentOptions.vue    | 10 +++++-----
 packages/nc-gui/lang/en.json                           |  4 ++++
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/packages/nc-gui/components/cell/Percent.vue b/packages/nc-gui/components/cell/Percent.vue
index 5fec5b0412..55b6188e56 100644
--- a/packages/nc-gui/components/cell/Percent.vue
+++ b/packages/nc-gui/components/cell/Percent.vue
@@ -42,7 +42,7 @@ const focus: VNodeRef = (el) => !isExpandedFormOpen.value && !isEditColumn.value
     class="w-full !text-sm !border-none !outline-none focus:ring-0 text-base p-1"
     :class="{ '!px-2': editEnabled }"
     type="number"
-    :placeholder="isEditColumn ? '(Optional)' : ''"
+    :placeholder="isEditColumn ? $t('labels.optional') : ''"
     @blur="editEnabled = false"
     @keydown.down.stop
     @keydown.left.stop
@@ -54,6 +54,6 @@ const focus: VNodeRef = (el) => !isExpandedFormOpen.value && !isEditColumn.value
     @selectstart.capture.stop
     @mousedown.stop
   />
-  <span v-else-if="vModel === null && showNull" class="nc-null">NULL</span>
+  <span v-else-if="vModel === null && showNull" class="nc-null capitalize">{{ $t('general.null') }}</span>
   <span v-else>{{ vModel }}</span>
 </template>
diff --git a/packages/nc-gui/components/smartsheet/column/PercentOptions.vue b/packages/nc-gui/components/smartsheet/column/PercentOptions.vue
index f5bee9a456..f296ba5bba 100644
--- a/packages/nc-gui/components/smartsheet/column/PercentOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/PercentOptions.vue
@@ -20,7 +20,7 @@ if (!vModel.value.meta?.precision) vModel.value.meta.precision = precisions[0].i
 <template>
   <div class="flex flex-col mt-2 gap-2">
     <div class="flex flex-row space-x-2">
-      <a-form-item class="flex w-1/2" label="Precision">
+      <a-form-item class="flex w-1/2" :label="$t('placeholder.precision')">
         <a-select v-model:value="vModel.meta.precision" dropdown-class-name="nc-dropdown-precision">
           <a-select-option v-for="(precision, i) of precisions" :key="i" :value="precision.id">
             <div class="flex flex-row items-center">
@@ -31,15 +31,15 @@ if (!vModel.value.meta?.precision) vModel.value.meta.precision = precisions[0].i
           </a-select-option>
         </a-select>
       </a-form-item>
-      <a-form-item label="Default Number (%)">
-        <a-input v-model:value="vModel.meta.default" name="default" type="number" />
+      <a-form-item :label="$t('labels.defaultNumberPercent')">
+        <a-input v-model:value="vModel.meta.default" :name="$t('labels.default')" type="number" />
       </a-form-item>
     </div>
     <div class="flex flex-row mt-2">
       <a-form-item>
         <div class="flex flex-row space-x-2 items-center">
-          <a-switch v-model:checked="vModel.meta.negative" name="negative" />
-          <div class="text-xs">Allow negative numbers</div>
+          <a-switch v-model:checked="vModel.meta.negative" :name="$t('labels.negative')" />
+          <div class="text-xs">{{ $t('placeholder.allowNegativeNumbers') }}</div>
         </div>
       </a-form-item>
     </div>
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 5c2b774e17..1016be829e 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -359,6 +359,9 @@
     "syntax": "Syntax",
     "examples": "Examples",
     "durationInfo": "A duration of time in minutes or seconds (e.g. 1:23).",
+    "negative": "Negative",
+    "default": "Default",
+    "defaultNumberPercent": "Default Number (%)",
     "durationFormat": "Duration Format",
     "dateFormat": "Date Format",
     "timeFormat": "Time Format",
@@ -767,6 +770,7 @@
       "save": "Save password",
       "confirm": "Confirm new password"
     },
+    "allowNegativeNumbers": "Allow negative numbers",
     "searchProjectTree": "Search tables",
     "searchFields": "Search fields",
     "searchColumn": "Search {search} column",