From 750756fdefb0e6460d8a83633f3e9b6d4d9dd798 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Thu, 4 Jan 2024 13:19:18 +0000 Subject: [PATCH] feat: when deleting `CreateTime` or `LastModifiedTime`, keep the column and just delete the meta entry --- packages/nocodb/src/services/columns.service.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/nocodb/src/services/columns.service.ts b/packages/nocodb/src/services/columns.service.ts index 22e3b71c38..cf6af2e3f8 100644 --- a/packages/nocodb/src/services/columns.service.ts +++ b/packages/nocodb/src/services/columns.service.ts @@ -1701,8 +1701,8 @@ export class ColumnsService { (c.uidt === UITypes.CreateTime ? 'created_at' : 'updated_at'), ); - if(!dbColumn){ - // create column in db + if (!dbColumn) { + // create column in db } await Column.insert({ @@ -2148,6 +2148,13 @@ export class ColumnsService { } /* falls through to default */ } + + // on delete create time or last modified time, keep the column in table and delete the column from meta + case UITypes.CreateTime: + case UITypes.LastModifiedTime: { + await Column.delete(param.columnId, ncMeta); + } + break; default: { const tableUpdateBody = { ...table,