From 73e2ff06f95b545eb019088a5c12478ece6bb51f Mon Sep 17 00:00:00 2001
From: Pranav C <61551451+pranavxc@users.noreply.github.com>
Date: Thu, 29 Jul 2021 13:45:52 +0530
Subject: [PATCH] feat(gui): Add clear option in context menu

added clear option in context menu for cells which are `nullable`, it can used to set the cell  value to null

re #this.value

Signed-off-by: Pranav C <61551451+pranavxc@users.noreply.github.com>
---
 .../project/spreadsheet/rowsXcDataTable.vue   | 29 +++++++++++++++++--
 .../project/spreadsheet/views/xcGridView.vue  |  7 +++--
 2 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui/components/project/spreadsheet/rowsXcDataTable.vue b/packages/nc-gui/components/project/spreadsheet/rowsXcDataTable.vue
index f1b87bd0fd..8143155347 100644
--- a/packages/nc-gui/components/project/spreadsheet/rowsXcDataTable.vue
+++ b/packages/nc-gui/components/project/spreadsheet/rowsXcDataTable.vue
@@ -384,6 +384,18 @@
             <span class="caption">Delete Selected Rows</span>
           </v-list-item>
         </template>
+        <template v-if="rowContextMenu.col && !rowContextMenu.col.rqd && !rowContextMenu.col.virtual">
+          <v-tooltip bottom>
+            <template #activator="{on}">
+              <v-list-item v-on="on" @click="clearCellValue">
+                <span class="caption">Clear</span>
+              </v-list-item>
+            </template>
+
+            <span class="caption">Set column value to <strong>null</strong></span>
+          </v-tooltip>
+        </template>
+
         <!--        <template v-if="meta.hasMany && meta.hasMany.length">
           <v-divider v-if="isEditable && !isLocked" />
           <span class="ml-3 grey&#45;&#45;text " style="font-size: 9px">Has Many</span>
@@ -564,7 +576,7 @@ export default {
       icon: 'mdi-view-stream'
     }, {
       size: 'xlarge',
-      icon: 'mdi-card'
+      icon: 'mdi-ca rd'
     }],
     rowContextMenu: null
   }),
@@ -840,6 +852,15 @@ export default {
         this.$toast.success('Deleted selected rows successfully').goAway(3000)
       }
     },
+
+    async clearCellValue() {
+      const { col, colIndex, row, index } = this.rowContextMenu
+      if (row[col._cn] === null) {
+        return
+      }
+      this.$set(this.data[index].row, col._cn, null)
+      this.onCellValueChangeFn(colIndex, index, col)
+    },
     async insertNewRow(atEnd = false, expand = false) {
       const focusRow = atEnd ? this.rowLength : this.rowContextMenu.index + 1
       const focusCol = this.availableColumns.findIndex(c => !c.ai)
@@ -924,7 +945,7 @@ export default {
       }
       this.loadingData = false
     },
-    showRowContextMenu(e, row, rowMeta, index) {
+    showRowContextMenu(e, row, rowMeta, index, colIndex, col) {
       e.preventDefault()
       this.rowContextMenu = false
       this.$nextTick(() => {
@@ -933,7 +954,9 @@ export default {
           y: e.clientY,
           row,
           index,
-          rowMeta
+          rowMeta,
+          colIndex,
+          col
         }
       })
     },
diff --git a/packages/nc-gui/components/project/spreadsheet/views/xcGridView.vue b/packages/nc-gui/components/project/spreadsheet/views/xcGridView.vue
index 350ac67c99..23979b1558 100644
--- a/packages/nc-gui/components/project/spreadsheet/views/xcGridView.vue
+++ b/packages/nc-gui/components/project/spreadsheet/views/xcGridView.vue
@@ -87,11 +87,11 @@
         <tr
           v-for="({row:rowObj, rowMeta},row) in data"
           :key="row"
-          @contextmenu="showRowContextMenu($event,rowObj,rowMeta,row)"
         >
           <td
             style="width: 65px"
             class="caption"
+            @contextmenu="showRowContextMenu($event,rowObj,rowMeta,row)"
           >
             <div class="d-flex align-center">
               <span
@@ -142,6 +142,7 @@
             :data-col="columnObj.alias"
             @dblclick="makeEditable(col,row,columnObj.ai)"
             @click="makeSelected(col,row);"
+            @contextmenu="showRowContextMenu($event,rowObj,rowMeta,row,col, columnObj)"
           >
             <virtual-cell
               v-if="columnObj.virtual"
@@ -448,8 +449,8 @@ export default {
     expandRow(...args) {
       this.$emit('expandRow', ...args)
     },
-    showRowContextMenu($event, rowObj, rowMeta, row) {
-      this.$emit('showRowContextMenu', $event, rowObj, rowMeta, row)
+    showRowContextMenu($event, rowObj, rowMeta, row, ...rest) {
+      this.$emit('showRowContextMenu', $event, rowObj, rowMeta, row, ...rest)
     },
     onCellValueChange(col, row, column, ev) {
       this.$emit('onCellValueChange', col, row, column, ev)