Nc fix/3616 formula related bugs (#9277)

* fix: handle `@` char in field name while generating identifier token for monaco

* fix: invalid formula validation in UI

packages/nc-gui/components/monaco/formula.ts

@@ -62,7 +62,7 @@ const generateLanguageDefinition = (identifiers: string[]) => {
         ],
         [/\d+/, 'number'],
         [/[-+/*=<>!]+/, 'operator'],
-        [/[{}()\[\]]/, '@brackets'],
+        [/[{}()]/, '@brackets'],
         [/[ \t\r\n]+/, 'white'],
       ],
 
@@ -86,12 +86,10 @@ const generateLanguageDefinition = (identifiers: string[]) => {
 const languageConfiguration: languages.LanguageConfiguration = {
   brackets: [
     ['{', '}'],
-    ['[', ']'],
     ['(', ')'],
   ],
   autoClosingPairs: [
     { open: '{', close: '}' },
-    { open: '[', close: ']' },
     { open: '(', close: ')' },
     { open: '"', close: '"' },
     { open: "'", close: "'" },

packages/nc-gui/components/smartsheet/column/FormulaInputHelper.vue

@@ -170,7 +170,8 @@ onMounted(async () => {
 
     languages.setMonarchTokensProvider(
       formulaLanguage.name,
-      formulaLanguage.generateLanguageDefinition(supportedColumns.value.map((c) => c.title!)),
+      // replace @ with \x01 to avoid conflict with monaco's tokenizer
+      formulaLanguage.generateLanguageDefinition(supportedColumns.value.map((c) => c.title!.replace(/@/g, '\x01'))),
     )
 
     languages.setLanguageConfiguration(formulaLanguage.name, formulaLanguage.languageConfiguration)

packages/nocodb-sdk/src/lib/formulaHelpers.ts

@@ -1892,6 +1892,24 @@ export async function validateFormulaAndExtractTreeWithType({
       } else {
         res.dataType = FormulaDataTypes.NUMERIC;
       }
+    } else if (parsedTree.type === JSEPNode.MEMBER_EXP) {
+      throw new FormulaError(
+        FormulaErrorType.NOT_SUPPORTED,
+        {},
+        'Bracket notation is not supported'
+      );
+    } else if (parsedTree.type === JSEPNode.ARRAY_EXP) {
+      throw new FormulaError(
+        FormulaErrorType.NOT_SUPPORTED,
+        {},
+        'Array is not supported'
+      );
+    } else if (parsedTree.type === JSEPNode.COMPOUND) {
+      throw new FormulaError(
+        FormulaErrorType.NOT_SUPPORTED,
+        {},
+        'Compound statement is not supported'
+      );
     }
 
     return res;