From 6a2ccfd693f8cfdff75f3dd345b58ce65a768d50 Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Tue, 23 Aug 2022 17:40:59 +0200
Subject: [PATCH] fix(gui-v2): teleport warning on shared view form

---
 packages/nc-gui-v2/components/cell/Text.vue          |  5 ++---
 packages/nc-gui-v2/layouts/default.vue               | 12 ++++++------
 packages/nc-gui-v2/nuxt-shim.d.ts                    |  1 +
 .../nc-gui-v2/pages/[projectType]/form/[viewId].vue  |  3 +++
 4 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/packages/nc-gui-v2/components/cell/Text.vue b/packages/nc-gui-v2/components/cell/Text.vue
index 2c8e54d0d7..23575fc222 100644
--- a/packages/nc-gui-v2/components/cell/Text.vue
+++ b/packages/nc-gui-v2/components/cell/Text.vue
@@ -1,10 +1,9 @@
 <script setup lang="ts">
 import type { VNodeRef } from '@vue/runtime-core'
-import { inject } from '#imports'
-import { EditModeInj } from '~/context'
+import { EditModeInj, inject, useVModel } from '#imports'
 
 interface Props {
-  modelValue: string | null | undefined
+  modelValue?: string | null
 }
 
 const props = defineProps<Props>()
diff --git a/packages/nc-gui-v2/layouts/default.vue b/packages/nc-gui-v2/layouts/default.vue
index 0b68f61af8..289aa78aa9 100644
--- a/packages/nc-gui-v2/layouts/default.vue
+++ b/packages/nc-gui-v2/layouts/default.vue
@@ -1,14 +1,14 @@
 <script lang="ts" setup>
-import { useI18n } from 'vue-i18n'
-import { useHead, useRoute } from '#imports'
+import { useTitle } from '@vueuse/core'
+import { useI18n, useRoute, useSidebar } from '#imports'
 
 const route = useRoute()
 
 const { te, t } = useI18n()
 
-useHead({
-  title: route.meta?.title && te(route.meta.title as string) ? `${t(route.meta.title as string)} | NocoDB` : 'NocoDB',
-})
+const { hasSidebar } = useSidebar()
+
+useTitle(route.meta?.title && te(route.meta.title) ? `${t(route.meta.title)} | NocoDB` : 'NocoDB')
 </script>
 
 <script lang="ts">
@@ -19,7 +19,7 @@ export default {
 
 <template>
   <div class="w-full h-full">
-    <Teleport to="#nc-sidebar-left">
+    <Teleport :to="hasSidebar ? '#nc-sidebar-left' : null" :disabled="!hasSidebar">
       <slot name="sidebar" />
     </Teleport>
 
diff --git a/packages/nc-gui-v2/nuxt-shim.d.ts b/packages/nc-gui-v2/nuxt-shim.d.ts
index 0aa87c529e..bbb6b561e4 100644
--- a/packages/nc-gui-v2/nuxt-shim.d.ts
+++ b/packages/nc-gui-v2/nuxt-shim.d.ts
@@ -30,5 +30,6 @@ declare module 'vue-router' {
     requiresAuth?: boolean
     public?: boolean
     hideHeader?: boolean
+    title?: string
   }
 }
diff --git a/packages/nc-gui-v2/pages/[projectType]/form/[viewId].vue b/packages/nc-gui-v2/pages/[projectType]/form/[viewId].vue
index a36615a205..eb2a315dc2 100644
--- a/packages/nc-gui-v2/pages/[projectType]/form/[viewId].vue
+++ b/packages/nc-gui-v2/pages/[projectType]/form/[viewId].vue
@@ -13,12 +13,15 @@ import {
   useProvideSharedFormStore,
   useProvideSmartsheetStore,
   useRoute,
+  useSidebar,
 } from '#imports'
 
 definePageMeta({
   public: true,
 })
 
+useSidebar({ hasSidebar: false })
+
 const route = useRoute()
 
 const { loadSharedView, sharedView, meta, notFound } = useProvideSharedFormStore(route.params.viewId as string)