From 4957cf90d01d421f653fa24a1f3de4235ae5408e Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Fri, 6 Dec 2024 07:00:37 +0000
Subject: [PATCH 1/6] fix: delete all records

---
 .../components/dlg/Record/DeleteAll.vue       |  62 ++++++++
 .../{ExpandTable.vue => Record/Upsert.vue}    |   0
 .../smartsheet/grid/InfiniteTable.vue         | 143 ++++++++++++++----
 .../components/smartsheet/grid/index.vue      |   4 +
 .../nc-gui/composables/useGridViewData.ts     |  21 ++-
 .../nc-gui/composables/useInfiniteData.ts     |   3 +
 packages/nc-gui/lang/en.json                  |   1 +
 .../controllers/bulk-data-alias.controller.ts |   1 +
 packages/nocodb/src/schema/swagger.json       |  16 --
 9 files changed, 204 insertions(+), 47 deletions(-)
 create mode 100644 packages/nc-gui/components/dlg/Record/DeleteAll.vue
 rename packages/nc-gui/components/dlg/{ExpandTable.vue => Record/Upsert.vue} (100%)

diff --git a/packages/nc-gui/components/dlg/Record/DeleteAll.vue b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
new file mode 100644
index 0000000000..3e58663f27
--- /dev/null
+++ b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
@@ -0,0 +1,62 @@
+<script setup lang="ts">
+import { onKeyDown } from '@vueuse/core'
+
+const props = defineProps<{
+  modelValue: boolean
+  rows: number
+}>()
+
+const emit = defineEmits(['cancel', 'update:modelValue', 'deleteAll'])
+
+const dialogShow = useVModel(props, 'modelValue', emit)
+
+onKeyDown('esc', () => {
+  dialogShow.value = false
+  emit('update:modelValue', false)
+})
+
+const close = () => {
+  dialogShow.value = false
+  emit('cancel')
+}
+
+</script>
+
+<template>
+  <NcModal
+    v-if="dialogShow"
+    v-model:visible="dialogShow"
+    :show-separator="false"
+    :header="$t('activity.deleteAllRecords')"
+    size="small"
+    @keydown.esc="dialogShow = false"
+  >
+    <div class="flex justify-between w-full text-base font-semibold mb-2 text-nc-content-gray-emphasis items-center">
+      {{ 'Delete all records' }}
+    </div>
+    <div data-testid="nc-expand-table-modal" class="flex flex-col">
+      <div class="mb-2 nc-content-gray">Are you sure you want to delete all the records present in this table?</div>
+    </div>
+
+    <div class="bg-nc-bg-red-light p-4 border-1 flex items-center gap-4 w-full border-nc-gray-medium rounded-lg">
+      <GeneralIcon class="text-nc-fill-red-dark" icon="ncInfoSolid" />
+
+      <div class="leading-5 font-semibold text-nc-content-gray">This action cannot be undone.</div>
+    </div>
+
+    <div class="flex flex-row mt-5 justify-end gap-x-2">
+      <div class="flex gap-2 items-center">
+        <NcButton data-testid="nn-record-delete-cancel" type="secondary" size="small" @click="close">
+          {{ $t('labels.cancel') }}
+        </NcButton>
+      </div>
+      <div class="flex gap-2 items-center">
+        <NcButton data-testid="nc-record-delete-all" type="danger" size="small" @click="emit('deleteAll')">
+          {{ $t('general.delete') }}
+        </NcButton>
+      </div>
+    </div>
+  </NcModal>
+</template>
+
+<style scoped lang="scss"></style>
diff --git a/packages/nc-gui/components/dlg/ExpandTable.vue b/packages/nc-gui/components/dlg/Record/Upsert.vue
similarity index 100%
rename from packages/nc-gui/components/dlg/ExpandTable.vue
rename to packages/nc-gui/components/dlg/Record/Upsert.vue
diff --git a/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue b/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue
index f400aa8b59..720b00e985 100644
--- a/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue
+++ b/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue
@@ -41,6 +41,7 @@ const props = defineProps<{
     metas?: { metaValue?: TableType; viewMetaValue?: ViewType },
     undo?: boolean,
   ) => Promise<void>
+  bulkDeleteAll?: () => Promise<void>
   bulkUpsertRows?: (
     insertRows: Row[],
     updateRows: [],
@@ -57,9 +58,12 @@ const props = defineProps<{
   selectedRows: Array<Row>
   chunkStates: Array<'loading' | 'loaded' | undefined>
   isBulkOperationInProgress: boolean
+  selectedAllRecords?: boolean
 }>()
 
-const emits = defineEmits(['bulkUpdateDlg'])
+const emits = defineEmits(['bulkUpdateDlg', 'update:selectedAllRecords'])
+
+const vSelectedAllRecords = useVModel(props, 'selectedAllRecords', emits)
 
 const {
   loadData,
@@ -75,6 +79,7 @@ const {
   removeRowIfNew,
   clearInvalidRows,
   applySorting,
+  bulkDeleteAll,
 } = props
 
 // Injections
@@ -660,6 +665,29 @@ const onActiveCellChanged = () => {
   }
 }
 
+const isDeleteAllModalIsOpen = ref(false)
+async function deleteAllRecords() {
+  isDeleteAllModalIsOpen.value = true
+
+  function closeDlg() {
+    isOpen.value = false
+    close(200)
+  }
+
+  const { close } = useDialog(resolveComponent('DlgRecordDeleteAll'), {
+    'modelValue': isDeleteAllModalIsOpen,
+    'rows': totalRows.value,
+    'onUpdate:modelValue': closeDlg,
+    'onDeleteAll': async () => {
+      await bulkDeleteAll?.()
+      closeDlg()
+      vSelectedAllRecords.value = false
+    },
+  })
+
+  await until(isDeleteAllModalIsOpen).toBe(false)
+}
+
 const isOpen = ref(false)
 async function expandRows({
   newRows,
@@ -677,7 +705,7 @@ async function expandRows({
     continue: false,
     expand: true,
   }
-  const { close } = useDialog(resolveComponent('DlgExpandTable'), {
+  const { close } = useDialog(resolveComponent('DlgRecordUpsert'), {
     'modelValue': isOpen,
     'newRows': newRows,
     'newColumns': newColumns,
@@ -1746,6 +1774,28 @@ watch(
     immediate: true,
   },
 )
+
+
+const toggleRowSelection = (row: number) => {
+  if(vSelectedAllRecords.value) return
+  const data = cachedRows.value.get(row)
+
+  if (!data) return
+  data.rowMeta.selected = !data.rowMeta?.selected
+  cachedRows.value.set(row, data)
+}
+
+watch(vSelectedAllRecords, (selectedAll) => {
+  if (!selectedAll) {
+    for (const [row, data] of cachedRows.value.entries()) {
+      if (data.rowMeta?.selected) {
+        data.rowMeta.selected = false
+        cachedRows.value.set(row, data)
+      }
+    }
+  }
+})
+
 </script>
 
 <template>
@@ -1778,7 +1828,7 @@ watch(
     <div ref="gridWrapper" class="nc-grid-wrapper min-h-0 flex-1 relative !overflow-auto">
       <NcDropdown
         v-model:visible="contextMenu"
-        :disabled="contextMenuTarget === null && !selectedRows.length"
+        :disabled="contextMenuTarget === null && (!selectedRows.length && !vSelectedAllRecords)"
         :trigger="isSqlView ? [] : ['contextmenu']"
         overlay-class-name="nc-dropdown-grid-context-menu"
       >
@@ -1825,7 +1875,25 @@ watch(
                   }"
                   data-testid="grid-id-column"
                 >
-                  <div class="w-full h-full text-gray-500 flex pl-2 pr-1 items-center" data-testid="nc-check-all">#</div>
+
+                  <div class="flex items-center pl-2 pr-1 w-full h-full justify-center" v-if="!readOnly">
+                    <div class="nc-no-label text-gray-500" :class="{ hidden: vSelectedAllRecords }">#</div>
+                    <div
+                      :class="{
+                          hidden: !vSelectedAllRecords,
+                          flex: vSelectedAllRecords,
+                        }"
+                      class="nc-check-all w-full items-center"
+                    >
+                      <NcCheckbox v-model:checked="vSelectedAllRecords" />
+
+                      <span class="flex-1" />
+                    </div>
+                  </div>
+                  <template v-else>
+                    <div class="w-full h-full text-gray-500 flex pl-2 pr-1 items-center" data-testid="nc-check-all">#</div>
+                  </template>
+
                 </th>
                 <th
                   v-if="fields[0] && fields[0].id"
@@ -2127,7 +2195,7 @@ watch(
                         'active-row':
                           activeCell.row === row.rowMeta.rowIndex || selectedRange._start?.row === row.rowMeta.rowIndex,
                         'mouse-down': isGridCellMouseDown || isFillMode,
-                        'selected-row': row.rowMeta.selected,
+                        'selected-row': row.rowMeta.selected || vSelectedAllRecords,
                         'invalid-row': row.rowMeta?.isValidationFailed || row.rowMeta?.isRowOrderUpdated,
                       }"
                     >
@@ -2143,21 +2211,22 @@ watch(
                         <div class="w-[60px] pl-2 pr-1 items-center flex gap-1">
                           <div
                             class="nc-row-no sm:min-w-4 text-xs text-gray-500"
-                            :class="{ toggle: !readOnly, hidden: row.rowMeta?.selected }"
+                            :class="{ toggle: !readOnly, hidden: row.rowMeta?.selected || vSelectedAllRecords }"
                           >
                             {{ row.rowMeta.rowIndex + 1 }}
                           </div>
                           <div
                             v-if="!readOnly"
                             :class="{
-                              hidden: !row.rowMeta?.selected,
-                              flex: row.rowMeta?.selected,
+                              hidden: !row.rowMeta?.selected && !vSelectedAllRecords,
+                              flex: row.rowMeta?.selected || vSelectedAllRecords,
                             }"
                             class="nc-row-expand-and-checkbox"
                           >
-                            <a-checkbox
-                              v-model:checked="row.rowMeta.selected"
-                              :disabled="!row.rowMeta.selected && selectedRows.length > 100"
+                            <NcCheckbox
+                              :checked="row.rowMeta.selected || vSelectedAllRecords"
+                              :disabled="!row.rowMeta.selected && selectedRows.length > 100 || vSelectedAllRecords"
+                              @change="toggleRowSelection(row.rowMeta.rowIndex)"
                             />
                           </div>
                           <span class="flex-1" />
@@ -2388,31 +2457,45 @@ watch(
 
         <template #overlay>
           <NcMenu class="!rounded !py-0" @click="contextMenu = false">
-            <NcMenuItem
-              v-if="isEeUI && !contextMenuClosing && !contextMenuTarget && !isDataReadOnly && selectedRows.length"
-              @click="emits('bulkUpdateDlg')"
-            >
-              <div v-e="['a:row:update-bulk']" class="flex gap-2 items-center">
-                <component :is="iconMap.ncEdit" />
-                {{ $t('title.updateSelectedRows') }}
-              </div>
-            </NcMenuItem>
+            <template v-if="!vSelectedAllRecords">
+              <NcMenuItem
+                v-if="isEeUI && !contextMenuClosing && !contextMenuTarget && !isDataReadOnly && selectedRows.length"
+                @click="emits('bulkUpdateDlg')"
+              >
+                <div v-e="['a:row:update-bulk']" class="flex gap-2 items-center">
+                  <component :is="iconMap.ncEdit" />
+                  {{ $t('title.updateSelectedRows') }}
+                </div>
+              </NcMenuItem>
 
+              <NcMenuItem
+                v-if="!contextMenuClosing && !contextMenuTarget && !isDataReadOnly && selectedRows.length"
+                class="nc-base-menu-item !text-red-600 !hover:bg-red-50"
+                data-testid="nc-delete-row"
+                @click="deleteSelectedRows"
+              >
+                <div v-if="selectedRows.length === 1" v-e="['a:row:delete']" class="flex gap-2 items-center">
+                  <component :is="iconMap.delete" />
+                  {{ $t('activity.deleteSelectedRow') }}
+                </div>
+                <div v-else v-e="['a:row:delete-bulk']" class="flex gap-2 items-center">
+                  <component :is="iconMap.delete" />
+                  {{ $t('activity.deleteSelectedRow') }}
+                </div>
+              </NcMenuItem>
+            </template>
             <NcMenuItem
-              v-if="!contextMenuClosing && !contextMenuTarget && !isDataReadOnly && selectedRows.length"
+              v-if="vSelectedAllRecords"
               class="nc-base-menu-item !text-red-600 !hover:bg-red-50"
-              data-testid="nc-delete-row"
-              @click="deleteSelectedRows"
+              data-testid="nc-delete-all-row"
+              @click="deleteAllRecords"
             >
-              <div v-if="selectedRows.length === 1" v-e="['a:row:delete']" class="flex gap-2 items-center">
+              <div v-e="['a:row:delete-all']" class="flex gap-2 items-center">
                 <component :is="iconMap.delete" />
-                {{ $t('activity.deleteSelectedRow') }}
-              </div>
-              <div v-else v-e="['a:row:delete-bulk']" class="flex gap-2 items-center">
-                <component :is="iconMap.delete" />
-                {{ $t('activity.deleteSelectedRow') }}
+                {{ $t('activity.deleteAllRecords') }}
               </div>
             </NcMenuItem>
+
             <NcTooltip
               v-if="contextMenuTarget && hasEditPermission && !isDataReadOnly && isSelectedOnlyAI.enabled"
               :disabled="!isSelectedOnlyAI.disabled"
@@ -2508,7 +2591,7 @@ watch(
             </template>
 
             <template v-if="hasEditPermission && !isDataReadOnly">
-              <NcDivider v-if="!(!contextMenuClosing && !contextMenuTarget && selectedRows.length)" />
+              <NcDivider v-if="!(!contextMenuClosing && !contextMenuTarget && (selectedRows.length || vSelectedAllRecords))" />
               <NcMenuItem
                 v-if="contextMenuTarget && (selectedRange.isSingleCell() || selectedRange.isSingleRow())"
                 class="nc-base-menu-item !text-red-600 !hover:bg-red-50"
diff --git a/packages/nc-gui/components/smartsheet/grid/index.vue b/packages/nc-gui/components/smartsheet/grid/index.vue
index 8536f062d0..f7006172f1 100644
--- a/packages/nc-gui/components/smartsheet/grid/index.vue
+++ b/packages/nc-gui/components/smartsheet/grid/index.vue
@@ -61,6 +61,8 @@ const {
   isRowSortRequiredRows,
   applySorting,
   isBulkOperationInProgress,
+  selectedAllRecords,
+  bulkDeleteAll,
 } = useGridViewData(meta, view, xWhere, reloadVisibleDataHook)
 
 const rowHeight = computed(() => {
@@ -276,6 +278,7 @@ const {
     <InfiniteTable
       v-else-if="!isGroupBy"
       ref="tableRef"
+      v-model:selected-all-records="selectedAllRecords"
       :load-data="loadData"
       :call-add-empty-row="_addEmptyRow"
       :delete-row="deleteRow"
@@ -285,6 +288,7 @@ const {
       :apply-sorting="applySorting"
       :bulk-update-rows="bulkUpdateRows"
       :bulk-upsert-rows="bulkUpsertRows"
+      :bulk-delete-all="bulkDeleteAll"
       :clear-cache="clearCache"
       :clear-invalid-rows="clearInvalidRows"
       :data="cachedRows"
diff --git a/packages/nc-gui/composables/useGridViewData.ts b/packages/nc-gui/composables/useGridViewData.ts
index 4f68c3c452..b4e5cac890 100644
--- a/packages/nc-gui/composables/useGridViewData.ts
+++ b/packages/nc-gui/composables/useGridViewData.ts
@@ -64,7 +64,7 @@ export function useGridViewData(
     isFirstRow,
     getExpandedRowIndex,
     loadData,
-
+    selectedAllRecords,
     loadAggCommentsCount,
     navigateToSiblingRow,
   } = useInfiniteData({
@@ -706,6 +706,23 @@ export function useGridViewData(
     }
   }
 
+  async function bulkDeleteAll() {
+    try {
+      isBulkOperationInProgress.value = true
+
+      await $api.dbTableRow.bulkDeleteAll('noco', base.value.id!, meta.value.id!, {
+        where: where?.value,
+        viewId: viewMeta.value?.id,
+      })
+    } catch (error) {
+    } finally {
+      clearCache(Number.NEGATIVE_INFINITY, Number.POSITIVE_INFINITY)
+      await syncCount()
+      syncVisibleData?.()
+      isBulkOperationInProgress.value = false
+    }
+  }
+
   return {
     cachedRows,
     loadData,
@@ -720,6 +737,7 @@ export function useGridViewData(
     bulkUpdateRows,
     bulkUpsertRows,
     bulkUpdateView,
+    bulkDeleteAll,
     loadAggCommentsCount,
     syncCount,
     removeRowIfNew,
@@ -737,5 +755,6 @@ export function useGridViewData(
     applySorting,
     isRowSortRequiredRows,
     isBulkOperationInProgress,
+    selectedAllRecords,
   }
 }
diff --git a/packages/nc-gui/composables/useInfiniteData.ts b/packages/nc-gui/composables/useInfiniteData.ts
index 8a25494b2c..525f7f4ccd 100644
--- a/packages/nc-gui/composables/useInfiniteData.ts
+++ b/packages/nc-gui/composables/useInfiniteData.ts
@@ -55,6 +55,8 @@ export function useInfiniteData(args: {
 
   const { nestedFilters, allFilters, xWhere, sorts } = useSmartsheetStoreOrThrow()
 
+  const selectedAllRecords = ref(false)
+
   const routeQuery = computed(() => router.currentRoute.value.query as Record<string, string>)
 
   const columnsByAlias = computed(() => {
@@ -1142,5 +1144,6 @@ export function useInfiniteData(args: {
     getExpandedRowIndex,
     loadAggCommentsCount,
     navigateToSiblingRow,
+    selectedAllRecords,
   }
 }
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 10b7623e36..338311b1ec 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -1067,6 +1067,7 @@
     "viewHide": "View visibility "
   },
   "activity": {
+    "deleteAllRecords": "Delete all records",
     "assignView": "Assign view",
     "webhookDetails": "Webhook Details",
     "showSaturdaysAndSundays": "Show Saturdays & Sundays",
diff --git a/packages/nocodb/src/controllers/bulk-data-alias.controller.ts b/packages/nocodb/src/controllers/bulk-data-alias.controller.ts
index 03dcd013de..6e8226db44 100644
--- a/packages/nocodb/src/controllers/bulk-data-alias.controller.ts
+++ b/packages/nocodb/src/controllers/bulk-data-alias.controller.ts
@@ -112,6 +112,7 @@ export class BulkDataAliasController {
       baseName: baseName,
       tableName: tableName,
       query: req.query,
+      viewName: req.query.viewId,
     });
   }
 
diff --git a/packages/nocodb/src/schema/swagger.json b/packages/nocodb/src/schema/swagger.json
index 0c2b610329..50be22ce42 100644
--- a/packages/nocodb/src/schema/swagger.json
+++ b/packages/nocodb/src/schema/swagger.json
@@ -11708,22 +11708,6 @@
           }
         },
         "tags": ["DB Table Row"],
-        "requestBody": {
-          "content": {
-            "application/json": {
-              "schema": {
-                "type": "object"
-              },
-              "examples": {
-                "Example 1": {
-                  "value": {
-                    "Title": "foo"
-                  }
-                }
-              }
-            }
-          }
-        },
         "description": "Bulk Delete all Table Rows if the condition is true",
         "parameters": [
           {

From 5a5c2a43d3a41d0e58f382653db7a6a07480dbb6 Mon Sep 17 00:00:00 2001
From: Raju Udava <86527202+dstala@users.noreply.github.com>
Date: Fri, 6 Dec 2024 07:00:37 +0000
Subject: [PATCH 2/6] chore: table to view

---
 packages/nc-gui/components/dlg/Record/DeleteAll.vue | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/nc-gui/components/dlg/Record/DeleteAll.vue b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
index 3e58663f27..998c797a02 100644
--- a/packages/nc-gui/components/dlg/Record/DeleteAll.vue
+++ b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
@@ -19,7 +19,6 @@ const close = () => {
   dialogShow.value = false
   emit('cancel')
 }
-
 </script>
 
 <template>
@@ -35,7 +34,7 @@ const close = () => {
       {{ 'Delete all records' }}
     </div>
     <div data-testid="nc-expand-table-modal" class="flex flex-col">
-      <div class="mb-2 nc-content-gray">Are you sure you want to delete all the records present in this table?</div>
+      <div class="mb-2 nc-content-gray">Are you sure you want to delete all the records present in this view?</div>
     </div>
 
     <div class="bg-nc-bg-red-light p-4 border-1 flex items-center gap-4 w-full border-nc-gray-medium rounded-lg">

From 3e636e03964fa5ada8dfff1dfea9cbc6045b4d0a Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Fri, 6 Dec 2024 07:00:37 +0000
Subject: [PATCH 3/6] fix: some issues

---
 packages/nc-gui/components/dlg/Record/DeleteAll.vue | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/nc-gui/components/dlg/Record/DeleteAll.vue b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
index 998c797a02..050b6d5a80 100644
--- a/packages/nc-gui/components/dlg/Record/DeleteAll.vue
+++ b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
@@ -34,12 +34,10 @@ const close = () => {
       {{ 'Delete all records' }}
     </div>
     <div data-testid="nc-expand-table-modal" class="flex flex-col">
-      <div class="mb-2 nc-content-gray">Are you sure you want to delete all the records present in this view?</div>
+      <div class="mb-2 nc-content-gray">Are you sure you want to delete all {{ rows }} records present in this view?</div>
     </div>
 
     <div class="bg-nc-bg-red-light p-4 border-1 flex items-center gap-4 w-full border-nc-gray-medium rounded-lg">
-      <GeneralIcon class="text-nc-fill-red-dark" icon="ncInfoSolid" />
-
       <div class="leading-5 font-semibold text-nc-content-gray">This action cannot be undone.</div>
     </div>
 

From 712a91c71f12d01cbd950c332495dba083f2aaad Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Fri, 6 Dec 2024 07:00:37 +0000
Subject: [PATCH 4/6] fix: bg color

---
 packages/nc-gui/components/dlg/Record/DeleteAll.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/nc-gui/components/dlg/Record/DeleteAll.vue b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
index 050b6d5a80..bd46869e12 100644
--- a/packages/nc-gui/components/dlg/Record/DeleteAll.vue
+++ b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
@@ -37,8 +37,8 @@ const close = () => {
       <div class="mb-2 nc-content-gray">Are you sure you want to delete all {{ rows }} records present in this view?</div>
     </div>
 
-    <div class="bg-nc-bg-red-light p-4 border-1 flex items-center gap-4 w-full border-nc-gray-medium rounded-lg">
-      <div class="leading-5 font-semibold text-nc-content-gray">This action cannot be undone.</div>
+    <div class="bg-nc-bg-gray-light p-4 border-1 flex items-center gap-4 w-full border-nc-gray-medium rounded-lg">
+      <div class="leading-5 text-nc-content-gray">This action cannot be undone.</div>
     </div>
 
     <div class="flex flex-row mt-5 justify-end gap-x-2">

From a752602a4fe4b369044373c11d26ee7cc531b193 Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Fri, 6 Dec 2024 07:00:37 +0000
Subject: [PATCH 5/6] fix: update padding

---
 packages/nc-gui/components/dlg/Record/DeleteAll.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/nc-gui/components/dlg/Record/DeleteAll.vue b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
index bd46869e12..459ed7d1fa 100644
--- a/packages/nc-gui/components/dlg/Record/DeleteAll.vue
+++ b/packages/nc-gui/components/dlg/Record/DeleteAll.vue
@@ -37,7 +37,7 @@ const close = () => {
       <div class="mb-2 nc-content-gray">Are you sure you want to delete all {{ rows }} records present in this view?</div>
     </div>
 
-    <div class="bg-nc-bg-gray-light p-4 border-1 flex items-center gap-4 w-full border-nc-gray-medium rounded-lg">
+    <div class="bg-nc-bg-gray-light py-2 px-4 flex items-center gap-4 w-full rounded-lg">
       <div class="leading-5 text-nc-content-gray">This action cannot be undone.</div>
     </div>
 

From cc3dbe2cad689cadb92808a858391008f1084a0a Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Fri, 6 Dec 2024 07:00:37 +0000
Subject: [PATCH 6/6] fix: select all records tests

---
 .../smartsheet/grid/InfiniteTable.vue         | 26 ++++++++++---------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue b/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue
index 720b00e985..8ee6663508 100644
--- a/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue
+++ b/packages/nc-gui/components/smartsheet/grid/InfiniteTable.vue
@@ -1775,9 +1775,8 @@ watch(
   },
 )
 
-
 const toggleRowSelection = (row: number) => {
-  if(vSelectedAllRecords.value) return
+  if (vSelectedAllRecords.value) return
   const data = cachedRows.value.get(row)
 
   if (!data) return
@@ -1795,7 +1794,6 @@ watch(vSelectedAllRecords, (selectedAll) => {
     }
   }
 })
-
 </script>
 
 <template>
@@ -1828,7 +1826,7 @@ watch(vSelectedAllRecords, (selectedAll) => {
     <div ref="gridWrapper" class="nc-grid-wrapper min-h-0 flex-1 relative !overflow-auto">
       <NcDropdown
         v-model:visible="contextMenu"
-        :disabled="contextMenuTarget === null && (!selectedRows.length && !vSelectedAllRecords)"
+        :disabled="contextMenuTarget === null && !selectedRows.length && !vSelectedAllRecords"
         :trigger="isSqlView ? [] : ['contextmenu']"
         overlay-class-name="nc-dropdown-grid-context-menu"
       >
@@ -1875,14 +1873,19 @@ watch(vSelectedAllRecords, (selectedAll) => {
                   }"
                   data-testid="grid-id-column"
                 >
-
-                  <div class="flex items-center pl-2 pr-1 w-full h-full justify-center" v-if="!readOnly">
-                    <div class="nc-no-label text-gray-500" :class="{ hidden: vSelectedAllRecords }">#</div>
+                  <div
+                    v-if="!readOnly"
+                    data-testid="nc-check-all"
+                    class="flex items-center pl-2 pr-1 w-full h-full justify-center"
+                  >
+                    <div class="nc-no-label text-gray-500"  :class="{ hidden: vSelectedAllRecords }">
+                      #
+                    </div>
                     <div
                       :class="{
-                          hidden: !vSelectedAllRecords,
-                          flex: vSelectedAllRecords,
-                        }"
+                        hidden: !vSelectedAllRecords,
+                        flex: vSelectedAllRecords,
+                      }"
                       class="nc-check-all w-full items-center"
                     >
                       <NcCheckbox v-model:checked="vSelectedAllRecords" />
@@ -1893,7 +1896,6 @@ watch(vSelectedAllRecords, (selectedAll) => {
                   <template v-else>
                     <div class="w-full h-full text-gray-500 flex pl-2 pr-1 items-center" data-testid="nc-check-all">#</div>
                   </template>
-
                 </th>
                 <th
                   v-if="fields[0] && fields[0].id"
@@ -2225,7 +2227,7 @@ watch(vSelectedAllRecords, (selectedAll) => {
                           >
                             <NcCheckbox
                               :checked="row.rowMeta.selected || vSelectedAllRecords"
-                              :disabled="!row.rowMeta.selected && selectedRows.length > 100 || vSelectedAllRecords"
+                              :disabled="(!row.rowMeta.selected && selectedRows.length > 100) || vSelectedAllRecords"
                               @change="toggleRowSelection(row.rowMeta.rowIndex)"
                             />
                           </div>