From 6890f7431b45122f4ad8a89f73a8d4f991d308ce Mon Sep 17 00:00:00 2001
From: DarkPhoenix2704 <anbarasun123@gmail.com>
Date: Mon, 27 May 2024 13:25:03 +0000
Subject: [PATCH] fix: use batchInsert with transaction

---
 .../migrations/v2/nc_046_comment_mentions.ts  | 113 ++++++++++--------
 1 file changed, 66 insertions(+), 47 deletions(-)

diff --git a/packages/nocodb/src/meta/migrations/v2/nc_046_comment_mentions.ts b/packages/nocodb/src/meta/migrations/v2/nc_046_comment_mentions.ts
index 653f3be43a..2153475524 100644
--- a/packages/nocodb/src/meta/migrations/v2/nc_046_comment_mentions.ts
+++ b/packages/nocodb/src/meta/migrations/v2/nc_046_comment_mentions.ts
@@ -4,6 +4,8 @@ import { MetaTable } from '~/utils/globals';
 
 const logger = new Logger('nc_046_comment_mentions');
 
+const BATCH_SIZE = 5000;
+
 const up = async (knex: Knex) => {
   await knex.schema.createTable(MetaTable.COMMENTS, (table) => {
     table.string('id', 20).primary();
@@ -42,7 +44,7 @@ const up = async (knex: Knex) => {
 
       table.string('row_id', 255);
 
-      table.string('user_id', 255);
+      table.string('user_id', 20);
 
       table.string('fk_model_id', 20);
 
@@ -70,7 +72,7 @@ const up = async (knex: Knex) => {
 
     table.string('source_id', 20);
 
-    table.string('fk_modal_id', 20);
+    table.string('fk_model_id', 20);
 
     table.string('base_id', 128);
 
@@ -83,52 +85,69 @@ const up = async (knex: Knex) => {
 
   logger.log('nc_046_comment_mentions: Tables Created');
 
-  knex
-    .select(
-      `${MetaTable.AUDIT}.id`,
-      `${MetaTable.AUDIT}.row_id`,
-      `${MetaTable.AUDIT}.description`,
-      `${MetaTable.AUDIT}.user as user_email`,
-      `${MetaTable.AUDIT}.source_id`,
-      `${MetaTable.AUDIT}.base_id`,
-      `${MetaTable.AUDIT}.fk_model_id`,
-      `${MetaTable.AUDIT}.created_at`,
-      `${MetaTable.AUDIT}.updated_at`,
-      `${MetaTable.USERS}.id as user_id`,
-    )
-    .from(MetaTable.AUDIT)
-    .where(`${MetaTable.AUDIT}.op_type`, 'COMMENT')
-    .leftJoin(
-      MetaTable.USERS,
-      `${MetaTable.AUDIT}.user`,
-      `${MetaTable.USERS}.email`,
-    )
-    .then(async (rows) => {
-      if (!rows.length) return;
-
-      logger.log('nc_046_comment_mentions: Data from Audit Table Selected');
-
-      const formattedRows = rows.map((row) => ({
-        id: row.id,
-        row_id: row.row_id,
-        comment: row.description
-          .substring(row.description.indexOf(':') + 1)
-          .trim(),
-        created_by: row.user_id,
-        created_by_email: row.user_email,
-        source_id: row.source_id,
-        base_id: row.base_id,
-        fk_model_id: row.fk_model_id,
-        created_at: row.created_at,
-        updated_at: row.updated_at,
-      }));
-
-      logger.log('nc_046_comment_mentions: Data from Audit Table Formatted');
-
-      await knex(MetaTable.COMMENTS).insert(formattedRows);
-
-      logger.log('nc_046_comment_mentions: Data from Audit Table Migrated');
+  try {
+    logger.log('nc_046_comment_mentions: Fetching Data from Audit Table');
+
+    const rows = await knex
+      .select(
+        `${MetaTable.AUDIT}.id`,
+        `${MetaTable.AUDIT}.row_id`,
+        `${MetaTable.AUDIT}.description`,
+        `${MetaTable.AUDIT}.user as user_email`,
+        `${MetaTable.AUDIT}.source_id`,
+        `${MetaTable.AUDIT}.base_id`,
+        `${MetaTable.AUDIT}.fk_model_id`,
+        `${MetaTable.AUDIT}.created_at`,
+        `${MetaTable.AUDIT}.updated_at`,
+        `${MetaTable.USERS}.id as user_id`,
+      )
+      .from(MetaTable.AUDIT)
+      .where(`${MetaTable.AUDIT}.op_type`, 'COMMENT')
+      .leftJoin(
+        MetaTable.USERS,
+        `${MetaTable.AUDIT}.user`,
+        `${MetaTable.USERS}.email`,
+      );
+
+    logger.log('nc_046_comment_mentions: Data from Audit Table fetched');
+
+    if (!rows.length) {
+      logger.log(
+        'nc_046_comment_mentions: No Data Found to Migrate from Audit Table',
+      );
+      return;
+    }
+    const formattedRows = rows.map((row) => ({
+      id: row.id,
+      row_id: row.row_id,
+      comment: (row.description ?? '')
+        .substring((row.description ?? '').indexOf(':') + 1)
+        .trim(),
+      created_by: row.user_id,
+      created_by_email: row.user_email,
+      source_id: row.source_id,
+      base_id: row.base_id,
+      fk_model_id: row.fk_model_id,
+      created_at: row.created_at,
+      updated_at: row.updated_at,
+    }));
+
+    logger.log('nc_046_comment_mentions: Data from Audit Table formatted');
+
+    await knex.transaction(function (trx) {
+      return knex
+        .batchInsert(MetaTable.COMMENTS, formattedRows, BATCH_SIZE)
+        .transacting(trx);
     });
+
+    logger.log(
+      'nc_046_comment_mentions: Data migrated from Audit Table to Comments Table',
+    );
+  } catch (error) {
+    logger.error(
+      'nc_046_comment_mentions: Error while migrating data from Audit Table',
+    );
+  }
 };
 
 const down = async (knex: Knex) => {