From 67801754c0ac6d1a265bd95308666ec0b04f4999 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Wed, 13 Mar 2024 21:16:13 +0000
Subject: [PATCH] fix(nc-gui): some browser console warnings

---
 packages/nc-gui/components/account/Profile.vue    |  2 +-
 packages/nc-gui/components/account/Token.vue      |  6 +++---
 packages/nc-gui/components/account/UserList.vue   |  4 ++--
 packages/nc-gui/components/nc/Switch.vue          |  3 ++-
 .../nc-gui/components/project/AccessSettings.vue  |  2 +-
 packages/nc-gui/components/roles/Selector.vue     |  4 ++--
 packages/nc-gui/components/smartsheet/Form.vue    |  2 +-
 .../smartsheet/toolbar/ViewActionMenu.vue         | 15 ++++++++++-----
 .../components/workspace/CollaboratorsList.vue    |  2 +-
 .../nc-gui/components/workspace/InviteSection.vue |  2 +-
 10 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/packages/nc-gui/components/account/Profile.vue b/packages/nc-gui/components/account/Profile.vue
index 30fbc61c7d..8aeaed23a5 100644
--- a/packages/nc-gui/components/account/Profile.vue
+++ b/packages/nc-gui/components/account/Profile.vue
@@ -94,7 +94,7 @@ const onValidate = async (_: any, valid: boolean) => {
             <a-input
               v-model:value="email"
               class="w-full !rounded-md !py-1.5"
-              :placeholder="$t('general.email')"
+              :placeholder="$t('labels.email')"
               disabled
               data-testid="nc-account-settings-email-input"
             />
diff --git a/packages/nc-gui/components/account/Token.vue b/packages/nc-gui/components/account/Token.vue
index 9c3d612fb0..70ede150e8 100644
--- a/packages/nc-gui/components/account/Token.vue
+++ b/packages/nc-gui/components/account/Token.vue
@@ -312,17 +312,17 @@ const handleCancel = () => {
               class="flex pl-5 py-3 justify-between token items-center border-l-1 border-r-1 border-b-1"
             >
               <span class="text-black font-bold text-3.5 text-start w-2/9">
-                <GeneralTruncateText placement="top" length="20">
+                <GeneralTruncateText placement="top" :length="20">
                   {{ el.description }}
                 </GeneralTruncateText>
               </span>
               <span class="text-gray-500 font-medium text-3.5 text-start w-2/9">
-                <GeneralTruncateText placement="top" length="20">
+                <GeneralTruncateText placement="top" :length="20">
                   {{ el.created_by }}
                 </GeneralTruncateText>
               </span>
               <span class="text-gray-500 font-medium text-3.5 text-start w-3/9">
-                <GeneralTruncateText v-if="el.token === selectedToken.id && selectedToken.isShow" placement="top" length="29">
+                <GeneralTruncateText v-if="el.token === selectedToken.id && selectedToken.isShow" placement="top" :length="29">
                   {{ el.token }}
                 </GeneralTruncateText>
                 <span v-else>************************************</span>
diff --git a/packages/nc-gui/components/account/UserList.vue b/packages/nc-gui/components/account/UserList.vue
index 410e23e820..87458a8467 100644
--- a/packages/nc-gui/components/account/UserList.vue
+++ b/packages/nc-gui/components/account/UserList.vue
@@ -239,11 +239,11 @@ const openDeleteModal = (user: UserType) => {
                 <template #title>
                   {{ el.email }}
                 </template>
-                <GeneralTruncateText length="29">
+                <GeneralTruncateText :length="29">
                   {{ el.display_name }}
                 </GeneralTruncateText>
               </NcTooltip>
-              <GeneralTruncateText v-else length="29">
+              <GeneralTruncateText v-else :length="29">
                 {{ el.email }}
               </GeneralTruncateText>
             </div>
diff --git a/packages/nc-gui/components/nc/Switch.vue b/packages/nc-gui/components/nc/Switch.vue
index 9f50ce0d38..f5d9af077e 100644
--- a/packages/nc-gui/components/nc/Switch.vue
+++ b/packages/nc-gui/components/nc/Switch.vue
@@ -13,7 +13,8 @@ const onChange = (e: boolean) => {
 </script>
 
 <template>
-  <a-switch v-model:checked="checked" :disabled="disabled" class="nc-switch" :size="size" @change="onChange"> </a-switch>
+  <a-switch v-model:checked="checked" :disabled="disabled" class="nc-switch" v-bind="$attrs" :size="size" @change="onChange">
+  </a-switch>
   <span v-if="$slots.default" class="cursor-pointer pl-2" @click="checked = !checked">
     <slot />
   </span>
diff --git a/packages/nc-gui/components/project/AccessSettings.vue b/packages/nc-gui/components/project/AccessSettings.vue
index 9b004a550c..6c5b16f420 100644
--- a/packages/nc-gui/components/project/AccessSettings.vue
+++ b/packages/nc-gui/components/project/AccessSettings.vue
@@ -224,7 +224,7 @@ watch(isInviteModalVisible, () => {
                         : null
                     "
                     :description="false"
-                    :on-role-change="(role: ProjectRoles) => updateCollaborator(collab, role)"
+                    :on-role-change="(role) => updateCollaborator(collab, role as ProjectRoles)"
                   />
                 </template>
                 <template v-else>
diff --git a/packages/nc-gui/components/roles/Selector.vue b/packages/nc-gui/components/roles/Selector.vue
index 79308fb1ef..f3ba95290e 100644
--- a/packages/nc-gui/components/roles/Selector.vue
+++ b/packages/nc-gui/components/roles/Selector.vue
@@ -11,7 +11,7 @@ const props = withDefaults(
     description?: boolean
     inherit?: string
     onRoleChange: (role: keyof typeof RoleLabels) => void
-    size: 'sm' | 'md' | 'lg'
+    size?: 'sm' | 'md' | 'lg'
   }>(),
   {
     description: true,
@@ -38,7 +38,7 @@ function onChangeRole(val: SelectValue) {
   <div ref="dropdownRef" size="lg" class="nc-roles-selector relative" @click="isDropdownOpen = !isDropdownOpen">
     <RolesBadge data-testid="roles" :role="roleRef" :inherit="inheritRef === role" :size="sizeRef" clickable />
     <a-select
-      v-model:value="roleRef"
+      :value="roleRef"
       :open="isDropdownOpen"
       :dropdown-match-select-width="false"
       dropdown-class-name="!rounded-lg !h-fit max-w-[350px] nc-role-selector-dropdown"
diff --git a/packages/nc-gui/components/smartsheet/Form.vue b/packages/nc-gui/components/smartsheet/Form.vue
index 59ad63bfa0..33b6c275cf 100644
--- a/packages/nc-gui/components/smartsheet/Form.vue
+++ b/packages/nc-gui/components/smartsheet/Form.vue
@@ -456,7 +456,7 @@ async function submitCallback() {
 }
 
 const updateColMeta = useDebounceFn(async (col: Record<string, any>) => {
-  if (col.id) {
+  if (col.id && isEditable) {
     try {
       await $api.dbView.formColumnUpdate(col.id, col)
     } catch (e: any) {
diff --git a/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue
index b171b0c9c1..65a0efd5bc 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ViewActionMenu.vue
@@ -3,11 +3,16 @@ import type { TableType, ViewType } from 'nocodb-sdk'
 import { ViewTypes } from 'nocodb-sdk'
 import { LockType } from '~/lib'
 
-const props = defineProps<{
-  view: ViewType
-  table: TableType
-  inSidebar: boolean
-}>()
+const props = withDefaults(
+  defineProps<{
+    view: ViewType
+    table: TableType
+    inSidebar?: boolean
+  }>(),
+  {
+    inSidebar: false,
+  },
+)
 
 const emits = defineEmits(['rename', 'closeModal', 'delete'])
 
diff --git a/packages/nc-gui/components/workspace/CollaboratorsList.vue b/packages/nc-gui/components/workspace/CollaboratorsList.vue
index 4815dcb5df..32292bdd62 100644
--- a/packages/nc-gui/components/workspace/CollaboratorsList.vue
+++ b/packages/nc-gui/components/workspace/CollaboratorsList.vue
@@ -118,7 +118,7 @@ onMounted(async () => {
                     :roles="accessibleRoles"
                     :description="false"
                     class="cursor-pointer"
-                    :on-role-change="(role: WorkspaceUserRoles) => updateCollaborator(collab, role)"
+                    :on-role-change="(role) => updateCollaborator(collab, role as WorkspaceUserRoles)"
                   />
                 </div>
               </template>
diff --git a/packages/nc-gui/components/workspace/InviteSection.vue b/packages/nc-gui/components/workspace/InviteSection.vue
index 0f88e387ed..6b8ab2710d 100644
--- a/packages/nc-gui/components/workspace/InviteSection.vue
+++ b/packages/nc-gui/components/workspace/InviteSection.vue
@@ -242,7 +242,7 @@ const onPaste = (e: ClipboardEvent) => {
         class="px-1 min-w-[152px] nc-invite-role-selector"
         :role="inviteData.roles"
         :roles="allowedRoles"
-        :on-role-change="(role: WorkspaceUserRoles) => (inviteData.roles = role)"
+        :on-role-change="(role) => (inviteData.roles = role as WorkspaceUserRoles)"
         :description="true"
       />