From 6653e8e7cc2ede6af1d288eed3e339917b4cf606 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Tue, 24 Sep 2024 20:10:16 +0530
Subject: [PATCH] Nc fix/dev warnings (#9541)

* fix(nc-gui): div cannot be child of table

* fix(nc-gui): div cannot be child of tr
---
 .../settings/app-store/AppInstall.vue         | 20 +++++++++--------
 .../components/smartsheet/grid/Table.vue      | 22 +++++++++----------
 2 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/settings/app-store/AppInstall.vue b/packages/nc-gui/components/dashboard/settings/app-store/AppInstall.vue
index 8b3f59b701..3030418728 100644
--- a/packages/nc-gui/components/dashboard/settings/app-store/AppInstall.vue
+++ b/packages/nc-gui/components/dashboard/settings/app-store/AppInstall.vue
@@ -219,15 +219,17 @@ onMounted(async () => {
               </tr>
             </tbody>
 
-            <tr>
-              <td :colspan="plugin.formDetails.items.length" class="text-center">
-                <a-button type="default" class="!bg-gray-100 rounded-md border-none mr-1" @click="addSetting">
-                  <template #icon>
-                    <component :is="iconMap.plus" class="flex mx-auto" />
-                  </template>
-                </a-button>
-              </td>
-            </tr>
+            <tfoot>
+              <tr>
+                <td :colspan="plugin.formDetails.items.length" class="text-center">
+                  <a-button type="default" class="!bg-gray-100 rounded-md border-none mr-1" @click="addSetting">
+                    <template #icon>
+                      <component :is="iconMap.plus" class="flex mx-auto" />
+                    </template>
+                  </a-button>
+                </td>
+              </tr>
+            </tfoot>
           </table>
         </div>
 
diff --git a/packages/nc-gui/components/smartsheet/grid/Table.vue b/packages/nc-gui/components/smartsheet/grid/Table.vue
index 2a2848fcb1..7f6f6db9a9 100644
--- a/packages/nc-gui/components/smartsheet/grid/Table.vue
+++ b/packages/nc-gui/components/smartsheet/grid/Table.vue
@@ -2213,8 +2213,8 @@ onKeyStroke('ArrowDown', onDown)
                   @mouseup.stop
                   @click="addEmptyRow()"
                 >
-                  <div
-                    class="h-8 border-b-1 border-gray-100 bg-white group-hover:bg-gray-50 absolute left-0 bottom-0 px-2 sticky z-40 w-full flex items-center text-gray-500"
+                  <td
+                    class="nc-grid-add-new-cell-item h-8 border-b-1 border-gray-100 bg-white group-hover:bg-gray-50 absolute left-0 bottom-0 px-2 sticky z-40 w-full flex items-center text-gray-500"
                     :style="{
                       left: `-${leftOffset}px`,
                     }"
@@ -2224,7 +2224,7 @@ onKeyStroke('ArrowDown', onDown)
                       v-if="!isViewColumnsLoading"
                       class="text-pint-500 text-base ml-2 mt-0 text-gray-600 group-hover:text-black"
                     />
-                  </div>
+                  </td>
                   <td class="!border-gray-100" :colspan="visibleColLength"></td>
                 </tr>
               </tbody>
@@ -2595,7 +2595,7 @@ onKeyStroke('ArrowDown', onDown)
     @apply text-black !bg-gray-50;
   }
 
-  td,
+  td:not(.nc-grid-add-new-cell-item),
   th {
     @apply border-gray-100 border-solid border-r bg-gray-100 p-0;
     min-height: 32px !important;
@@ -2620,11 +2620,11 @@ onKeyStroke('ArrowDown', onDown)
     @apply !border-b-1;
   }
 
-  td {
+  td:not(.nc-grid-add-new-cell-item) {
     @apply bg-white border-b;
   }
 
-  td:not(:first-child) {
+  td:not(:first-child):not(.nc-grid-add-new-cell-item) {
     @apply px-3;
 
     &.align-top {
@@ -2742,7 +2742,7 @@ onKeyStroke('ArrowDown', onDown)
     border-spacing: 0;
   }
 
-  td {
+  td:not(.nc-grid-add-new-cell-item) {
     text-overflow: ellipsis;
   }
 
@@ -2798,7 +2798,7 @@ onKeyStroke('ArrowDown', onDown)
     z-index: 5;
   }
 
-  tbody td:nth-child(1) {
+  tbody td:not(.nc-grid-add-new-cell-item):nth-child(1) {
     position: sticky !important;
     left: 0;
     z-index: 4;
@@ -2827,7 +2827,7 @@ onKeyStroke('ArrowDown', onDown)
       @apply border-r-1 !border-r-gray-50;
     }
 
-    tbody td:nth-child(2) {
+    tbody td:not(.nc-grid-add-new-cell-item):nth-child(2) {
       @apply border-r-1 !border-r-gray-50;
     }
   }
@@ -2887,7 +2887,7 @@ onKeyStroke('ArrowDown', onDown)
 
   &:not(.selected-row):has(+ .selected-row) {
     td.nc-grid-cell:not(.active),
-    td:nth-child(2):not(.active) {
+    td:nth-child(2):not(.active):not(.nc-grid-add-new-cell-item) {
       @apply border-b-gray-200;
     }
   }
@@ -2896,7 +2896,7 @@ onKeyStroke('ArrowDown', onDown)
   &:not(.mouse-down):has(+ :hover) {
     &:not(.selected-row) {
       td.nc-grid-cell:not(.active),
-      td:nth-child(2):not(.active) {
+      td:nth-child(2):not(.active):not(.nc-grid-add-new-cell-item) {
         @apply border-b-gray-200;
       }
     }