From 65c0a6f09275588f33ec157777346970e3cefb73 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Wed, 19 Oct 2022 10:36:41 +0530 Subject: [PATCH] fix(api): typo correction Signed-off-by: Pranav C --- packages/nocodb/src/lib/meta/api/orgUserApis.ts | 5 +++-- packages/nocodb/src/lib/meta/helpers/ncMetaAclMw.ts | 2 +- packages/nocodb/src/lib/models/User.ts | 6 +++--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/nocodb/src/lib/meta/api/orgUserApis.ts b/packages/nocodb/src/lib/meta/api/orgUserApis.ts index 8647f06b24..bd00e1005a 100644 --- a/packages/nocodb/src/lib/meta/api/orgUserApis.ts +++ b/packages/nocodb/src/lib/meta/api/orgUserApis.ts @@ -2,6 +2,7 @@ import { Router } from 'express'; import { OrgUserRoles } from '../../../enums/OrgUserRoles'; import User from '../../models/User'; import { metaApiMetrics } from '../helpers/apiMetrics'; +import { NcError } from '../helpers/catchError'; import { extractProps } from '../helpers/extractProps'; import ncMetaAclMw from '../helpers/ncMetaAclMw'; import { PagedResponseImpl } from '../helpers/PagedResponse'; @@ -37,8 +38,8 @@ async function userDelete(req, res) { res.json(await User.delete(req.params.userId)); } -async function userAdd(req, res) { - +async function userAdd(_req, _res) { + NcError.notImplemented(); } const router = Router({ mergeParams: true }); diff --git a/packages/nocodb/src/lib/meta/helpers/ncMetaAclMw.ts b/packages/nocodb/src/lib/meta/helpers/ncMetaAclMw.ts index f8fef0e617..9454ba6548 100644 --- a/packages/nocodb/src/lib/meta/helpers/ncMetaAclMw.ts +++ b/packages/nocodb/src/lib/meta/helpers/ncMetaAclMw.ts @@ -21,7 +21,7 @@ export default function ( roles?.editor || roles?.viewer || roles?.commenter || - roles?.[OrgUserRoles.SUPER] ||a + roles?.[OrgUserRoles.SUPER] || roles?.[OrgUserRoles.CREATOR] || roles?.[OrgUserRoles.VIEWER] ) diff --git a/packages/nocodb/src/lib/models/User.ts b/packages/nocodb/src/lib/models/User.ts index e3b819005c..670dda2523 100644 --- a/packages/nocodb/src/lib/models/User.ts +++ b/packages/nocodb/src/lib/models/User.ts @@ -1,5 +1,5 @@ import { UserType } from 'nocodb-sdk'; -import { NcError } from '../meta/helpers/catchError' +import { NcError } from '../meta/helpers/catchError'; import { CacheGetType, CacheScope, MetaTable } from '../utils/globals'; import Noco from '../Noco'; import { extractProps } from '../meta/helpers/extractProps'; @@ -227,7 +227,7 @@ export default class User implements UserType { await ncMeta.metaDelete(null, null, MetaTable.USERS, userId); } - static async delete(_userId:string) { - NcError.notImplemented() + static async delete(_userId: string) { + NcError.notImplemented(); } }