From 646ff49e82c4477c2da3c48fb1342fa3ef1f9463 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Fri, 14 Jun 2024 22:25:49 +0530 Subject: [PATCH] fix: on delete find index using id since index could change while deleting Signed-off-by: Pranav C --- packages/nc-gui/composables/useViewFilters.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/nc-gui/composables/useViewFilters.ts b/packages/nc-gui/composables/useViewFilters.ts index 0326f8bb85..ad61e79872 100644 --- a/packages/nc-gui/composables/useViewFilters.ts +++ b/packages/nc-gui/composables/useViewFilters.ts @@ -502,9 +502,11 @@ export function useViewFilters( } else { try { await $api.dbTableFilter.delete(filter.id) - if (!isWebhook && !isLink) reloadData?.() - filters.value.splice(i, 1) + + // find item index by using id and remove it from array since item index may change + const itemIndex = filters.value.findIndex((f) => f.id === filter.id) + if (itemIndex > -1) filters.value.splice(itemIndex) } catch (e: any) { console.log(e) message.error(await extractSdkResponseErrorMsg(e))