From 62e4ecdf00361cdc0683fea1c5dc6b83708e2ee2 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 10 Apr 2023 18:19:17 +0530
Subject: [PATCH] fix: attachment upload api corrections

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../extract-project-id.middleware.ts          |  1 -
 .../attachments/attachments.controller.ts     | 27 ++++++++++++++++---
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/packages/nocodb-nest/src/middlewares/extract-project-id/extract-project-id.middleware.ts b/packages/nocodb-nest/src/middlewares/extract-project-id/extract-project-id.middleware.ts
index f8d0a3a2c8..e6da15ac3d 100644
--- a/packages/nocodb-nest/src/middlewares/extract-project-id/extract-project-id.middleware.ts
+++ b/packages/nocodb-nest/src/middlewares/extract-project-id/extract-project-id.middleware.ts
@@ -190,7 +190,6 @@ export class ExtractProjectIdMiddleware implements NestMiddleware, CanActivate {
       context.switchToHttp().getRequest(),
       context.switchToHttp().getResponse(),
       () => {
-        console.log('next');
       },
     );
     return true;
diff --git a/packages/nocodb-nest/src/modules/attachments/attachments.controller.ts b/packages/nocodb-nest/src/modules/attachments/attachments.controller.ts
index eeb467063e..e907c7ccf2 100644
--- a/packages/nocodb-nest/src/modules/attachments/attachments.controller.ts
+++ b/packages/nocodb-nest/src/modules/attachments/attachments.controller.ts
@@ -7,11 +7,14 @@ import {
   Query,
   Request,
   Response,
+  UploadedFiles,
   UseInterceptors,
 } from '@nestjs/common';
-import { FileInterceptor } from '@nestjs/platform-express';
+import  multer  from 'multer';
+import { FileInterceptor, FilesInterceptor } from '@nestjs/platform-express'
 import { OrgUserRoles, ProjectRoles } from 'nocodb-sdk';
 import path from 'path';
+import { NC_ATTACHMENT_FIELD_SIZE } from '../../constants'
 import { NcError } from '../../helpers/catchError';
 import Noco from '../../Noco';
 import { MetaTable } from '../../utils/globals';
@@ -66,10 +69,26 @@ export class AttachmentsController {
     //   ]
     // );
   )
-  @UseInterceptors(FileInterceptor('files'))
-  async upload(@Request() req: any, @Query('path') path: string) {
+  @UseInterceptors(
+
+    FilesInterceptor('files[]', null,{
+      storage: multer.diskStorage({}),
+      // limits: {
+      //   fieldSize: NC_ATTACHMENT_FIELD_SIZE,
+      // },
+      limits: {
+        fileSize: NC_ATTACHMENT_FIELD_SIZE,
+      },
+    }),
+  )
+  async upload(
+    @UploadedFiles() files: Array<any>,
+    @Body() body: any,
+    @Request() req: any,
+    @Query('path') path: string,
+  ) {
     const attachments = await this.attachmentsService.upload({
-      files: (req as any).files,
+      files: files,
       path: req.query?.path as string,
     });