From 62414238caac2d11badbb5251fbabf10a6e08133 Mon Sep 17 00:00:00 2001
From: IFGGit <162738418+IFGGit@users.noreply.github.com>
Date: Sat, 16 Mar 2024 10:52:07 +0200
Subject: [PATCH] fix(nc-gui): Hide Rename, Delete, Add record buttons when
 user doesn't have necessary permissions (#7871)

* fix(nc-gui): Remove tableRename, tableDelete from org level role permissions

For hiding Rename and Delete buttons in table context menu.

* fix(nc-gui): Hide Add record button when user doesn't have dataInsert permission
---
 .../nc-gui/components/dashboard/TreeView/ProjectNode.vue    | 2 +-
 packages/nc-gui/components/smartsheet/Kanban.vue            | 6 +++++-
 packages/nc-gui/lib/acl.ts                                  | 2 --
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
index b173089da6..80d9bf86c2 100644
--- a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
@@ -766,7 +766,7 @@ const projectDelete = () => {
             </div>
           </NcMenuItem>
           <NcDivider />
-          <NcMenuItem v-if="isUIAllowed('table-delete')" class="!hover:bg-red-50" @click="tableDelete">
+          <NcMenuItem v-if="isUIAllowed('tableDelete')" class="!hover:bg-red-50" @click="tableDelete">
             <div class="nc-base-option-item flex gap-2 items-center text-red-600">
               <GeneralIcon icon="delete" />
               {{ $t('general.delete') }}
diff --git a/packages/nc-gui/components/smartsheet/Kanban.vue b/packages/nc-gui/components/smartsheet/Kanban.vue
index 943f9c1c39..f1e210669c 100644
--- a/packages/nc-gui/components/smartsheet/Kanban.vue
+++ b/packages/nc-gui/components/smartsheet/Kanban.vue
@@ -513,7 +513,10 @@ const getRowId = (row: RowType) => {
                     </div>
                   </a-layout-header>
 
-                  <a-layout-content class="overflow-y-hidden mt-1" style="max-height: calc(100% - 11rem)">
+                  <a-layout-content
+                    class="overflow-y-hidden mt-1"
+                    :style="{ maxHeight: isUIAllowed('dataInsert') ? 'calc(100% - 11rem)' : 'calc(100% - 8rem)' }"
+                  >
                     <div :ref="kanbanListRef" class="nc-kanban-list h-full nc-scrollbar-dark-md" :data-stack-title="stack.title">
                       <!-- Draggable Record Card -->
                       <Draggable
@@ -665,6 +668,7 @@ const getRowId = (row: RowType) => {
                       </div>
 
                       <div
+                        v-if="isUIAllowed('dataInsert')"
                         class="flex flex-row w-full mt-3 justify-between items-center cursor-pointer bg-white px-4 py-2 rounded-lg border-gray-100 border-1 shadow-sm shadow-gray-100"
                         @click="
                           () => {
diff --git a/packages/nc-gui/lib/acl.ts b/packages/nc-gui/lib/acl.ts
index b13b2b9524..c38247b0ce 100644
--- a/packages/nc-gui/lib/acl.ts
+++ b/packages/nc-gui/lib/acl.ts
@@ -34,8 +34,6 @@ const rolePermissions = {
       baseDelete: true,
       baseDuplicate: true,
       newUser: true,
-      tableRename: true,
-      tableDelete: true,
       viewCreateOrEdit: true,
       baseReorder: true,
     },