From 60be7e730de70e3ae5b6545e240c5cd936d44291 Mon Sep 17 00:00:00 2001 From: Muhammed Mustafa Date: Wed, 17 Aug 2022 10:37:38 +0530 Subject: [PATCH] fix/removed url validation when it is not required --- packages/nc-gui-v2/components.d.ts | 1 + packages/nc-gui-v2/components/cell/Url.vue | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/nc-gui-v2/components.d.ts b/packages/nc-gui-v2/components.d.ts index 6ff3d158bd..35b9712b59 100644 --- a/packages/nc-gui-v2/components.d.ts +++ b/packages/nc-gui-v2/components.d.ts @@ -155,6 +155,7 @@ declare module '@vue/runtime-core' { MdiRefresh: typeof import('~icons/mdi/refresh')['default'] MdiReload: typeof import('~icons/mdi/reload')['default'] MdiRocketLaunchOutline: typeof import('~icons/mdi/rocket-launch-outline')['default'] + MdiScriptTextKeyOutline: typeof import('~icons/mdi/script-text-key-outline')['default'] MdiScriptTextOutline: typeof import('~icons/mdi/script-text-outline')['default'] MdiSearch: typeof import('~icons/mdi/search')['default'] MdiShieldLockOutline: typeof import('~icons/mdi/shield-lock-outline')['default'] diff --git a/packages/nc-gui-v2/components/cell/Url.vue b/packages/nc-gui-v2/components/cell/Url.vue index 1722797e24..7b3e4b584e 100644 --- a/packages/nc-gui-v2/components/cell/Url.vue +++ b/packages/nc-gui-v2/components/cell/Url.vue @@ -44,8 +44,10 @@ const focus: VNodeRef = (el) => (el as HTMLInputElement)?.focus() watch( () => editEnabled.value, () => { - if (!editEnabled.value && localState.value && !isValidURL(localState.value)) { + if (column.value.meta?.validate && !editEnabled.value && localState.value && !isValidURL(localState.value)) { message.error('Invalid URL') + localState.value = undefined + return } localState.value = value },