From 5dda4c7d373a39e15c26b3f713126ed863a2c538 Mon Sep 17 00:00:00 2001 From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com> Date: Sat, 22 Jun 2024 20:28:26 +0530 Subject: [PATCH] Nc fix: misc UI fixes (#8827) * fix(nc-gui): external source text bold issue * fix(nc-gui): make new record btn sticky to left in groupby * fix(nc-gui): add some padding after add column header btn * fix(nc-gui): links cell margin issue * fix(nc-gui): groupby table footer issue * chore(nc-gui): lint * fix(test): pw test fail issue * fix(test): pw test fail issue * fix(test): remove only from test --- .../components/cell/attachment/index.vue | 4 +- .../dashboard/TreeView/ProjectNode.vue | 12 +- .../components/smartsheet/Pagination.vue | 6 +- .../smartsheet/column/RatingOptions.vue | 7 +- .../components/smartsheet/grid/GroupBy.vue | 4 +- .../smartsheet/grid/GroupByTable.vue | 25 +-- .../components/smartsheet/grid/Table.vue | 194 ++++++++++-------- .../components/virtual-cell/BelongsTo.vue | 2 +- .../components/virtual-cell/HasMany.vue | 4 +- .../nc-gui/components/virtual-cell/Links.vue | 2 +- .../nc-gui/components/virtual-cell/Lookup.vue | 11 +- .../components/virtual-cell/ManyToMany.vue | 4 +- .../components/virtual-cell/OneToOne.vue | 4 +- .../virtual-cell/components/ItemChip.vue | 2 +- packages/nocodb/src/models/BaseUser.ts | 2 +- .../pages/Dashboard/Grid/Column/index.ts | 4 +- .../db/features/multiFieldEditor.spec.ts | 11 +- 17 files changed, 149 insertions(+), 149 deletions(-) diff --git a/packages/nc-gui/components/cell/attachment/index.vue b/packages/nc-gui/components/cell/attachment/index.vue index a95f1c4da8..d4fa5b98c9 100644 --- a/packages/nc-gui/components/cell/attachment/index.vue +++ b/packages/nc-gui/components/cell/attachment/index.vue @@ -270,7 +270,7 @@ const handleFileDelete = (i: number) => { 'py-1': rowHeight === 1 && !isForm && !isExpandedForm, 'py-1.5': rowHeight !== 1 || isForm || isExpandedForm, }" - class="nc-attachment-wrapper flex cursor-pointer w-full items-center flex-wrap gap-2 scrollbar-thin-dull overflow-hidden mt-0 items-start" + class="nc-attachment-wrapper flex cursor-pointer w-full items-center flex-wrap gap-2 nc-scrollbar-thin mt-0 items-start px-[1px]" :style="{ maxHeight: isForm || isExpandedForm ? undefined : `max(100%, ${isGrid ? '22px' : '32px'})`, }" @@ -318,7 +318,7 @@ const handleFileDelete = (i: number) => { - + { v-if="source.id && sourceRenameHelpers[source.id]?.editMode" ref="input" v-model="sourceRenameHelpers[source.id].tempTitle" - class="flex-grow leading-1 outline-0 ring-none capitalize !text-inherit !bg-transparent flex-1 mr-4" - :class=" - activeProjectId === base.id && baseViewOpen ? '!text-brand-600 !font-semibold' : '!text-gray-700' - " + class="flex-grow leading-1 outline-0 ring-none capitalize !text-inherit !bg-transparent flex-1 mr-4 !text-gray-700" :data-source-rename-input-id="source.id" @click.stop @keydown.enter.stop.prevent @@ -763,13 +760,8 @@ const getSource = (sourceId: string) => { /> diff --git a/packages/nc-gui/components/smartsheet/Pagination.vue b/packages/nc-gui/components/smartsheet/Pagination.vue index d48bef4565..ce5c028455 100644 --- a/packages/nc-gui/components/smartsheet/Pagination.vue +++ b/packages/nc-gui/components/smartsheet/Pagination.vue @@ -93,12 +93,13 @@ const tempPageVal = ref(page.value) :class="{ 'border-t-1': !isGroupBy, 'h-13': isMobileMode, 'h-10': !isMobileMode }" :style="`${fixedSize ? `width: ${fixedSize}px;` : ''}${ isGroupBy ? 'margin-top:1px; border-radius: 0 0 8px 8px !important;' : '' - }${extraStyle}`" + } ${extraStyle}`" >
@@ -117,6 +118,9 @@ const tempPageVal = ref(page.value) :class="{ '-ml-17': isLeftSidebarOpen && !alignLeft, 'ml-8': alignLeft, + 'sticky': isGroupBy, + 'left-[159px]': isGroupBy && $slots['add-record'], + 'left-[32px]': isGroupBy && !$slots['add-record'], }" >
diff --git a/packages/nc-gui/components/smartsheet/column/RatingOptions.vue b/packages/nc-gui/components/smartsheet/column/RatingOptions.vue index 35ba8b54de..42f2720bc2 100644 --- a/packages/nc-gui/components/smartsheet/column/RatingOptions.vue +++ b/packages/nc-gui/components/smartsheet/column/RatingOptions.vue @@ -113,7 +113,12 @@ watch( - + diff --git a/packages/nc-gui/components/smartsheet/grid/GroupBy.vue b/packages/nc-gui/components/smartsheet/grid/GroupBy.vue index 84687e22eb..f3bd206cec 100644 --- a/packages/nc-gui/components/smartsheet/grid/GroupBy.vue +++ b/packages/nc-gui/components/smartsheet/grid/GroupBy.vue @@ -306,7 +306,6 @@ const computedWidth = computed(() => { }) const bgColor = computed(() => { - console.log(props.group.key, 'props.maxDepth', props.maxDepth, _depth) if (props.maxDepth === 3) { switch (_depth) { case 2: @@ -362,9 +361,8 @@ const bgColor = computed(() => { diff --git a/packages/nc-gui/components/virtual-cell/BelongsTo.vue b/packages/nc-gui/components/virtual-cell/BelongsTo.vue index 2930e32ecc..cbb0667c68 100644 --- a/packages/nc-gui/components/virtual-cell/BelongsTo.vue +++ b/packages/nc-gui/components/virtual-cell/BelongsTo.vue @@ -87,7 +87,7 @@ watch(value, (next) => {