From a930f7d242690840ef1962e9cbf4333039d9f1c2 Mon Sep 17 00:00:00 2001 From: mertmit Date: Tue, 19 Sep 2023 12:12:35 +0000 Subject: [PATCH 1/7] fix: revise frontend acl --- .../nc-gui/components/account/UserList.vue | 6 +- .../nc-gui/components/account/UsersModal.vue | 6 +- .../nc-gui/components/cell/MultiSelect.vue | 26 +-- .../nc-gui/components/cell/SingleSelect.vue | 25 +-- .../components/cell/attachment/Modal.vue | 6 +- .../dashboard/TreeView/AddNewTableNode.vue | 2 +- .../dashboard/TreeView/ProjectNode.vue | 10 +- .../dashboard/TreeView/TableNode.vue | 14 +- .../components/dashboard/TreeView/index.vue | 2 +- .../components/general/AddBaseButton.vue | 2 +- .../nc-gui/components/general/PreviewAs.vue | 9 +- .../project/InviteProjectCollabSection.vue | 10 +- packages/nc-gui/components/project/View.vue | 4 +- .../nc-gui/components/smartsheet/Form.vue | 4 +- .../nc-gui/components/smartsheet/Gallery.vue | 2 +- .../nc-gui/components/smartsheet/Kanban.vue | 2 +- .../smartsheet/expanded-form/Comments.vue | 2 +- .../smartsheet/expanded-form/Header.vue | 8 +- .../components/smartsheet/grid/Table.vue | 16 +- .../components/smartsheet/header/Cell.vue | 8 +- .../smartsheet/header/VirtualCell.vue | 2 +- .../smartsheet/sidebar/RenameableMenuItem.vue | 4 +- .../components/smartsheet/sidebar/index.vue | 2 +- .../toolbar/KanbanStackEditOrAdd.vue | 2 +- .../smartsheet/toolbar/MoreActions.vue | 2 +- .../smartsheet/toolbar/ShareView.vue | 2 +- .../smartsheet/toolbar/ViewActions.vue | 2 +- .../nc-gui/components/tabs/Smartsheet.vue | 2 +- .../components/tabs/auth/UserManagement.vue | 11 +- .../tabs/auth/user-management/UsersModal.vue | 19 +-- .../components/virtual-cell/BelongsTo.vue | 2 +- .../components/virtual-cell/HasMany.vue | 2 +- .../nc-gui/components/virtual-cell/Links.vue | 2 +- .../components/virtual-cell/ManyToMany.vue | 2 +- .../virtual-cell/components/ItemChip.vue | 2 +- .../components/workspace/ProjectList.vue | 16 +- .../nc-gui/composables/useGlobal/types.ts | 5 +- .../nc-gui/composables/useGridViewColumn.ts | 2 +- .../nc-gui/composables/useKanbanViewStore.ts | 2 +- .../nc-gui/composables/useMapViewDataStore.ts | 2 +- packages/nc-gui/composables/useRoles/index.ts | 21 +-- .../composables/useUIPermission/index.ts | 26 +-- packages/nc-gui/composables/useViewColumns.ts | 4 +- packages/nc-gui/composables/useViewData.ts | 2 +- packages/nc-gui/layouts/base.vue | 2 +- packages/nc-gui/layouts/new.vue | 2 +- packages/nc-gui/lib/constants.ts | 155 ++++++++++++------ packages/nc-gui/lib/enums.ts | 21 --- packages/nc-gui/lib/types.ts | 31 +--- packages/nc-gui/pages/account/index.vue | 2 +- packages/nc-gui/store/projectsShortcuts.ts | 2 +- packages/nc-gui/store/share.ts | 5 +- packages/nc-gui/utils/index.ts | 1 - packages/nc-gui/utils/userUtils.ts | 15 -- packages/nocodb-sdk/src/lib/globals.ts | 10 ++ .../nocodb-sdk/src/lib/helperFunctions.ts | 9 +- 56 files changed, 243 insertions(+), 314 deletions(-) delete mode 100644 packages/nc-gui/utils/userUtils.ts diff --git a/packages/nc-gui/components/account/UserList.vue b/packages/nc-gui/components/account/UserList.vue index 9e1b0186c1..d7f28f2e22 100644 --- a/packages/nc-gui/components/account/UserList.vue +++ b/packages/nc-gui/components/account/UserList.vue @@ -1,7 +1,7 @@ @@ -125,7 +125,7 @@ const canUserEditEmote = computed(() => { v-if="table.type === 'table'" class="flex w-5 !text-gray-500 text-sm" :class="{ - 'group-hover:text-gray-500': isUIAllowed('treeview-drag-n-drop', false, projectRole), + 'group-hover:text-gray-500': isUIAllowed('tableSort', false, projectRole), '!text-black': openedTableId === table.id, }" /> @@ -133,7 +133,7 @@ const canUserEditEmote = computed(() => { v-else class="flex w-5 !text-gray-500 text-sm" :class="{ - 'group-hover:text-gray-500': isUIAllowed('treeview-drag-n-drop', false, projectRole), + 'group-hover:text-gray-500': isUIAllowed('tableSort', false, projectRole), '!text-black': openedTableId === table.id, }" /> @@ -157,7 +157,7 @@ const canUserEditEmote = computed(() => { {