From 59f55e4595446aed02fbbb48e2d1afa6f6bc72bb Mon Sep 17 00:00:00 2001 From: Pranav C <61551451+pranavxc@users.noreply.github.com> Date: Mon, 19 Jul 2021 16:40:49 +0530 Subject: [PATCH] refactor(gui): update eslint rules Signed-off-by: Pranav C <61551451+pranavxc@users.noreply.github.com> --- packages/nc-gui/.eslintrc.json | 8 +- .../nc-gui/components/apiClient/headers.vue | 25 ++-- .../nc-gui/components/apiClient/params.vue | 24 ++-- .../nc-gui/components/apiClient/perfTest.vue | 6 +- packages/nc-gui/components/apiOverlay.vue | 14 +-- packages/nc-gui/components/auth.routes.js | 2 +- packages/nc-gui/components/auth/apiTokens.vue | 10 +- packages/nc-gui/components/auth/authHooks.vue | 6 +- packages/nc-gui/components/auth/roles.vue | 18 +-- .../nc-gui/components/auth/userManagement.vue | 44 +++---- packages/nc-gui/components/authTab.vue | 2 +- packages/nc-gui/components/changeEnv.vue | 8 +- .../nc-gui/components/createOrEditProject.vue | 100 +++++++-------- .../components/global/recursiveMenu.vue | 8 +- .../components/global/xAutoComplete.vue | 28 ++--- packages/nc-gui/components/global/xIcon.vue | 4 +- packages/nc-gui/components/monaco/Monaco.vue | 16 +-- .../components/monaco/MonacoSqlEditor.vue | 40 +++--- .../components/monaco/sqlAutoCompletions.js | 2 +- packages/nc-gui/components/notification.vue | 10 +- packages/nc-gui/components/project/apis.vue | 36 +++--- .../nc-gui/components/project/appStore.vue | 18 +-- .../components/project/appStore/FormInput.vue | 4 +- .../project/appStore/appInstall.vue | 18 +-- .../project/appStore/inputs/attachment.vue | 22 ++-- .../project/appStore/inputs/longTextField.vue | 10 +- .../project/appStore/inputs/passwordField.vue | 6 +- .../project/appStore/inputs/textField.vue | 6 +- .../nc-gui/components/project/appStoreOld.vue | 6 +- .../components/project/auditTab/audit.vue | 6 +- .../nc-gui/components/project/auditTab/db.vue | 34 ++--- .../nc-gui/components/project/cronJobs.vue | 18 +-- .../project/dlgs/dlgAddRelation.vue | 24 ++-- .../project/dlgs/dlgTriggerAddEdit.vue | 16 +-- .../project/functionTab/functionAcl.vue | 8 +- .../project/functionTab/functionQuery.vue | 24 ++-- .../project/gqlHandlerCodeEditor.vue | 8 +- .../components/project/graphqlClient.vue | 10 +- .../nc-gui/components/project/grpcClient.vue | 2 +- .../project/grpcHandlerCodeEditor.vue | 8 +- .../project/procedureTab/procedureAcl.vue | 8 +- .../project/procedureTab/procedureQuery.vue | 24 ++-- .../projectMetadata/disableOrEnableModels.vue | 12 +- .../sync/disableOrEnableFunctions.vue | 28 ++--- .../sync/disableOrEnableProcedures.vue | 28 ++--- .../sync/disableOrEnableRelations.vue | 12 +- .../sync/disableOrEnableTables.vue | 28 ++--- .../sync/disableOrEnableViews.vue | 28 ++--- .../uiAcl/toggleFunctionUIAcl.vue | 10 +- .../uiAcl/toggleProcedureUIAcl.vue | 10 +- .../uiAcl/toggleRelationsUIAcl.vue | 10 +- .../uiAcl/toggleTableUIAcl.vue | 10 +- .../projectMetadata/uiAcl/toggleViewUIAcl.vue | 10 +- .../project/restHandlerCodeEditor.vue | 8 +- packages/nc-gui/components/project/seed.vue | 30 ++--- .../nc-gui/components/project/sequence.vue | 24 ++-- .../project/settings/appearance.vue | 26 ++-- .../components/project/settings/env.vue | 4 +- .../components/project/settings/logs.vue | 10 +- .../project/settings/versionAndUpdate.vue | 42 +++---- .../components/project/settings/xcMeta.vue | 18 +-- .../project/spreadsheet/apis/apiFactory.js | 2 +- .../project/spreadsheet/apis/gqlApi.js | 50 ++++---- .../project/spreadsheet/apis/grpcApi.js | 4 +- .../project/spreadsheet/apis/restApi.js | 24 ++-- .../components/cell/attachmentCell.vue | 2 +- .../spreadsheet/components/cell/enumCell.vue | 2 +- .../components/cell/setListCell.vue | 2 +- .../spreadsheet/components/columnFilter.vue | 8 +- .../components/columnFilterMenu.vue | 12 +- .../spreadsheet/components/editColumn.vue | 38 +++--- .../editColumn/customSelectOptions.vue | 10 +- .../editColumn/linkedToAnotherOptions.vue | 16 +-- .../components/editColumn/relationOptions.vue | 18 +-- .../components/editVirtualColumn.vue | 12 +- .../spreadsheet/components/editableCell.vue | 14 +-- .../components/editableCell/booleanCell.vue | 8 +- .../editableCell/datePickerCell.vue | 8 +- .../editableCell/dateTimePickerCell.vue | 8 +- .../editableCell/editableAttachmentCell.vue | 24 ++-- .../editableCell/enumListEditableCell.vue | 10 +- .../editableCell/enumRadioEditableCell.vue | 12 +- .../components/editableCell/floatCell.vue | 8 +- .../components/editableCell/integerCell.vue | 8 +- .../components/editableCell/jsonCell.vue | 12 +- .../editableCell/setListCheckboxCell.vue | 14 +-- .../editableCell/setListEditableCell.vue | 10 +- .../components/editableCell/textAreaCell.vue | 10 +- .../editableCell/textAreaCellOld.vue | 12 +- .../components/editableCell/textCell.vue | 8 +- .../editableCell/timePickerCell.vue | 8 +- .../spreadsheet/components/expandedForm.vue | 40 +++--- .../project/spreadsheet/components/extras.vue | 2 +- .../spreadsheet/components/fieldsMenu.vue | 24 ++-- .../spreadsheet/components/headerCell.vue | 4 +- .../spreadsheet/components/lockMenu.vue | 2 +- .../spreadsheet/components/pagination.vue | 4 +- .../components/sharedViewsList.vue | 8 +- .../spreadsheet/components/sortListMenu.vue | 8 +- .../components/spreadsheetNavDrawer.vue | 40 +++--- .../spreadsheet/components/virtualCell.vue | 10 +- .../components/virtualCell/belogsToCell.vue | 46 +++---- .../virtualCell/components/listChildItems.vue | 14 +-- .../components/listChildItemsModal.vue | 10 +- .../virtualCell/components/listItems.vue | 12 +- .../components/virtualCell/hasManyCell.vue | 54 ++++---- .../components/virtualCell/manyToManyCell.vue | 56 ++++----- .../components/virtualHeaderCell.vue | 14 +-- .../spreadsheet/dialog/createViewDialog.vue | 8 +- .../project/spreadsheet/mixins/cell.js | 32 ++--- .../project/spreadsheet/mixins/spreadsheet.js | 54 ++++---- .../spreadsheet/overlay/additinalFeatures.vue | 4 +- .../project/spreadsheet/rowsXcDataTable.vue | 64 +++++----- .../spreadsheet/views/calendarView.vue | 6 +- .../project/spreadsheet/views/galleryView.vue | 4 +- .../project/spreadsheet/views/xcGridView.vue | 58 ++++----- .../project/spreadsheet/xcTable.vue | 52 ++++---- .../components/project/sqlLogAndOutput.vue | 4 +- .../components/project/swaggerClient.vue | 10 +- packages/nc-gui/components/project/table.vue | 36 +++--- .../nc-gui/components/project/tableOld.vue | 34 ++--- .../components/project/tableTabs/aclGql.vue | 26 ++-- .../project/tableTabs/aclGrpcDb.vue | 26 ++-- .../components/project/tableTabs/aclJs.vue | 26 ++-- .../project/tableTabs/aclTsFile.vue | 12 +- .../project/tableTabs/aclTsFileChild.vue | 30 ++--- .../project/tableTabs/aclTsFileDb.vue | 16 +-- .../project/tableTabs/aclTsFileDbChild.vue | 34 ++--- .../project/tableTabs/aclTsFileDbGql.vue | 26 ++-- .../project/tableTabs/aclTsFileGql.vue | 26 ++-- .../tableTabs/columnActions/jsonToColumn.vue | 20 +-- .../components/project/tableTabs/columns.vue | 116 +++++++++--------- .../project/tableTabs/columnsMock.vue | 80 ++++++------ .../project/tableTabs/constraints.vue | 18 +-- .../project/tableTabs/customAcl.vue | 16 +-- .../components/project/tableTabs/indexes.vue | 66 +++++----- .../components/project/tableTabs/logicGql.vue | 14 +-- .../project/tableTabs/logicGrpc.vue | 12 +- .../project/tableTabs/logicRest.vue | 18 +-- .../components/project/tableTabs/mocks.vue | 26 ++-- .../project/tableTabs/relations.vue | 22 ++-- .../components/project/tableTabs/rows.vue | 42 +++---- .../components/project/tableTabs/tableAcl.vue | 20 +-- .../components/project/tableTabs/triggers.vue | 28 ++--- .../project/tableTabs/validation.vue | 18 +-- .../project/tableTabs/webhook/httpWebhook.vue | 10 +- .../project/tableTabs/webhookEvent.vue | 4 +- .../project/tableTabs/webhooks-old.vue | 4 +- .../components/project/tableTabs/webhooks.vue | 18 +-- .../project/viewTabs/viewColumns.vue | 22 ++-- .../components/project/viewTabs/viewQuery.vue | 24 ++-- .../project/viewTabs/viewSpreadsheet.vue | 42 +++---- packages/nc-gui/components/project/xcInfo.vue | 10 +- packages/nc-gui/components/projectLogs.vue | 20 +-- packages/nc-gui/components/projectOutput.vue | 16 +-- packages/nc-gui/components/projectTabs.vue | 32 ++--- packages/nc-gui/components/screensaver.vue | 4 +- packages/nc-gui/components/settings.vue | 62 +++++----- packages/nc-gui/components/snackbar.vue | 8 +- packages/nc-gui/components/trialExpired.vue | 2 +- .../components/utils/dlgLabelSubmitCancel.vue | 16 +-- packages/nc-gui/components/utils/dlgOk.vue | 16 +-- packages/nc-gui/components/utils/dlgOkNew.vue | 6 +- .../components/utils/dlgProjectCreate.vue | 6 +- .../components/utils/dlgTableCreate.vue | 12 +- .../components/utils/dlgTextSubmitCancel.vue | 18 +-- .../components/utils/dlgUnexpectedError.vue | 16 +-- .../nc-gui/components/utils/dlgViewCreate.vue | 12 +- packages/nc-gui/components/utils/language.vue | 6 +- packages/nc-gui/components/xTerm.vue | 40 +++--- packages/nc-gui/components/xcDiff.vue | 8 +- packages/nc-gui/config/vuetify.options.js | 2 +- packages/nc-gui/helpers/MssqlUi.js | 52 ++++---- packages/nc-gui/helpers/MysqlUi.js | 52 ++++---- packages/nc-gui/helpers/OracleUi.js | 44 +++---- packages/nc-gui/helpers/PgUi.js | 52 ++++---- packages/nc-gui/helpers/SqlQueryParser.js | 4 +- packages/nc-gui/helpers/SqlUiFactory.js | 2 +- packages/nc-gui/helpers/SqliteUi.js | 52 ++++---- packages/nc-gui/helpers/Utils.js | 4 +- packages/nc-gui/helpers/XcApiHelp.js | 6 +- packages/nc-gui/helpers/debounce.js | 2 +- packages/nc-gui/helpers/deepFind.js | 2 +- packages/nc-gui/helpers/deepSet.js | 2 +- packages/nc-gui/helpers/fileReader.js | 8 +- .../nc-gui/helpers/findDataTypeMapping.js | 2 +- packages/nc-gui/helpers/setProp.js | 2 +- packages/nc-gui/helpers/xutils.js | 8 +- packages/nc-gui/layouts/default.vue | 98 +++++++-------- packages/nc-gui/layouts/empty.vue | 4 +- packages/nc-gui/layouts/error1.vue | 4 +- packages/nc-gui/middleware/auth.js | 2 +- packages/nc-gui/mixins/colors.js | 4 +- packages/nc-gui/mixins/device.js | 30 ++--- packages/nc-gui/nuxt.config.js | 2 +- packages/nc-gui/pages/error/400.vue | 16 +-- packages/nc-gui/pages/error/403.vue | 16 +-- packages/nc-gui/pages/error/404.vue | 16 +-- packages/nc-gui/pages/index.vue | 16 +-- packages/nc-gui/pages/nc/_project_id.vue | 14 +-- packages/nc-gui/pages/nc/index.vue | 6 +- packages/nc-gui/pages/project/name.vue | 6 +- packages/nc-gui/pages/project/xcdb.vue | 6 +- packages/nc-gui/pages/projects/index.vue | 52 ++++---- packages/nc-gui/pages/user/admin/index.vue | 18 +-- .../nc-gui/pages/user/admin/user-edit.vue | 18 +-- .../nc-gui/pages/user/admin/user/_userId.vue | 20 +-- .../pages/user/authentication/index.vue | 16 +-- .../pages/user/authentication/signin.vue | 40 +++--- .../user/authentication/signup/_token.vue | 48 ++++---- .../user/authentication/signup/index.vue | 46 +++---- packages/nc-gui/pages/user/index.vue | 16 +-- .../nc-gui/pages/user/password/forgot.vue | 20 +-- packages/nc-gui/pages/user/password/index.vue | 16 +-- .../nc-gui/pages/user/password/reset/form.vue | 18 +-- .../pages/user/password/reset/index.vue | 22 ++-- .../pages/user/password/reset/invalid.vue | 16 +-- .../pages/user/password/reset/success.vue | 16 +-- .../nc-gui/pages/user/settings/accounts.vue | 22 ++-- packages/nc-gui/pages/user/settings/index.vue | 26 ++-- .../nc-gui/pages/user/settings/password.vue | 18 +-- .../nc-gui/pages/user/settings/picture.vue | 20 +-- .../nc-gui/pages/user/settings/profile.vue | 18 +-- packages/nc-gui/plugins/axiosInterceptor.js | 4 +- packages/nc-gui/plugins/globalEventBus.js | 2 +- packages/nc-gui/plugins/globalMixin.js | 14 +-- packages/nc-gui/plugins/hotjar.js | 4 +- packages/nc-gui/plugins/localStorage.js | 4 +- packages/nc-gui/plugins/projectLoader.js | 2 +- packages/nc-gui/plugins/tawk.js | 2 +- packages/nc-gui/plugins/xutils.js | 4 +- packages/nc-gui/store/admin.js | 12 +- packages/nc-gui/store/apiClient.js | 20 +-- packages/nc-gui/store/apiClientSwagger.js | 20 +-- packages/nc-gui/store/apiServer.js | 14 +-- packages/nc-gui/store/graphqlClient.js | 4 +- packages/nc-gui/store/meta.js | 8 +- packages/nc-gui/store/notification.js | 8 +- packages/nc-gui/store/outputs.js | 4 +- packages/nc-gui/store/panelSize.js | 2 +- packages/nc-gui/store/plugins.js | 8 +- packages/nc-gui/store/snackbar.js | 2 +- packages/nc-gui/store/sqlClient.js | 26 ++-- packages/nc-gui/store/sqlMgr.js | 10 +- packages/nc-gui/store/tabs.js | 36 +++--- packages/nc-gui/store/tempProjects.js | 12 +- packages/nc-gui/store/users.js | 92 +++++++------- packages/nc-gui/store/windows.js | 74 +++++------ packages/nc-gui/xc.js | 2 +- 249 files changed, 2358 insertions(+), 2353 deletions(-) diff --git a/packages/nc-gui/.eslintrc.json b/packages/nc-gui/.eslintrc.json index 2c3c06e874..f9e2c2c8a6 100644 --- a/packages/nc-gui/.eslintrc.json +++ b/packages/nc-gui/.eslintrc.json @@ -13,9 +13,11 @@ ], "rules": { "no-console": "off", - // "space-before-function-paren": "off", - "require-await": "off", - "vue/no-mutating-props": "off" + "space-before-function-paren": [ + "error", + "never" + ], + "require-await": "off" }, "parserOptions": { "parser": "babel-eslint", diff --git a/packages/nc-gui/components/apiClient/headers.vue b/packages/nc-gui/components/apiClient/headers.vue index d5f7730849..2f7cc1ff93 100644 --- a/packages/nc-gui/components/apiClient/headers.vue +++ b/packages/nc-gui/components/apiClient/headers.vue @@ -1,4 +1,5 @@ -