From 52a6527c9b704c48e8ed8fc7a3925aa2e978f33a Mon Sep 17 00:00:00 2001 From: Pranav C Date: Wed, 10 Aug 2022 20:07:53 +0530 Subject: [PATCH] fix(gui-v2): avoid flickering menu while hiding Signed-off-by: Pranav C --- .../nc-gui-v2/components/smartsheet-column/EditOrAdd.vue | 6 +++++- packages/nc-gui-v2/composables/useColumnCreateStore.ts | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/nc-gui-v2/components/smartsheet-column/EditOrAdd.vue b/packages/nc-gui-v2/components/smartsheet-column/EditOrAdd.vue index 0a0080b41d..da7c4578de 100644 --- a/packages/nc-gui-v2/components/smartsheet-column/EditOrAdd.vue +++ b/packages/nc-gui-v2/components/smartsheet-column/EditOrAdd.vue @@ -59,7 +59,11 @@ function onCancel() { async function onSubmit() { await addOrUpdate(reloadMetaAndData) - advancedOptions.value = false + + // add delay to complete the minimize transition + setTimeout(() => { + advancedOptions.value = false + }, 500) } // create column meta if it's a new column diff --git a/packages/nc-gui-v2/composables/useColumnCreateStore.ts b/packages/nc-gui-v2/composables/useColumnCreateStore.ts index 2a99849b50..20df294c4b 100644 --- a/packages/nc-gui-v2/composables/useColumnCreateStore.ts +++ b/packages/nc-gui-v2/composables/useColumnCreateStore.ts @@ -174,7 +174,7 @@ const [useProvideColumnCreateStore, useColumnCreateStore] = createInjectionState if (cdf) formState.value.cdf = formState.value.cdf || null } - const addOrUpdate = async (onSuccess: () => {}) => { + const addOrUpdate = async (onSuccess: () => void) => { try { console.log(formState, validators) if (!(await validate())) return